Differential D1199

README: add testcloud dependency
ClosedPublic
Actions

Authored by kparal on May 18 2017, 1:36 PM.

Details

Reviewers
mkrizek
Group Reviewers
libtaskotron
Commits
rLTRN20940651b087: README: add libvirt-python dependency
Summary

We import testcloud in our modules, but it wasn't mentioned in the
README. In turn, even docs building has been failing.

Test Plan

worked in a clean VM after testcloud was installed

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal created this revision.May 18 2017, 1:36 PM
mkrizek added a subscriber: mkrizek.May 18 2017, 1:40 PM

testcloud is in PyPI, it should be installed through requirements.txt, no?

kparal planned changes to this revision.May 18 2017, 2:08 PM

Ah, good catch. The actual problem was with missing libvirt-python. That's a dependency of testcloud, but it clearly doesn't state it on the pypi package. So, we should add the dep to the testcloud package (I'll create a patch). The drawback is that libvirt-python is a bit problematic to install from pypi, it requires to compile some libvirt modules, so it might be actually easier to install it as an rpm anyway. Will look into it.

kparal added a comment.May 19 2017, 1:34 PM

OK, so, testcloud deps were fixed in D1200 and pushed to pypi.

There's still one problem, though. testcloud depends on libvirt-python. That can be installed from pypi, but requires gcc and libvirt-devel installed, otherwise the installation will fail. So we either need to include libvirt-devel in README, or libvirt-python straight away. Adding libvirt-python seems like the more friendly approach. Adjusting patch.

kparal updated this revision to Diff 3048.May 19 2017, 1:36 PM
  • add libvirt-python to readme instead, require fixed testcloud from pypi
mkrizek accepted this revision.May 22 2017, 8:15 AM
This revision is now accepted and ready to land.May 22 2017, 8:15 AM
Closed by commit rLTRN20940651b087: README: add libvirt-python dependency (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyMay 22 2017, 10:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
MREADME.rst (1 line)
Mrequirements.txt (2 lines)

Diff 3051

View Options

README.rst

Show All 34 Lines
35On your Fedora system, install the necessary packages:: 35​On your Fedora system, install the necessary packages::
36 36​
37 sudo dnf install \ 37​ sudo dnf install \
38 createrepo \ 38​ createrepo \
39 gcc \ 39​ gcc \
40 git \ 40​ git \
41 koji \ 41​ koji \
42 libtaskotron-config \ 42​ libtaskotron-config \
43​ libvirt-python \
43 mash \ 44​ mash \
44 python-doit \ 45​ python-doit \
45 python-hawkey \ 46​ python-hawkey \
46 python-pip \ 47​ python-pip \
47 python-rpmfluff \ 48​ python-rpmfluff \
48 python-virtualenv \ 49​ python-virtualenv \
49 rpm-build \ 50​ rpm-build \
50 rpm-python 51​ rpm-python
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines
View Options

requirements.txt

Show All 16 Lines
17PyYAML >= 3.11 17​PyYAML >= 3.11
18 18​
19# libtaskotron-fedora 19​# libtaskotron-fedora
20python-fedora >= 0.8.0 20​python-fedora >= 0.8.0
21munch >= 2.0.2 21​munch >= 2.0.2
22 22​
23# libtaskotron-disposable 23​# libtaskotron-disposable
24paramiko >= 1.15.1 24​paramiko >= 1.15.1
25testcloud >= 0.1.10 25​testcloud >= 0.1.12
26 26​
27# Test suite requirements 27​# Test suite requirements
28dingus >= 0.3.4 28​dingus >= 0.3.4
29mock >= 2.0.0 29​mock >= 2.0.0
30pytest >= 2.7.3 30​pytest >= 2.7.3
31pytest-cov >= 2.2.1 31​pytest-cov >= 2.2.1
32 32​
33# Documentation requirements 33​# Documentation requirements
34Sphinx >= 1.2.3 34​Sphinx >= 1.2.3
35sphinx_rtd_theme >= 0.1.9 35​sphinx_rtd_theme >= 0.1.9