Differential D1194

add custom btrfs partitioning test for blivet-gui
ClosedPublic
Actions

Authored by jsedlak on May 10 2017, 12:25 PM.

Details

Reviewers
adamwill
jskladan
Maniphest Tasks
T938: Duplicate custom partitioning tests for blivet-gui
Commits
rOPENQATESTS0b5f865c8f0b: add custom btrfs partitioning test for blivet-gui
Summary

This adds remaining btrfs test for blivet-gui. I've installed
Fedora on btrfs using legacy partitioning GUI and then tried to replicate
the same partitioning using blivet-gui. I've NOT created separate btrfs
subvolume for "/home", as it's not necessary for testcase (it tests btrfs
subvolumes by using subvolume for "/") and it would complicate things.

Test Plan

Run custom_blivet_btrfs test.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsedlak created this revision.May 10 2017, 12:25 PM
jsedlak updated this revision to Diff 3036.May 17 2017, 12:00 PM
  • correct comment about number of disks in custom btrfs
adamwill accepted this revision.May 18 2017, 7:03 PM

Looks fine, assuming it really does create a btrfs volume with a / subvolume.

Note: I think the priority for all x86_64 blivet tests should match the priority for the x86_64 custom part tests. prio 90 is, IIRC, the value we use for i386 tests, since they're less important than x86_64, to ensure they run last.

This revision is now accepted and ready to land.May 18 2017, 7:03 PM
Closed by commit rOPENQATESTS0b5f865c8f0b: add custom btrfs partitioning test for blivet-gui (authored by jsedlak). · Explain WhyMay 19 2017, 11:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 3045

View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_lvm_drive-20170420.json

  • This file was moved to needles/anaconda/partitioning/blivet/anaconda_blivet_volumes_icon-20170420.json.
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_lvm_drive-20170420.png

  • This file was moved to needles/anaconda/partitioning/blivet/anaconda_blivet_volumes_icon-20170420.png.
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_btrfs-20170510.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 419,
5​ "ypos": 197,
6​ "width": 32,
7​ "height": 18,
8​ "type": "match"
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_blivet_part_fs_btrfs"
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_btrfs-20170510.png

  • This binary file was added.
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_volumes_icon-20170420.json

  • This file was moved from needles/anaconda/partitioning/blivet/anaconda_blivet_lvm_drive-20170420.json.
1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 39, 4​ "xpos": 39,
5 "ypos": 186, 5​ "ypos": 186,
6 "width": 36, 6​ "width": 36,
7 "height": 35, 7​ "height": 35,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "properties": [], 11​ "properties": [],
12 "tags": [ 12​ "tags": [
13 "anaconda_blivet_lvm_drive" 13​ "anaconda_blivet_volumes_icon"
14 ] 14​ ]
15} 15​}
16No newline at end of file ​
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_volumes_icon-20170420.png

  • This file was moved from needles/anaconda/partitioning/blivet/anaconda_blivet_lvm_drive-20170420.png.
The contents of this file were not changed.
View Options

templates

Show First 20 Lines • Show All 893 Lines • ▼ Show 20 Line(s)892 product => {
894 distri => "fedora", 894​ distri => "fedora",
895 flavor => "universal", 895​ flavor => "universal",
896 version => "*", 896​ version => "*",
897 }, 897​ },
898 test_suite => { name => "install_iscsi" }, 898​ test_suite => { name => "install_iscsi" },
899 }, 899​ },
900 { 900​ {
901 machine => { name => "64bit" }, 901​ machine => { name => "64bit" },
902 prio => 90, 902​ prio => 40,
903 product => { 903​ product => {
904 arch => "x86_64", 904​ arch => "x86_64",
905 distri => "fedora", 905​ distri => "fedora",
906 flavor => "universal", 906​ flavor => "universal",
907 version => "*", 907​ version => "*",
908 }, 908​ },
909 test_suite => { name => "install_blivet_ext3" }, 909​ test_suite => { name => "install_blivet_ext3" },
910 }, 910​ },
911 { 911​ {
912 machine => { name => "64bit" }, 912​ machine => { name => "64bit" },
913 prio => 90, 913​ prio => 40,
914​ product => {
915​ arch => "x86_64",
916​ distri => "fedora",
917​ flavor => "universal",
918​ version => "*",
919​ },
920​ test_suite => { name => "install_blivet_btrfs" },
921​ },
922​ {
923​ machine => { name => "64bit" },
924​ prio => 50,
914 product => { 925​ product => {
915 arch => "x86_64", 926​ arch => "x86_64",
916 distri => "fedora", 927​ distri => "fedora",
917 flavor => "universal", 928​ flavor => "universal",
918 version => "*", 929​ version => "*",
919 }, 930​ },
920 test_suite => { name => "install_blivet_no_swap" }, 931​ test_suite => { name => "install_blivet_no_swap" },
921 }, 932​ },
922 { 933​ {
923 machine => { name => "64bit" }, 934​ machine => { name => "64bit" },
924 prio => 90, 935​ prio => 40,
925 product => { 936​ product => {
926 arch => "x86_64", 937​ arch => "x86_64",
927 distri => "fedora", 938​ distri => "fedora",
928 flavor => "universal", 939​ flavor => "universal",
929 version => "*", 940​ version => "*",
930 }, 941​ },
931 test_suite => { name => "install_blivet_xfs" }, 942​ test_suite => { name => "install_blivet_xfs" },
932 }, 943​ },
933 { 944​ {
934 machine => { name => "64bit" }, 945​ machine => { name => "64bit" },
935 prio => 90, 946​ prio => 40,
936 product => { 947​ product => {
937 arch => "x86_64", 948​ arch => "x86_64",
938 distri => "fedora", 949​ distri => "fedora",
939 flavor => "universal", 950​ flavor => "universal",
940 version => "*", 951​ version => "*",
941 }, 952​ },
942 test_suite => { name => "install_blivet_software_raid" }, 953​ test_suite => { name => "install_blivet_software_raid" },
943 }, 954​ },
944 { 955​ {
945 machine => { name => "64bit" }, 956​ machine => { name => "64bit" },
946 prio => 90, 957​ prio => 40,
947 product => { 958​ product => {
948 arch => "x86_64", 959​ arch => "x86_64",
949 distri => "fedora", 960​ distri => "fedora",
950 flavor => "universal", 961​ flavor => "universal",
951 version => "*", 962​ version => "*",
952 }, 963​ },
953 test_suite => { name => "install_blivet_lvmthin" }, 964​ test_suite => { name => "install_blivet_lvmthin" },
954 }, 965​ },
▲ Show 20 Lines • Show All 529 Lines • ▼ Show 20 Line(s)1494 {
1484 machine => { name => "64bit" }, 1495​ machine => { name => "64bit" },
1485 prio => 93, 1496​ prio => 93,
1486 product => { 1497​ product => {
1487 arch => "i386", 1498​ arch => "i386",
1488 distri => "fedora", 1499​ distri => "fedora",
1489 flavor => "universal", 1500​ flavor => "universal",
1490 version => "*", 1501​ version => "*",
1491 }, 1502​ },
1503​ test_suite => { name => "install_blivet_btrfs" },
1504​ },
1505​ {
1506​ machine => { name => "64bit" },
1507​ prio => 93,
1508​ product => {
1509​ arch => "i386",
1510​ distri => "fedora",
1511​ flavor => "universal",
1512​ version => "*",
1513​ },
1492 test_suite => { name => "install_blivet_no_swap" }, 1514​ test_suite => { name => "install_blivet_no_swap" },
1493 }, 1515​ },
1494 { 1516​ {
1495 machine => { name => "64bit" }, 1517​ machine => { name => "64bit" },
1496 prio => 93, 1518​ prio => 93,
1497 product => { 1519​ product => {
1498 arch => "i386", 1520​ arch => "i386",
1499 distri => "fedora", 1521​ distri => "fedora",
▲ Show 20 Lines • Show All 490 Lines • ▼ Show 20 Line(s)2011 {
1990 name => "install_blivet_ext3", 2012​ name => "install_blivet_ext3",
1991 settings => [ 2013​ settings => [
1992 { key => "PARTITIONING", value => "custom_blivet_ext3" }, 2014​ { key => "PARTITIONING", value => "custom_blivet_ext3" },
1993 { key => "POSTINSTALL", value => "disk_custom_ext3_postinstall" }, 2015​ { key => "POSTINSTALL", value => "disk_custom_ext3_postinstall" },
1994 { key => "ROOT_PASSWORD", value => "weakpassword" }, 2016​ { key => "ROOT_PASSWORD", value => "weakpassword" },
1995 ], 2017​ ],
1996 }, 2018​ },
1997 { 2019​ {
2020​ name => "install_blivet_btrfs",
2021​ settings => [
2022​ { key => "PARTITIONING", value => "custom_blivet_btrfs" },
2023​ { key => "POSTINSTALL", value => "disk_custom_btrfs_postinstall" },
2024​ { key => "ROOT_PASSWORD", value => "weakpassword" },
2025​ ],
2026​ },
2027​ {
1998 name => "install_blivet_no_swap", 2028​ name => "install_blivet_no_swap",
1999 settings => [ 2029​ settings => [
2000 { key => "PARTITIONING", value => "custom_blivet_no_swap" }, 2030​ { key => "PARTITIONING", value => "custom_blivet_no_swap" },
2001 { key => "POSTINSTALL", value => "disk_custom_no_swap_postinstall" }, 2031​ { key => "POSTINSTALL", value => "disk_custom_no_swap_postinstall" },
2002 { key => "ROOT_PASSWORD", value => "weakpassword" }, 2032​ { key => "ROOT_PASSWORD", value => "weakpassword" },
2003 ], 2033​ ],
2004 }, 2034​ },
2005 { 2035​ {
▲ Show 20 Lines • Show All 570 Lines • Show Last 20 Lines
View Options

tests/disk_custom_blivet_btrfs.pm

  • This file was copied from tests/disk_custom_blivet_lvmthin.pm.
1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 13​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 # add new LVM device ​
15 custom_blivet_add_partition(devicetype => 'lvm'); ​
16 # select newly created LVM device for adding new partition ​
17 assert_and_click "anaconda_blivet_lvm_drive"; ​
18 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 14​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
19 # add lvmthinpool 15​
20 custom_blivet_add_partition(devicetype => 'lvmthin'); 16​ # selecting "btrfs" as filesystem creates new BTRFS drive in blivet-gui
21 # select lvmthinpool for adding new partitions 17​ custom_blivet_add_partition(filesystem => 'btrfs');
22 assert_and_click "anaconda_blivet_thinpool_part"; 18​ # select newly created BTRFS drive (let's hope that BTRFS drive is only volume present)
19​ assert_and_click "anaconda_blivet_volumes_icon";
20​ # add root partition to btrfs drive
23 custom_blivet_add_partition(mountpoint => '/'); 21​ custom_blivet_add_partition(mountpoint => '/');
24 22​
25 assert_and_click "anaconda_spoke_done"; 23​ assert_and_click "anaconda_spoke_done";
26 assert_and_click "anaconda_part_accept_changes"; 24​ assert_and_click "anaconda_part_accept_changes";
27 25​
28 # Anaconda hub 26​ # Anaconda hub
29 assert_screen "anaconda_main_hub", 300; # 27​ assert_screen "anaconda_main_hub", 300; #
30 28​
Show All 9 Lines
View Options

tests/disk_custom_blivet_lvmthin.pm

  • This file was copied to tests/disk_custom_blivet_btrfs.pm.
1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 13​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 # add new LVM device 14​ # add new LVM device
15 custom_blivet_add_partition(devicetype => 'lvm'); 15​ custom_blivet_add_partition(devicetype => 'lvm');
16 # select newly created LVM device for adding new partition 16​ # select newly created LVM device for adding new partition
17 assert_and_click "anaconda_blivet_lvm_drive"; 17​ assert_and_click "anaconda_blivet_volumes_icon";
18 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 18​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
19 # add lvmthinpool 19​ # add lvmthinpool
20 custom_blivet_add_partition(devicetype => 'lvmthin'); 20​ custom_blivet_add_partition(devicetype => 'lvmthin');
21 # select lvmthinpool for adding new partitions 21​ # select lvmthinpool for adding new partitions
22 assert_and_click "anaconda_blivet_thinpool_part"; 22​ assert_and_click "anaconda_blivet_thinpool_part";
23 custom_blivet_add_partition(mountpoint => '/'); 23​ custom_blivet_add_partition(mountpoint => '/');
24 24​
25 assert_and_click "anaconda_spoke_done"; 25​ assert_and_click "anaconda_spoke_done";
Show All 14 Lines