add postinstalls to custom partitioning tests
ClosedPublic
Actions

Authored by jsedlak on May 4 2017, 10:23 AM.

Details

Reviewers

adamwill
jskladan

Commits

rOPENQATESTSea5296b3060c: add postinstalls to custom partitioning tests

Summary

During blivet test development, I have noticed that we
don't really check whether custom partitioning worked as expected
(we only check that installed system boots), so I've added poinstall
tests for all our custom partitioning tests and also set them as POSTINSTALL
for blivet tests.

Test Plan

Run custom partitioning and blivet tests and check that postinstall
test are added and that they pass.

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jsedlak created this revision.May 4 2017, 10:23 AM

Herald added a subscriber: tflink. · View Herald TranscriptMay 4 2017, 10:23 AM

Thanks a lot for doing this! I've had it on my todo list approximately forever, but never got around to it.

As a general note, I try to avoid using validate_script_output as much as possible because it involves a lot of console typing and increases the likelihood of a typing fail. I prefer instead to use assert_script_run and set up the actual grep command that's run inside the VM so it'll produce the appropriate result; that executes faster and is less prone to error. Can you try rewriting this that way, if you don't mind?

This revision now requires changes to proceed.May 4 2017, 7:59 PM

use assert_script_run

Looks good!

This revision is now accepted and ready to land.May 5 2017, 4:33 PM

Closed by commit rOPENQATESTSea5296b3060c: add postinstalls to custom partitioning tests (authored by jsedlak). · Explain WhyMay 9 2017, 7:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

		Path
M		templates (4 lines)
P		tests/disk_custom_btrfs_postinstall.pm (4 lines) Copied from tests/disk_custom_software_raid_postinstall.pm
P		tests/disk_custom_ext3_postinstall.pm (4 lines) Copied from tests/disk_custom_software_raid_postinstall.pm
A	M	tests/disk_custom_lvmthin_postinstall.pm (19 lines)
P		tests/disk_custom_no_swap_postinstall.pm (4 lines) Copied from tests/disk_custom_software_raid_postinstall.pm
P		tests/disk_custom_software_raid_postinstall.pm (2 lines) Copied to multiple locations: tests/disk_custom_btrfs_postinstall.pm tests/disk_custom_ext3_postinstall.pm tests/disk_custom_no_swap_postinstall.pm tests/disk_custom_xfs_postinstall.pm
P		tests/disk_custom_xfs_postinstall.pm (4 lines) Copied from tests/disk_custom_software_raid_postinstall.pm

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3026	7d07147		May 4 2017, 10:23 AM	★	★
Diff 2	3029	5e2a76e	use assert_script_run	May 5 2017, 1:27 PM	★	★
Diff 3	3030	5e2a76e	rOPENQATESTSea5296b3060c483f6b0d707de662c1eed8be4585	May 9 2017, 7:11 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
ab5c6cd9ede9	8582df73bac2	5e2a76efde10	Jan Sedlák	add postinstalls to custom partitioning tests (Show More…)	May 4 2017, 10:20 AM

Diff 3030

View Options

templates

Show First 20 Lines • Show All 1984 Lines • ▼ Show 20 Line(s)		1984	settings => [
1985	{ key => "PARTITIONING", value => "custom_no_swap" },	1985		{ key => "PARTITIONING", value => "custom_no_swap" },
1986	{ key => "ROOT_PASSWORD", value => "weakpassword" },	1986		{ key => "ROOT_PASSWORD", value => "weakpassword" },
1987	],	1987		],
1988	},	1988		},
1989	{	1989		{
1990	name => "install_blivet_ext3",	1990		name => "install_blivet_ext3",
1991	settings => [	1991		settings => [
1992	{ key => "PARTITIONING", value => "custom_blivet_ext3" },	1992		{ key => "PARTITIONING", value => "custom_blivet_ext3" },
		1993		{ key => "POSTINSTALL", value => "disk_custom_ext3_postinstall" },
1993	{ key => "ROOT_PASSWORD", value => "weakpassword" },	1994		{ key => "ROOT_PASSWORD", value => "weakpassword" },
1994	],	1995		],
1995	},	1996		},
1996	{	1997		{
1997	name => "install_blivet_no_swap",	1998		name => "install_blivet_no_swap",
1998	settings => [	1999		settings => [
1999	{ key => "PARTITIONING", value => "custom_blivet_no_swap" },	2000		{ key => "PARTITIONING", value => "custom_blivet_no_swap" },
		2001		{ key => "POSTINSTALL", value => "disk_custom_no_swap_postinstall" },
2000	{ key => "ROOT_PASSWORD", value => "weakpassword" },	2002		{ key => "ROOT_PASSWORD", value => "weakpassword" },
2001	],	2003		],
2002	},	2004		},
2003	{	2005		{
2004	name => "install_blivet_xfs",	2006		name => "install_blivet_xfs",
2005	settings => [	2007		settings => [
2006	{ key => "PARTITIONING", value => "custom_blivet_xfs" },	2008		{ key => "PARTITIONING", value => "custom_blivet_xfs" },
		2009		{ key => "POSTINSTALL", value => "disk_custom_xfs_postinstall" },
2007	{ key => "ROOT_PASSWORD", value => "weakpassword" },	2010		{ key => "ROOT_PASSWORD", value => "weakpassword" },
2008	],	2011		],
2009	},	2012		},
2010	{	2013		{
2011	name => "install_blivet_software_raid",	2014		name => "install_blivet_software_raid",
2012	settings => [	2015		settings => [
2013	{ key => "PARTITIONING", value => "custom_blivet_software_raid" },	2016		{ key => "PARTITIONING", value => "custom_blivet_software_raid" },
2014	{ key => "POSTINSTALL", value => "disk_custom_software_raid_postinstall" },	2017		{ key => "POSTINSTALL", value => "disk_custom_software_raid_postinstall" },
2015	{ key => "NUMDISKS", value => "2" },	2018		{ key => "NUMDISKS", value => "2" },
2016	{ key => "ROOT_PASSWORD", value => "weakpassword" },	2019		{ key => "ROOT_PASSWORD", value => "weakpassword" },
2017	],	2020		],
2018	},	2021		},
2019	{	2022		{
2020	name => "install_blivet_lvmthin",	2023		name => "install_blivet_lvmthin",
2021	settings => [	2024		settings => [
2022	{ key => "PARTITIONING", value => "custom_blivet_lvmthin" },	2025		{ key => "PARTITIONING", value => "custom_blivet_lvmthin" },
		2026		{ key => "POSTINSTALL", value => "disk_custom_lvmthin_postinstall" },
2023	{ key => "ROOT_PASSWORD", value => "weakpassword" },	2027		{ key => "ROOT_PASSWORD", value => "weakpassword" },
2024	],	2028		],
2025	},	2029		},
2026	{	2030		{
2027	name => "install_kickstart_hdd",	2031		name => "install_kickstart_hdd",
2028	settings => [	2032		settings => [
2029	{ key => "KICKSTART", value => "1" },	2033		{ key => "KICKSTART", value => "1" },
2030	{ key => "GRUB", value => "inst.ks=hd:vdb1:/root-user-crypted-net.ks" },	2034		{ key => "GRUB", value => "inst.ks=hd:vdb1:/root-user-crypted-net.ks" },
▲ Show 20 Lines • Show All 541 Lines • Show Last 20 Lines

View Options

tests/disk_custom_btrfs_postinstall.pm

This file was copied from tests/disk_custom_software_raid_postinstall.pm.

1	use base "installedtest";	1	use base "installedtest";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	assert_screen "root_console";	6	assert_screen "root_console";
7	# check that RAID is used	7	# check that btrfs is used on root partition
8	validate_script_output "cat /proc/mdstat", sub { $_ =~ m/Personalities : \[raid1\]/ };	8	assert_script_run "mount \| grep 'on / type btrfs'";
9	}	9	}
10		10
11	sub test_flags {	11	sub test_flags {
12	return { fatal => 1 };	12	return { fatal => 1 };
13	}	13	}
14		14
15	1;	15	1;
16		16
17	# vim: set sw=4 et:	17	# vim: set sw=4 et:

View Options

tests/disk_custom_ext3_postinstall.pm

This file was copied from tests/disk_custom_software_raid_postinstall.pm.

1	use base "installedtest";	1	use base "installedtest";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	assert_screen "root_console";	6	assert_screen "root_console";
7	# check that RAID is used	7	# check that ext3 is used on root partition
8	validate_script_output "cat /proc/mdstat", sub { $_ =~ m/Personalities : \[raid1\]/ };	8	assert_script_run "mount \| grep 'on / type ext3'";
9	}	9	}
10		10
11	sub test_flags {	11	sub test_flags {
12	return { fatal => 1 };	12	return { fatal => 1 };
13	}	13	}
14		14
15	1;	15	1;
16		16
17	# vim: set sw=4 et:	17	# vim: set sw=4 et:

View Options

tests/disk_custom_lvmthin_postinstall.pm

This file was added.

		1		use base "installedtest";
		2		use strict;
		3		use testapi;
		4
		5		sub run {
		6		assert_screen "root_console";
		7		# check that lvmthinpool is present:
		8		# http://atodorov.org/blog/2015/04/14/how-to-find-if-lvm-volume-is-thinly-provisioned/
		9		# arguments of thinpool devices has T, t or V at the beginning of attributes
		10		assert_script_run "lvs -o lv_attr \| grep -E '^[[:space:]]*(T\|t\|V)'";
		11		}
		12
		13		sub test_flags {
		14		return { fatal => 1 };
		15		}
		16
		17		1;
		18
		19		# vim: set sw=4 et:

View Options

tests/disk_custom_no_swap_postinstall.pm

This file was copied from tests/disk_custom_software_raid_postinstall.pm.

1	use base "installedtest";	1	use base "installedtest";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	assert_screen "root_console";	6	assert_screen "root_console";
7	# check that RAID is used	7	# check that swap is not used, check that "swapon --show has empty input"
8	validate_script_output "cat /proc/mdstat", sub { $_ =~ m/Personalities : \[raid1\]/ };	8	assert_script_run '[[ ! $(swapon --show) ]]';
9	}	9	}
10		10
11	sub test_flags {	11	sub test_flags {
12	return { fatal => 1 };	12	return { fatal => 1 };
13	}	13	}
14		14
15	1;	15	1;
16		16
17	# vim: set sw=4 et:	17	# vim: set sw=4 et:

View Options

tests/disk_custom_software_raid_postinstall.pm

This file was copied to tests/disk_custom_btrfs_postinstall.pm, tests/disk_custom_ext3_postinstall.pm, tests/disk_custom_no_swap_postinstall.pm, tests/disk_custom_xfs_postinstall.pm.

1	use base "installedtest";	1	use base "installedtest";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	assert_screen "root_console";	6	assert_screen "root_console";
7	# check that RAID is used	7	# check that RAID is used
8	validate_script_output "cat /proc/mdstat", sub { $_ =~ m/Personalities : \[raid1\]/ };	8	assert_script_run "cat /proc/mdstat \| grep 'Personalities : \\\[raid1\\\]'";
9	}	9	}
10		10
11	sub test_flags {	11	sub test_flags {
12	return { fatal => 1 };	12	return { fatal => 1 };
13	}	13	}
14		14
15	1;	15	1;
16		16
17	# vim: set sw=4 et:	17	# vim: set sw=4 et:

View Options

tests/disk_custom_xfs_postinstall.pm

This file was copied from tests/disk_custom_software_raid_postinstall.pm.

1	use base "installedtest";	1	use base "installedtest";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	assert_screen "root_console";	6	assert_screen "root_console";
7	# check that RAID is used	7	# check that xfs is used on root partition
8	validate_script_output "cat /proc/mdstat", sub { $_ =~ m/Personalities : \[raid1\]/ };	8	assert_script_run "mount \| grep 'on / type xfs'";
9	}	9	}
10		10
11	sub test_flags {	11	sub test_flags {
12	return { fatal => 1 };	12	return { fatal => 1 };
13	}	13	}
14		14
15	1;	15	1;
16		16
17	# vim: set sw=4 et:	17	# vim: set sw=4 et:

add postinstalls to custom partitioning testsClosedPublicActions

Details

Diff Detail

Revision Contents

Diff 3030

templates

tests/disk_custom_btrfs_postinstall.pm

tests/disk_custom_ext3_postinstall.pm

tests/disk_custom_lvmthin_postinstall.pm

tests/disk_custom_no_swap_postinstall.pm

tests/disk_custom_software_raid_postinstall.pm

tests/disk_custom_xfs_postinstall.pm

add postinstalls to custom partitioning tests
ClosedPublic
Actions