Differential D1182

Don't create user when USER_LOGIN is false, but for KDE install
ClosedPublic
Actions

Authored by adamwill on Mar 29 2017, 12:57 AM.

Details

Reviewers
jsedlak
jskladan
Commits
rOPENQATESTSb6d4fd7d4c3d: Don't create user when USER_LOGIN is false, but for KDE install
Summary

For some reason, we have USER_LOGIN set to 'false' for the KDE
package set install test. I really don't know / remember why
that would be; I'd think we should create a user and log in as
that user to make sure it works properly when installing KDE
from the traditional installer. It's not strictly part of the
package set test, true, but still, seems worth doing.

Also, when USER_LOGIN is set to 'false' and the installer runs,
we create a user called 'false'. This doesn't seem like what we
wanted, so let's not do that. I dunno if there are any other
cases besides the KDE one that this commit changes, but still.

Test Plan

Run the full test suite and look for weirdness, check
KDE package set test works as intended (now creates a user called
'test' and logs in as that user).

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill created this revision.Mar 29 2017, 12:57 AM
jsedlak accepted this revision.Mar 29 2017, 8:01 AM

Why this DR doesn't allow me to run arc patch? Anyway, looks correct.

This revision is now accepted and ready to land.Mar 29 2017, 8:01 AM
Closed by commit rOPENQATESTSb6d4fd7d4c3d: Don't create user when USER_LOGIN is false, but for KDE install (authored by Adam Williamson <awilliam@redhat.com>). · Explain WhyMar 29 2017, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mtemplates (1 line)
Mtests/_do_install_and_reboot.pm (50 lines)

Diff 3005

View Options

templates

Show First 20 Lines • Show All 2093 Lines • ▼ Show 20 Line(s)1630 TestSuites => [
2094 }, 2094​ },
2095 { 2095​ {
2096 name => "install_package_set_kde", 2096​ name => "install_package_set_kde",
2097 settings => [ 2097​ settings => [
2098 { key => "DESKTOP", value => "kde" }, 2098​ { key => "DESKTOP", value => "kde" },
2099 { key => "PACKAGE_SET", value => "kde" }, 2099​ { key => "PACKAGE_SET", value => "kde" },
2100 { key => "POSTINSTALL", value => "_collect_data" }, 2100​ { key => "POSTINSTALL", value => "_collect_data" },
2101 { key => "REPOSITORY_VARIATION", value => "%LOCATION%" }, 2101​ { key => "REPOSITORY_VARIATION", value => "%LOCATION%" },
2102 { key => "USER_LOGIN", value => "false" }, ​
2103 ], 2102​ ],
2104 }, 2103​ },
2105 { 2104​ {
2106 name => "base_selinux", 2105​ name => "base_selinux",
2107 settings => [ 2106​ settings => [
2108 { key => "POSTINSTALL", value => "base_selinux" }, 2107​ { key => "POSTINSTALL", value => "base_selinux" },
2109 { key => "USER_LOGIN", value => "false" }, 2108​ { key => "USER_LOGIN", value => "false" },
2110 { key => "ROOT_PASSWORD", value => "weakpassword" }, 2109​ { key => "ROOT_PASSWORD", value => "weakpassword" },
▲ Show 20 Lines • Show All 276 Lines • Show Last 20 Lines
View Options

tests/_do_install_and_reboot.pm

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Line(s)49 else {
55 type_very_safely $root_password; 55​ type_very_safely $root_password;
56 } 56​ }
57 assert_and_click "anaconda_spoke_done"; 57​ assert_and_click "anaconda_spoke_done";
58 58​
59 # Set user details 59​ # Set user details
60 # wait out animation 60​ # wait out animation
61 sleep 3; 61​ sleep 3;
62 my $user_login = get_var("USER_LOGIN") || "test"; 62​ my $user_login = get_var("USER_LOGIN") || "test";
63​ unless $user_login eq 'false' {
63 assert_and_click "anaconda_install_user_creation"; 64​ assert_and_click "anaconda_install_user_creation";
64 assert_screen "anaconda_install_user_creation_screen"; 65​ assert_screen "anaconda_install_user_creation_screen";
65 # wait out animation 66​ # wait out animation
66 wait_still_screen 2; 67​ wait_still_screen 2;
67 type_very_safely $user_login; 68​ type_very_safely $user_login;
68 type_very_safely "\t\t\t\t"; 69​ type_very_safely "\t\t\t\t";
69 $self->type_user_password(); 70​ $self->type_user_password();
70 wait_screen_change { send_key "tab"; }; 71​ wait_screen_change { send_key "tab"; };
Show All 15 Lines
86 assert_and_click "anaconda_spoke_done"; 87​ assert_and_click "anaconda_spoke_done";
87 # since 20170105, we will get a warning here when the password 88​ # since 20170105, we will get a warning here when the password
88 # contains non-ASCII characters. Assume only switched layouts 89​ # contains non-ASCII characters. Assume only switched layouts
89 # produce non-ASCII characters, though this isn't strictly true 90​ # produce non-ASCII characters, though this isn't strictly true
90 if (get_var('SWITCHED_LAYOUT') && check_screen "anaconda_warning_bar", 3) { 91​ if (get_var('SWITCHED_LAYOUT') && check_screen "anaconda_warning_bar", 3) {
91 wait_still_screen 1; 92​ wait_still_screen 1;
92 assert_and_click "anaconda_spoke_done"; 93​ assert_and_click "anaconda_spoke_done";
93 } 94​ }
95​ }
94 96​
95 # Check username (and hence keyboard layout) if non-English 97​ # Check username (and hence keyboard layout) if non-English
96 if (get_var('LANGUAGE')) { 98​ if (get_var('LANGUAGE')) {
97 assert_screen "anaconda_install_user_created"; 99​ assert_screen "anaconda_install_user_created";
98 } 100​ }
99 101​
100 # With the slow typing - especially with SWITCHED_LAYOUT - we 102​ # With the slow typing - especially with SWITCHED_LAYOUT - we
101 # may not complete user creation until anaconda reaches post-install, 103​ # may not complete user creation until anaconda reaches post-install,
Show All 37 Lines