Differential D118

task-rpmlint: proper usage of check.export_TAP()
ClosedPublic
Actions

Authored by lbrabec on Jun 4 2014, 11:57 AM.

Details

Reviewers
kparal
Commits
Unknown Object (Diffusion Commit)
rRPMLINT29e3cc7fadde: Fix, single TAP header in export
Summary

Export of task-rpmlint had several TAP haders (each for one package). As @kparal suggested, there should be only one header.

Test Plan

python runtask.py -i xchat-2.8.8-21.fc20 -t koji_build -a x86_64 ../task-rpmlint/rpmlint.yml

Diff Detail

Branch
fix-singleTAP
Lint
No Linters Available
Unit
No Unit Test Coverage
lbrabec retitled this revision from to task-rpmlint: proper usage of check.export_TAP().Jun 4 2014, 11:57 AM
lbrabec updated this object.
lbrabec edited the test plan for this revision. (Show Details)
lbrabec added a reviewer: kparal.
lbrabec added a subscriber: kparal.
kparal accepted this revision.Jun 4 2014, 12:11 PM

Yes, this is how it should be generated. Thanks.

This revision is now accepted and ready to land.Jun 4 2014, 12:11 PM
tflink added a comment.Jun 4 2014, 1:36 PM

Yes, this is how it should be generated. Thanks.

Out of curiosity, is that documented somewhere?

kparal added a comment.Jun 4 2014, 2:10 PM
In D118#10, @tflink wrote:

Yes, this is how it should be generated. Thanks.

Out of curiosity, is that documented somewhere?

Good call, I'll fix the docstring. I also filed T205.

kparal added a comment.Jun 4 2014, 2:25 PM

Documentation fixed in 9660b0a.

Revision Contents

Path
Mrun_rpmlint.py (4 lines)

Diff 347

View Options

run_rpmlint.py

Show All 19 Lines10 for rpmfile in rpmfiles:
20 else: 20​ else:
21 result = 'ABORTED' 21​ result = 'ABORTED'
22 22​
23 summary = 'RPMLINT %s for %s' % (result, rpmfile) 23​ summary = 'RPMLINT %s for %s' % (result, rpmfile)
24 detail = check.CheckDetail(rpmfile, check.ReportType.KOJI_BUILD, 24​ detail = check.CheckDetail(rpmfile, check.ReportType.KOJI_BUILD,
25 result, summary, output.split('\n')) 25​ result, summary, output.split('\n'))
26 results.append(detail) 26​ results.append(detail)
27 27​
28 tapdetails = [check.export_TAP(detail) for detail in results] 28​ tapdetails = check.export_TAP(*results)
29 return '\n'.join(tapdetails) 29​ return tapdetails
30 30​
31if __name__ == '__main__': 31​if __name__ == '__main__':
32 tapout = run() 32​ tapout = run()
33 33​
34 for result in tapout: 34​ for result in tapout:
35 print result 35​ print result
36 36​