run per-arch
ClosedPublic
Actions

Authored by kparal on Mar 24 2017, 12:36 PM.

Details

Reviewers

mkrizek
jskladan

Group Reviewers

Restricted Project

Maniphest Tasks

T894: a race condition between downloading i386 and x86_64 packages

Commits

rDEPLINT83bd6af25f93: run per-arch

Summary

Always check just the arch that was requested on the command line,
rather than checking two archs hardcoded in the formula. This makes
running this task more universal, but for checking multiple arches it
will require multiple individual executions. This helps to avoid race
conditions like T894.

Please note this can be only pushed once D1176 is deployed.

Test Plan

ran manually with --arch <arch>, works

Diff Detail

Repository

rDEPLINT task-rpmdeplint

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kparal created this revision.Mar 24 2017, 12:36 PM

Herald added a subscriber: tflink. · View Herald TranscriptMar 24 2017, 12:36 PM

@jskladan @mkrizek: I'd like to push this into develop branch soon, so that I can test how well it works in taskotron-dev. Please review, otherwise I'll do the push early next week. Thanks.

mkrizek accepted this revision.May 22 2017, 8:25 AM

This revision is now accepted and ready to land.May 22 2017, 8:25 AM

This is working well in develop, pushing to master as well.

Closed by commit rDEPLINT83bd6af25f93: run per-arch (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyMay 22 2017, 2:43 PM

This revision was automatically updated to reflect the committed changes.

kparal mentioned this in T894: a race condition between downloading i386 and x86_64 packages.May 22 2017, 2:47 PM

Revision Contents

			Path	Packages
M			runtask.yml (81 lines)
A	M		utils/formula_helper.py (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2998	09f39ed		Mar 24 2017, 12:36 PM	★	★
Diff 2	3052	09f39ed	rDEPLINT83bd6af25f939d3a38057aa23117397c30d88cb0	May 22 2017, 1:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ad2438ec592c	bab19080ace3	09f39ed3d7c9	Kamil Páral	run per-arch (Show More…)	Mar 23 2017, 1:22 PM

Diff 3052

View Options

runtask.yml

1	name: rpmdeplint	1	name: rpmdeplint
2	namespace: dist	2	namespace: dist
3	desc: "Checks for unmet dependencies with the given RPM packages against the given repositories."	3	desc: Checks for unmet dependencies with the given RPM packages against the given repositories.
4	maintainer: mkrizek	4	maintainer: mkrizek
5		5
6	environment:	6	environment:
7	rpm:	7	rpm:
8	- python2-rpmdeplint	8	- python2-rpmdeplint
9		9
10	input:	10	input:
11	args:	11	args:
12	- koji_tag	12	- koji_tag
		13	- arch
13		14
14	actions:	15	actions:
15	# === i386	16	- name: figure out which arches to download (due to multilib)
16	- name: download koji tag
17	koji:
18	action: download_tag
19	koji_tag: ${koji_tag}
20	arch: ['i386']
21	target_dir: "${workdir}/downloaded_tag/"
22
23	- name: mash downloaded rpms
24	mash:
25	rpmdir: "${workdir}/downloaded_tag/"
26	dodelta: "false"
27	arch: ['i386']
28
29	- name: get yum repos
30	yumrepoinfo:
31	koji_tag: ${koji_tag}
32	arch: ['i386']
33	export: yumrepos_i386
34
35	- name: run rpmdeplint
36	python:	17	python:
37	file: run_rpmdeplint.py	18	file: utils/formula_helper.py
38	callable: run	19	callable: determine_koji_arches
39	rpms_dir: "${workdir}/downloaded_tag/"	20	arch: $arch
40	arch: i386	21	export: koji_arches
41	artifactsdir: "${artifactsdir}"
42	report_format: "builds+updates"
43	repos:
44	- ${yumrepos_i386}
45	- "workdir_repo": {"i386": "${workdir}/downloaded_tag/"}
46	export: output_i386
47		22
48	# === x86_64
49	- name: download koji tag	23	- name: download koji tag
50	koji:	24	koji:
51	action: download_tag	25	action: download_tag
52	koji_tag: ${koji_tag}	26	koji_tag: ${koji_tag}
53	arch: ['x86_64']	27	arch: ${koji_arches}
54	target_dir: "${workdir}/downloaded_tag/"	28	target_dir: ${workdir}/downloaded_tag/
55		29
56	- name: mash downloaded rpms	30	- name: mash downloaded rpms
57	mash:	31	mash:
58	rpmdir: "${workdir}/downloaded_tag/"	32	rpmdir: ${workdir}/downloaded_tag/
59	dodelta: "false"	33	arch: ${arch}
60	arch: ['x86_64']
61		34
62	- name: get yum repos	35	- name: get dnf repos
63	yumrepoinfo:	36	yumrepoinfo:
64	koji_tag: ${koji_tag}	37	koji_tag: ${koji_tag}
65	arch: ['x86_64']	38	arch: ${arch}
66	export: yumrepos_x86_64	39	export: dnf_repos
67		40
68	- name: run rpmdeplint	41	- name: run rpmdeplint
69	python:	42	python:
70	file: run_rpmdeplint.py	43	file: run_rpmdeplint.py
71	callable: run	44	callable: run
72	rpms_dir: "${workdir}/downloaded_tag/"	45	rpms_dir: ${workdir}/downloaded_tag/
73	arch: x86_64	46	arch: ${arch}
74	artifactsdir: "${artifactsdir}"	47	artifactsdir: ${artifactsdir}
75	report_format: "builds+updates"	48	report_format: builds+updates
76	repos:	49	repos:
77	- ${yumrepos_x86_64}	50	- ${dnf_repos}
78	- "workdir_repo": {"x86_64": "${workdir}/downloaded_tag/"}	51	- workdir_repo:
79	export: output_x86_64	52	${arch}: ${workdir}/downloaded_tag/
80		53	export: rpmdeplint_output
81	# === report results
82	- name: report i386 results to resultsdb
83	resultsdb:
84	results: ${output_i386}
85	export: output_i386
86		54
87	- name: report x86_64 results to resultsdb	55	- name: report results to resultsdb
88	resultsdb:	56	resultsdb:
89	results: ${output_x86_64}	57	results: ${rpmdeplint_output}
90	export: output_x86_64