change requirements to newest bayeux and yamlish, enable log propagation
ClosedPublic
Actions

Authored by garretraziel on Jun 2 2014, 12:49 PM.

Details

Reviewers

kparal
tflink
jskladan

Maniphest Tasks

T186: Create patches for logging duplication in Bayeux and Yamlish and send them to upstream

Commits

rLTRNb05d034aea6e: change requirements to newest bayeux and yamlish, enable log propagation

Summary

I have sended patches for bayeux and yamlish to upstream and
new versions were released, so if newest versions are installed, log
propagation can be enabled again.

Also, versions in requirements.txt were bumped.

Test Plan

Run py.test -F, try running upgradepath task
and check whether is output displayed twice.

Diff Detail

Repository

rLTRN libtaskotron

Lint

Lint Skipped

Unit

Unit Tests Skipped

garretraziel retitled this revision from to change requirements to newest bayeux and yamlish, enable log propagation.Jun 2 2014, 12:49 PM

garretraziel updated this object.

garretraziel edited the test plan for this revision. (Show Details)

garretraziel added reviewers: tflink, kparal, jskladan.

Herald added a subscriber: tflink. · View Herald TranscriptJun 2 2014, 12:49 PM

garretraziel added a task: T186: Create patches for logging duplication in Bayeux and Yamlish and send them to upstream.Jun 2 2014, 12:50 PM

Nothing I can argue about, really :)

jskladan accepted this revision.Jun 3 2014, 8:20 AM

This revision is now accepted and ready to land.Jun 3 2014, 8:20 AM

Thanks, Jan!

Closed by commit rLTRNb05d034aea6e (authored by Garret Raziel <boloomka@gmail.com>).

Revision Contents

			Path	Packages
M			libtaskotron/runner.py (1 line)
M			requirements.txt (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	343	6fe71ab		Jun 2 2014, 12:49 PM	★	★
Diff 2	346	d4de0b2	Commit rLTRNb05d034aea6e8ace9cbd6003f430cb83ec80d4a7	Jun 4 2014, 7:30 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
26320484046b	0b925e0df872	6fe71ab8c461	Garret Raziel	change requirements to newest bayeux and yamlish, enable log propagation (Show More…)	Jun 2 2014, 12:44 PM

Diff 346

View Options

libtaskotron/runner.py

Show First 20 Lines • Show All 179 Lines • ▼ Show 20 Line(s)		163	def process_args(args):
180	return args	180		return args
181		181
182		182
183	def main():	183		def main():
184	parser = get_argparser()	184		parser = get_argparser()
185	args = parser.parse_args()	185		args = parser.parse_args()
186		186
187	logger.init(level=logging.DEBUG)	187		logger.init(level=logging.DEBUG)
188	logger.log.propagate = False
189		188
190	arg_data = process_args(vars(args))	189		arg_data = process_args(vars(args))
191	arg_data['taskfile'] = args.task[0]	190		arg_data['taskfile'] = args.task[0]
192		191
193	task_data = taskyaml.parse_yaml_from_file(arg_data['taskfile'])	192		task_data = taskyaml.parse_yaml_from_file(arg_data['taskfile'])
194		193
195	if not task_data:	194		if not task_data:
196	raise TaskotronYamlError('Input file should not be empty')	195		raise TaskotronYamlError('Input file should not be empty')
197		196
198	task_runner = Runner(task_data, arg_data)	197		task_runner = Runner(task_data, arg_data)
199	task_runner.run()	198		task_runner.run()
200		199
201	log.info('Check execution finished. Showing stored variables:')	200		log.info('Check execution finished. Showing stored variables:')
202	for name, value in task_runner.working_data.items():	201		for name, value in task_runner.working_data.items():
203	log.info("${%s}:\n%s" % (name, value))	202		log.info("${%s}:\n%s" % (name, value))