Differential D1166

Fix broken tests
ClosedPublic
Actions

Authored by mkrizek on Mar 14 2017, 12:42 PM.

Details

Reviewers
adamwill
Group Reviewers
blockerbugs
Commits
rBLKR3ad275e7dfff: Fix broken tests
Summary

Introduced in D1050, discovered in D1052.

Test Plan

Run the testsuite

Diff Detail

Repository
rBLKR blockerbugs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek created this revision.Mar 14 2017, 12:42 PM
mkrizek edited the summary of this revision. (Show Details)Mar 14 2017, 12:43 PM
adamwill accepted this revision.Mar 25 2017, 1:09 AM

ack, looks fine to me, and I see the same bug.

This revision is now accepted and ready to land.Mar 25 2017, 1:09 AM
Closed by commit rBLKR3ad275e7dfff: Fix broken tests (authored by Martin Krizek <mkrizek@redhat.com>). · Explain WhyMar 27 2017, 9:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 3001

View Options

testing/test_updatesync_extract_information.py

Show All 15 Lines8basicupdate = Bunch(
16 notes=u'Fix live install mounting /home and /boot and swap', 16​ notes=u'Fix live install mounting /home and /boot and swap',
17 request=None, stable_karma=3, status=u'testing', 17​ request=None, stable_karma=3, status=u'testing',
18 submitter=u'bcl', 18​ submitter=u'bcl',
19 title=u'anaconda-18.6.8-1.fc18', 19​ title=u'anaconda-18.6.8-1.fc18',
20 type=u'bugfix', 20​ type=u'bugfix',
21 karma=1, 21​ karma=1,
22 unstable_karma=-3, 22​ unstable_karma=-3,
23 updateid=u'FEDORA-2012-13902', 23​ updateid=u'FEDORA-2012-13902',
24​ url=u'https://bodhi.stg.fedoraproject.org/FEDORA-2012-13902',
24 bugs=[Bunch(bug_id=856836, parent=False, security=False, 25​ bugs=[Bunch(bug_id=856836, parent=False, security=False,
25 title=u'/etc/fstab is not written correctly after live install (F18 Alpha RC2+)')], 26​ title=u'/etc/fstab is not written correctly after live install (F18 Alpha RC2+)')],
26 builds=[Bunch(nvr=u'anaconda-18.6.8-1.fc18', 27​ builds=[Bunch(nvr=u'anaconda-18.6.8-1.fc18',
27 package=Bunch( 28​ package=Bunch(
28 committers=[u'anaconda-maint', u'dlehman', u'jkeating', 29​ committers=[u'anaconda-maint', u'dlehman', u'jkeating',
29 u'bcl', u'clumens', u'rvykydal', u'akozumpl', 30​ u'bcl', u'clumens', u'rvykydal', u'akozumpl',
30 u'pjones', 31​ u'pjones',
31 u'katzj', 32​ u'katzj',
▲ Show 20 Lines • Show All 100 Lines • ▼ Show 20 Line(s)128 def test_extract_karma(self):
132 133​
133 assert updateinfo['karma'] == ref_karma 134​ assert updateinfo['karma'] == ref_karma
134 135​
135 def test_extract_url(self): 136​ def test_extract_url(self):
136 updateinfo = self.testsync.extract_information(self.testupdate) 137​ updateinfo = self.testsync.extract_information(self.testupdate)
137 138​
138 assert (updateinfo['url'] == 'https://bodhi.stg.fedoraproject.org/%s' % self.testupdate.updateid) 139​ assert (updateinfo['url'] == 'https://bodhi.stg.fedoraproject.org/%s' % self.testupdate.updateid)
139 140​
140 def test_extract_url_no_updateid(self): ​
141 ref_title = u'magic-fixall-update-1.1-0' ​
142 self.testupdate.title = ref_title ​
143 self.testupdate.updateid = None ​
144 ​
145 updateinfo = self.testsync.extract_information(self.testupdate) ​
146 ​
147 assert (updateinfo['url'] == 'https://bodhi.stg.fedoraproject.org/%s' % ref_title) ​
148 ​
149 def test_extract_date_pushed_testing_intesting(self): 141​ def test_extract_date_pushed_testing_intesting(self):
150 self.testupdate.status = u'testing' 142​ self.testupdate.status = u'testing'
151 self.testupdate.request = None 143​ self.testupdate.request = None
152 self.testupdate.date_pushed = u'2012-09-13 16:40:28' 144​ self.testupdate.date_pushed = u'2012-09-13 16:40:28'
153 145​
154 updateinfo = self.testsync.extract_information(self.testupdate) 146​ updateinfo = self.testsync.extract_information(self.testupdate)
155 147​
156 assert updateinfo['date_pushed_testing'] == datetime.strptime(self.testupdate.date_pushed, '%Y-%m-%d %H:%M:%S') 148​ assert updateinfo['date_pushed_testing'] == datetime.strptime(self.testupdate.date_pushed, '%Y-%m-%d %H:%M:%S')
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines
View Options

testing/testfunc_update_sync.py

Show All 25 Lines18base_update = Bunch(
26 bugs=[ 26​ bugs=[
27 Bunch(bug_id=2000, parent=False, security=False, 27​ Bunch(bug_id=2000, parent=False, security=False,
28 title=u'bodhi bug 2000 title'), 28​ title=u'bodhi bug 2000 title'),
29 Bunch(bug_id=2001, parent=False, security=False, 29​ Bunch(bug_id=2001, parent=False, security=False,
30 title=u'bodhi bug 2001 title')], 30​ title=u'bodhi bug 2001 title')],
31 release=Bunch(dist_tag=u'f99', id_prefix=u'FEDORA', locked=True, 31​ release=Bunch(dist_tag=u'f99', id_prefix=u'FEDORA', locked=True,
32 long_name=u'Fedora 99', name=u'F99'), 32​ long_name=u'Fedora 99', name=u'F99'),
33 updateid='FEDORA-2012-13902', 33​ updateid='FEDORA-2012-13902',
34​ url=u'https://bodhi.stg.fedoraproject.org/FEDORA-2012-13902',
34) 35​)
35 36​
36update_for_bugs_2000_2001 = copy(base_update) 37​update_for_bugs_2000_2001 = copy(base_update)
37 38​
38update1_for_bug_3000 = copy(base_update) 39​update1_for_bug_3000 = copy(base_update)
39update1_for_bug_3000.update({ 40​update1_for_bug_3000.update({
40 'title': u'libreport-2.1.3-2.fc19', 41​ 'title': u'libreport-2.1.3-2.fc19',
41 'bugs': [Bunch(bug_id=3000, parent=False, security=False, 42​ 'bugs': [Bunch(bug_id=3000, parent=False, security=False,
▲ Show 20 Lines • Show All 154 Lines • Show Last 20 Lines