Differential D1163

testing: improve instructions, enable for Phabricator
ClosedPublic
Actions

Authored by kparal on Mar 8 2017, 1:10 PM.

Details

Reviewers

mkrizek

Group Reviewers

Restricted Project

Commits

rDEPLINT1364169c6449: testing: improve instructions, enable for Phabricator

Summary

Use the same configuration as in our other projects. Require test suite
before submitting to Phab. Rename tests/ to testing/ to make it
consistent with our other projects.

Test Plan

test suite works :)

Diff Detail

Repository

rDEPLINT task-rpmdeplint

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kparal retitled this revision from to testing: improve instructions, enable for Phabricator.Mar 8 2017, 1:10 PM

kparal updated this object.

kparal edited the test plan for this revision. (Show Details)

kparal added reviewers: Restricted Project, mkrizek.

Herald added a subscriber: tflink. · View Herald TranscriptMar 8 2017, 1:10 PM

mkrizek accepted this revision.Mar 8 2017, 1:17 PM

This revision is now accepted and ready to land.Mar 8 2017, 1:17 PM

Closed by commit rDEPLINT1364169c6449: testing: improve instructions, enable for Phabricator (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyMar 8 2017, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

		Path
M		.arcconfig (3 lines)
M		.gitignore (3 lines)
M		README.rst (46 lines)
D	M	pytest.ini (4 lines)
A	M	requirements.txt (10 lines)
V		{testing ← tests/scenarios}/__init__.py
V		{testing ← tests}/conftest.py
V		{testing ← tests}/functest_scenarios.py
V		{testing ← tests}/scenarios/README.md
V		{testing/scenarios ← tests}/__init__.py
V		{testing ← tests}/scenarios/scenarios/fail/01_version.yaml
V		{testing ← tests}/scenarios/scenarios/fail/02_multilib.yaml
V		{testing ← tests}/scenarios/scenarios/fail/03_package_requires.yaml
V		{testing ← tests}/scenarios/scenarios/fail/04_file_requires.yaml
V		{testing ← tests}/scenarios/scenarios/known_broken/05_removing_provides.yaml
V		{testing ← tests}/scenarios/scenarios/known_broken/06_removing_subpackage.yaml
V		{testing ← tests}/scenarios/scenarios/pass/01_simple.yaml
V		{testing ← tests}/scenarios/scenarios/pass/02_conflicts_1.yaml
V		{testing ← tests}/scenarios/scenarios/pass/03_conflicts_2.yaml
V		{testing ← tests}/scenarios/scenarios/pass/04_conflicts_3.yaml
V		{testing ← tests}/scenarios/scenarios/pass/05_strange_conflict.yaml
V		{testing ← tests}/scenarios/scenarios/pass/06_multilib.yaml
V		{testing ← tests}/scenarios/scenarios/pass/07_codependencies.yaml
V		{testing ← tests}/scenarios/scenarios/pass/08_recommends_present.yaml
V		{testing ← tests}/scenarios/scenarios/pass/09_recommends_not_present.yaml
V		{testing ← tests}/scenarios/scenarios/pass/10_suggests_present.yaml
V		{testing ← tests}/scenarios/scenarios/pass/11_suggests_not_present.yaml
V		{testing ← tests}/scenarios/scenarios/pass/12_supplements_present.yaml
V		{testing ← tests}/scenarios/scenarios/pass/13_supplements_not_present.yaml
V		{testing ← tests}/scenarios/yaml_to_repos.py
V		{testing ← tests}/test_squash_results.py
V		{tests → testing/scenarios}/__init__.py
V		{tests → testing}/conftest.py
V		{tests → testing}/functest_scenarios.py
V		{tests → testing}/scenarios/README.md
V		{tests/scenarios → testing}/__init__.py
V		{tests → testing}/scenarios/scenarios/fail/01_version.yaml
V		{tests → testing}/scenarios/scenarios/fail/02_multilib.yaml
V		{tests → testing}/scenarios/scenarios/fail/03_package_requires.yaml
V		{tests → testing}/scenarios/scenarios/fail/04_file_requires.yaml
V		{tests → testing}/scenarios/scenarios/known_broken/05_removing_provides.yaml
V		{tests → testing}/scenarios/scenarios/known_broken/06_removing_subpackage.yaml
V		{tests → testing}/scenarios/scenarios/pass/01_simple.yaml
V		{tests → testing}/scenarios/scenarios/pass/02_conflicts_1.yaml
V		{tests → testing}/scenarios/scenarios/pass/03_conflicts_2.yaml
V		{tests → testing}/scenarios/scenarios/pass/04_conflicts_3.yaml
V		{tests → testing}/scenarios/scenarios/pass/05_strange_conflict.yaml
V		{tests → testing}/scenarios/scenarios/pass/06_multilib.yaml
V		{tests → testing}/scenarios/scenarios/pass/07_codependencies.yaml
V		{tests → testing}/scenarios/scenarios/pass/08_recommends_present.yaml
V		{tests → testing}/scenarios/scenarios/pass/09_recommends_not_present.yaml
V		{tests → testing}/scenarios/scenarios/pass/10_suggests_present.yaml
V		{tests → testing}/scenarios/scenarios/pass/11_suggests_not_present.yaml
V		{tests → testing}/scenarios/scenarios/pass/12_supplements_present.yaml
V		{tests → testing}/scenarios/scenarios/pass/13_supplements_not_present.yaml
V		{tests → testing}/scenarios/yaml_to_repos.py
V		{tests → testing}/test_squash_results.py
A	M	tox.ini (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2958	e6ea697		Mar 8 2017, 1:10 PM	★	★
Diff 2	2961	f1b38ef	rDEPLINT1364169c64493d885dcff6b75d9a6698b948c811	Mar 8 2017, 1:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
49a0d75b72bd	cfb7cb46b0fd	e6ea6978626f	Kamil Páral	testing: improve instructions, enable for Phabricator (Show More…)	Mar 8 2017, 1:03 PM

Diff 2961

View Options

.arcconfig

1	{	1	{
2	"project_id" : "task-rpmdeplint",	2	"project_id" : "task-rpmdeplint",
3	"conduit_uri" : "https://phab.qa.fedoraproject.org",	3	"conduit_uri" : "https://phab.qa.fedoraproject.org",
4	"arc.land.onto.default" : "develop",	4	"arc.land.onto.default" : "develop",
5	"arc.feature.start.default" : "develop"	5	"arc.feature.start.default" : "develop",
		6	"unit.engine" : "PytestTestEngine"
6	}	7	}

View Options

.gitignore

1	*.py[co]	1	*.py[co]
2	.*.swp	2	.*.swp
3	/env/	3	/env*/
4	.cache/	4	.cache/
		5	/.coverage

View Options

README.rst

1	Setting Up Development Environment	1	This a Taskotron_ task to check package dependencies satisfiability in Fedora.
		2	This replaces an older task-depcheck_ project.
		3
		4	.. _Taskotron: https://taskotron.fedoraproject.org
		5	.. _task-depcheck: https://bitbucket.org/fedoraqa/task-depcheck
		6
		7
		8	Setting up development environment
2	----------------------------------	9	----------------------------------
3	::	10	Install libtaskotron::
4		11
5	dnf install python2-rpmdeplint python-virtualenv	12	sudo dnf install libtaskotron libtaskotron-fedora
6	virtualenv --system-site-packages env	13
7	source env/bin/activate	14	Install dependencies::
8	pip install -e /path/to/libtaskotron/checkout
9		15
		16	sudo dnf install python2-rpmdeplint
10		17
11	Running the task through libtaskotron	18	Running the task through libtaskotron
12	-------------------------------------	19	-------------------------------------
13	::	20	::
14		21
15	runtask -i f25-updates-testing-pending -t koji_tag runtask.yml	22	runtask -i f25-updates-testing-pending -t koji_tag runtask.yml
16		23
17	Running Functional Test Suite	24	Running the test suite
18	-----------------------------	25	----------------------
19	::	26	Install dependepcies::
		27
		28	sudo dnf install python-virtualenv python2-rpmfluff yum
		29
		30	Create virtualenv::
		31
		32	virtualenv --system-site-packages env_rpmdeplint
		33	source env_rpmdeplint/bin/activate
		34	pip install -r requirements.txt
		35
		36	If you don't have libtaskotron installed in the system, but use it from a
		37	checkout, you also need to install it and its deps into the virtualenv::
		38
		39	pip install -e /path/to/libtaskotron/checkout
		40	pip install -r /path/to/libtaskotron/checkout/requirements.txt
		41
		42	Run the test suite::
20		43
21	pip install pytest dingus progressbar	44	py.test
22	py.test --functional tests/
23		45
24	Read ``tests/scenarios/README.md`` for more details.	46	Read ``tests/scenarios/README.md`` for more details about writing the tests.

View Options

pytest.ini

This file was deleted.

This file was completely deleted. Show File Contents

View Options

requirements.txt

This file was added.

		1		# This is a list of pypi packages to be installed into virtualenv. Alternatively,
		2		# you can install these as RPMs instead of pypi packages.
		3
		4		rpmdeplint
		5
		6		# Test suite requirements
		7		dingus
		8		pytest
		9		pytest-cov
		10		PyYAML