Differential D1160

changing testcase field to 1024
ClosedPublic
Actions

Authored by tflink on Mar 7 2017, 9:47 PM.

Details

Reviewers
mkrizek
jskladan
Maniphest Tasks
T924: execdb does not support taskname longer than 20 char
Commits
rEXECDB4ea31edea1c4: changing testcase field to 1024. Fixes T924
Summary

upgrading testcase field from 20 char to text

Test Plan

run migration locally with postgres, running in stg

Diff Detail

Repository
rEXECDB execdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to changing testcase field to 1024.Mar 7 2017, 9:47 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added reviewers: jskladan, mkrizek.
mkrizek accepted this revision.Mar 8 2017, 11:52 AM
This revision is now accepted and ready to land.Mar 8 2017, 11:52 AM
jskladan accepted this revision.Mar 8 2017, 1:59 PM

D1150 will need adjustments, but that's a non issue.

Closed by commit rEXECDB4ea31edea1c4: changing testcase field to 1024. Fixes T924 (authored by tflink). · Explain WhyMar 9 2017, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2965

View Options

alembic/versions/6fc76719cc5f_making_testcase_field_text.py

  • This file was added.
1​"""making testcase field text
2​
3​Revision ID: 6fc76719cc5f
4​Revises: 3b51d15f0f87
5​Create Date: 2017-03-02 21:15:27.846336
6​
7​"""
8​
9​# revision identifiers, used by Alembic.
10​revision = '6fc76719cc5f'
11​down_revision = '3b51d15f0f87'
12​branch_labels = None
13​depends_on = None
14​
15​from alembic import op
16​import sqlalchemy as sa
17​
18​
19​def upgrade():
20​ op.alter_column('job', 'taskname', existing_type=sa.String(20), type_=sa.Text())
21​
22​
23​def downgrade():
24​ op.alter_column('job', 'taskname', existing_type=sa.Text, type_=sa.String(20))
View Options

execdb/models/job.py

Show All 27 Lines26class Job(db.Model):
28 uuid = db.Column(db.String(36), unique=True) 28​ uuid = db.Column(db.String(36), unique=True)
29 29​
30 t_triggered = db.Column(db.DateTime, default=datetime.datetime.utcnow) 30​ t_triggered = db.Column(db.DateTime, default=datetime.datetime.utcnow)
31 t_build_started = db.Column(db.DateTime) 31​ t_build_started = db.Column(db.DateTime)
32 t_build_ended = db.Column(db.DateTime) 32​ t_build_ended = db.Column(db.DateTime)
33 33​
34 fedmsg_data = db.Column(db.Text) 34​ fedmsg_data = db.Column(db.Text)
35 35​
36 taskname = db.Column(db.String(20)) 36​ taskname = db.Column(db.Text)
37 item = db.Column(db.Text) 37​ item = db.Column(db.Text)
38 item_type = db.Column(db.String(20)) 38​ item_type = db.Column(db.String(20))
39 arch = db.Column(db.String(10)) 39​ arch = db.Column(db.String(10))
40 40​
41 slavename = db.Column(db.String(20)) 41​ slavename = db.Column(db.String(20))
42 # slave_env_details = db.Column(db.Text) # ??? 42​ # slave_env_details = db.Column(db.Text) # ???
43 43​
44 # task_git_hash = db.Column(db.String(40)) # ??? 44​ # task_git_hash = db.Column(db.String(40)) # ???
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines