Make the deployment type part of fedmsg topic configurable
ClosedPublic

Authored by mkrizek on Feb 28 2017, 9:23 AM.

Details

Summary

So we can easily listen on stg fedmsgs in dev/stg.

Test Plan

Run fedmsg-hub, worked for me.

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Make the deployment type part of fedmsg topic configurable.Feb 28 2017, 9:23 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: taskotron-trigger.
kparal accepted this revision.Feb 28 2017, 11:16 AM
kparal added a reviewer: kparal.
kparal added a subscriber: kparal.
kparal added inline comments.
conf/trigger.cfg.example
16

Please add a comment explaining the available values, or saying how to determine them (link to fedmsg docs for example).

This revision is now accepted and ready to land.Feb 28 2017, 11:16 AM
This revision was automatically updated to reflect the committed changes.
tflink added a comment.Mar 2 2017, 5:02 PM

the code works well for me and looks good. the only issue that I ran into while testing is that there's no mention in the docs of how to hook up to the stg fedmsg bus. it's a simple config change but AFAIK, not all the stg messages are on the prod bus