URL Fix
Details
Details
Diff Detail
Diff Detail
- Repository
- rDEPCK task-depcheck
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Differential D1142
Authored by • sumantrom on Feb 21 2017, 10:20 PM.
Revision Contents
Revision Contents
| Path | Packages | |||
|---|---|---|---|---|
| M | depcheck/depcheck.py (2 lines) | |||
| M | tests/test_squash_results.py (2 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 544095368968 | 2eddaea29a6f | de7ecb7d1f6d | sumantro93 | URL Fix (Show More…) | Feb 21 2017, 10:19 PM |
Diff 2915
Diff 2915
depcheck/depcheck.py
| Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Line(s) | 114 | for rule in probrules: | |||
|---|---|---|---|---|---|
| 115 | ruleinfos = rule.allinfos() | 115 | ruleinfos = rule.allinfos() | ||
| 116 | for info in ruleinfos: | 116 | for info in ruleinfos: | ||
| 117 | problem_str = info.problemstr() | 117 | problem_str = info.problemstr() | ||
| 118 | problem_strs.append(problem_str) | 118 | problem_strs.append(problem_str) | ||
| 119 | if 'inferior architecture' in problem_str: | 119 | if 'inferior architecture' in problem_str: | ||
| 120 | result = Aborted | 120 | result = Aborted | ||
| 121 | warning_string = """**** PLEASE NOTE ****: This \ | 121 | warning_string = """**** PLEASE NOTE ****: This \ | ||
| 122 | failure is likely invalid, caused by a bug we haven't been able to reproduce reliably or fix yet: \ | 122 | failure is likely invalid, caused by a bug we haven't been able to reproduce reliably or fix yet: \ | ||
| 123 | https://phab.qadevel.cloud.fedoraproject.org/T366 . Please test your package \ | 123 | https://phab.qa.fedoraproject.org/T366 . Please test your package \ | ||
| 124 | dependencies manually and if everything looks correct, ignore this error. We \ | 124 | dependencies manually and if everything looks correct, ignore this error. We \ | ||
| 125 | apologize for the inconvenience and are working to get it fixed as soon as possible.""" | 125 | apologize for the inconvenience and are working to get it fixed as soon as possible.""" | ||
| 126 | problem_strs.append(warning_string) | 126 | problem_strs.append(warning_string) | ||
| 127 | return {'result':result, 'details':problem_strs} | 127 | return {'result':result, 'details':problem_strs} | ||
| 128 | 128 | | |||
| 129 | 129 | | |||
| 130 | def check_rpm_deps(self, rpmfiles): | 130 | def check_rpm_deps(self, rpmfiles): | ||
| 131 | """Check dependencies of the given rpms against supplied repodata | 131 | """Check dependencies of the given rpms against supplied repodata | ||
| Show All 37 Lines | |||||
tests/test_squash_results.py
| Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Line(s) | 107 | def test__squash_builds_to_updates_incomplete_update(self): | |||
|---|---|---|---|---|---|
| 136 | assert detail.outcome == 'ABORTED' | 136 | assert detail.outcome == 'ABORTED' | ||
| 137 | assert any('Update was incomplete' in line for line in detail.output) | 137 | assert any('Update was incomplete' in line for line in detail.output) | ||
| 138 | 138 | | |||
| 139 | def test__squash_builds_to_updates_incomplete_update_missing_first(self): | 139 | def test__squash_builds_to_updates_incomplete_update_missing_first(self): | ||
| 140 | """ | 140 | """ | ||
| 141 | Checks whether __squash_builds_to_updates provides correct output | 141 | Checks whether __squash_builds_to_updates provides correct output | ||
| 142 | when some update is incomplete (i.e. present in the second return-value | 142 | when some update is incomplete (i.e. present in the second return-value | ||
| 143 | from the build2update method) and the missing build is the first one | 143 | from the build2update method) and the missing build is the first one | ||
| 144 | to process (https://phab.qadevel.cloud.fedoraproject.org/T476). | 144 | to process (https://phab.qa.fedoraproject.org/T476). | ||
| 145 | """ | 145 | """ | ||
| 146 | run_results = { | 146 | run_results = { | ||
| 147 | 'nvr1': {'result': Pass, 'details': []}, | 147 | 'nvr1': {'result': Pass, 'details': []}, | ||
| 148 | 'nvr2': {'result': Pass, 'details': []}, | 148 | 'nvr2': {'result': Pass, 'details': []}, | ||
| 149 | } | 149 | } | ||
| 150 | update = {'alias': 'update_name', | 150 | update = {'alias': 'update_name', | ||
| 151 | 'builds': [{'nvr': k} for k in run_results.keys()], | 151 | 'builds': [{'nvr': k} for k in run_results.keys()], | ||
| 152 | 'release': {'name': 'F20'}, | 152 | 'release': {'name': 'F20'}, | ||
| ▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines | |||||