Differential D1139

URL fix
AbandonedPublic
Actions

Authored by kparal on Feb 21 2017, 9:24 PM.

Details

Reviewers
• sumantrom
Group Reviewers
Restricted Project
Commits
rDEPLINTe6ea6978626f: fix outdated link
Summary

URL fix

Test Plan

NA

Diff Detail

Branch
feature/fixurl (branched from develop)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1063
Build 1063: arc lint + arc unit
• sumantrom retitled this revision from to URL fix.Feb 21 2017, 9:24 PM
• sumantrom updated this object.
• sumantrom edited the test plan for this revision. (Show Details)
• sumantrom added a reviewer: Restricted Project.
kparal accepted this revision.Feb 22 2017, 6:04 AM
kparal added a reviewer: kparal.
kparal added a subscriber: kparal.

Thanks, pushed.

This revision is now accepted and ready to land.Feb 22 2017, 6:04 AM
kparal commandeered this revision.Feb 22 2017, 8:29 AM
kparal edited reviewers, added: • sumantrom; removed: kparal.

Pushed in e6ea6978626.

This revision now requires review to proceed.Feb 22 2017, 8:29 AM
kparal abandoned this revision.Feb 22 2017, 8:30 AM

Arrgh, I can't simply close the diff, because Phabricator. Abandoning, but pushed.

Revision Contents

Diff 2908

View Options

tests/test_squash_results.py

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Line(s)107 def test__squash_builds_to_updates_incomplete_update(self):
136 assert detail.outcome == 'ABORTED' 136​ assert detail.outcome == 'ABORTED'
137 assert any('Update was incomplete' in line for line in detail.output) 137​ assert any('Update was incomplete' in line for line in detail.output)
138 138​
139 def test__squash_builds_to_updates_incomplete_update_missing_first(self): 139​ def test__squash_builds_to_updates_incomplete_update_missing_first(self):
140 """ 140​ """
141 Checks whether __squash_builds_to_updates provides correct output 141​ Checks whether __squash_builds_to_updates provides correct output
142 when some update is incomplete (i.e. present in the second return-value 142​ when some update is incomplete (i.e. present in the second return-value
143 from the build2update method) and the missing build is the first one 143​ from the build2update method) and the missing build is the first one
144 to process (https://phab.qadevel.cloud.fedoraproject.org/T476). 144​ to process (https://phab.qa.fedoraproject.org/T476).
145 """ 145​ """
146 run_results = { 146​ run_results = {
147 'nvr1': {'result': PASS, 'details': []}, 147​ 'nvr1': {'result': PASS, 'details': []},
148 'nvr2': {'result': PASS, 'details': []}, 148​ 'nvr2': {'result': PASS, 'details': []},
149 } 149​ }
150 update = {'alias': 'update_name', 150​ update = {'alias': 'update_name',
151 'builds': [{'nvr': k} for k in run_results.keys()], 151​ 'builds': [{'nvr': k} for k in run_results.keys()],
152 'release': {'name': 'F20'}, 152​ 'release': {'name': 'F20'},
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines