Changed URL for migration
AbandonedPublic

Authored by a2batic on Feb 13 2017, 1:55 PM.

Details

Reviewers
jskladan
Group Reviewers
resultsdb
Summary

Migration URL change

Test Plan

NA

Diff Detail

Branch
feature/fixurl (branched from develop)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1051
Build 1051: arc lint + arc unit
a2batic retitled this revision from to Changed URL for migration.Feb 13 2017, 1:55 PM
a2batic updated this object.
a2batic edited the test plan for this revision. (Show Details)
a2batic added a reviewer: resultsdb.
jskladan accepted this revision.Feb 13 2017, 2:28 PM

Good catch, thanks.

This revision is now accepted and ready to land.Feb 13 2017, 2:28 PM
kparal added a subscriber: kparal.EditedFeb 14 2017, 7:18 AM

I wonder how this diff was created that it doesn't show for which Repository it is intended. D1129 shows that. Hmm.

Also, application of the patch fails:

$ arc patch D1130
Created and checked out branch arcpatch-D1130.


    This diff is against commit 960a7cad6c79438b20c6255e4450c4152e1863c0, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (44a5b44554f273149b56ace3691722a943884e5b)
    [Y/n] 

Checking patch setup.py...
error: while searching for:
        description = 'Library for simplifying the communication with ResultsDB',
        author = 'Josef Skladanka',
        author_email = 'jskladan@redhat.com',
        url = "https://bitbucket.org/fedoraqa/resultsdb",
        install_requires = ['requests', 'simplejson'],
        classifiers = [
            "Development Status :: 2 - Pre-Alpha",

error: patch failed: setup.py:25
Applying patch setup.py with 1 reject...
Rejected hunk #1.

 Patch Failed! 
Usage Exception: Unable to apply patch!

But I have no idea why :/

It seems you have not based this commit on develop, but on some other commit that is not present in the upstream repository. You should always do something like this:

git checkout develop
git pull
git checkout -b feature/myfix
# do your changes
git commit
arc diff develop

If you inspect the git repository using tig or tig --all, you should see feature/myfix branch as directly branching from develop (usually just a single commit). Also, never work as root (you commit is authored by "root"). Set up your name and your email address using:

$ git config --global user.name "John Doe"
$ git config --global user.email johndoe@example.com

Since you want to learn, please try again? :)

After debugging issues with @sumantrom today, I assume this will be a similar problem. Please make sure you have cloned the correct repository, which is this one:
https://pagure.io/taskotron/resultsdb_api

Don't use bitbucket repos (we'll obsolete it soon), and don't make your private forks. Just clone the upstream repo (using https protocol). Then I believe all the issues should be gone.

Oh ok, noted :). Thanks @kparal

a2batic abandoned this revision.Feb 14 2017, 1:44 PM

This have been replaced by D1132

(@a2batic: You can simply write D1132 next time, it will link automatically).

oh ok, Thanks @kparal :)