Hi, thanks for the diff! Since this is your first diff, let me guide you a bit. (I also commit updated instructions which should help you, be sure to pull latest code and read Setting Up a Dev Environment section until the config file adjustments - that and further steps are not needed).

First, you should always create a separate branch for your diffs, based on latest develop:

git checkout develop
git pull
git checkout -b feature/fixurl
# do your work
git commit
arc diff develop

Second, unit tests have to pass. I assume they don't pass for you because you have executed arc diff develop outside of virtualenv. Look into README, there are instructions how to set up virtualenv and activate it. Once you have it active, just running py.test should execute the test suite and everything should pass. If something doesn't, ping me on IRC and we'll look at it. Once it works, arc diff develop should also not complain.

Third, when creating a diff, set #project-name as reviewers, e.g.:

Reviewers: #taskotron-trigger

Try to either create a new diff or update this one, according to the instructions :) Thanks.

I've put a generic version of the virtualenv instructions into https://fedoraproject.org/wiki/Taskotron_contribution_guide , along with a note to read the README for the specific project you're contributing to for more detailed instructions.

Obsoleted by D1131.