remove simplejson dep, improve virtualenv and makefile
ClosedPublic

Authored by kparal on Feb 6 2017, 3:37 PM.

Details

Summary

We don't seem to import simplejson, the spec file doesn't require it, and
it's also a dep of resultsdb_api. Don't use --system-site-packages in
Makefile, the whole project can be installed from PyPI without
compilation. Make Makefile targets phony, they are not actual files.

Test Plan

tried running it, worked

Diff Detail

Repository
rRSFE resultsdb_frontend
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to requirements: remove simplejson.Feb 6 2017, 3:37 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: resultsdb.
kparal updated this revision to Diff 2847.Feb 6 2017, 3:59 PM

forgot updating Makefile. Make targets phony, they are not actual files. Don't use --system-site-packages, it's not needed in this project.

jskladan requested changes to this revision.Feb 7 2017, 8:20 AM
jskladan added a reviewer: jskladan.
jskladan added a subscriber: jskladan.

Looks like a wrong version of the diff is uploaded, based on the comment. I'm fine with the changes overall, just make sure this is what you really wanted. (Consider this not a NACK but NEEDS_INSPECTION :) )

Makefile
93–94

I guess the --system-site-packages should not be present, based on your comment. Wrong diff uploaded, perhaps?

This revision now requires changes to proceed.Feb 7 2017, 8:20 AM
kparal updated this revision to Diff 2850.Feb 7 2017, 8:34 AM

actually remove --system-site-packages from Makefile

kparal retitled this revision from requirements: remove simplejson to remove simplejson dep, improve virtualenv and makefile.Feb 7 2017, 8:35 AM
kparal updated this object.

It should make more sense now, description updated, and Makefile fixed :)

jskladan accepted this revision.Feb 7 2017, 9:16 AM
This revision is now accepted and ready to land.Feb 7 2017, 9:16 AM
Closed by commit rRSFE0e2eab3c5158: remove simplejson dep, improve virtualenv and makefile (authored by Kamil Páral <kparal@redhat.com>). · Explain WhyFeb 7 2017, 9:59 AM
This revision was automatically updated to reflect the committed changes.