We don't seem to import simplejson, the spec file doesn't require it, and
it's also a dep of resultsdb_api. Don't use --system-site-packages in
Makefile, the whole project can be installed from PyPI without
compilation. Make Makefile targets phony, they are not actual files.
Details
Details
- Reviewers
jskladan - Group Reviewers
resultsdb - Commits
- rRSFE0e2eab3c5158: remove simplejson dep, improve virtualenv and makefile
tried running it, worked
Diff Detail
Diff Detail
- Repository
- rRSFE resultsdb_frontend
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
forgot updating Makefile. Make targets phony, they are not actual files. Don't use --system-site-packages, it's not needed in this project.
Comment Actions
Looks like a wrong version of the diff is uploaded, based on the comment. I'm fine with the changes overall, just make sure this is what you really wanted. (Consider this not a NACK but NEEDS_INSPECTION :) )
Makefile | ||
---|---|---|
93–94 | I guess the --system-site-packages should not be present, based on your comment. Wrong diff uploaded, perhaps? |
I guess the --system-site-packages should not be present, based on your comment. Wrong diff uploaded, perhaps?