Fixes T48
This also includes "Fix opening taskyaml file"
Details
Details
- Reviewers
tflink - Maniphest Tasks
- T48: createrepo directive
- Commits
- rLTRNcbeecada350f: Add createrepo directive
rLTRNaa9f84fac94e: Add createrepo directive
Tested on my dev machine
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I'd like to see some logging messages coming out of the createrepo directive. An INFO on 'running createrepo on {{ repodir }}" and a DEBUG with output from the subprocess.
Comment Actions
Requested change after looking at a pull request fixing the file open issue
libtaskotron/taskyaml.py | ||
---|---|---|
5 ↗ | (On Diff #26) | Can you back this change out? Ralph submitted a pull request with a similar change and while the difference is minimal, I prefer the solution he proposed: https://bitbucket.org/fedoraqa/libtaskotron/pull-request/1/simplify-things-with-a-context-manager |
Comment Actions
Looks good to me. We still need to figure out how to generate documentation but that's out of scope for this review