Differential D11

Add createrepo directive
ClosedPublic
Actions

Authored by mkrizek on Feb 20 2014, 4:03 PM.

Details

Reviewers
tflink
Maniphest Tasks
T48: createrepo directive
Commits
rLTRNcbeecada350f: Add createrepo directive
rLTRNaa9f84fac94e: Add createrepo directive
Summary

Fixes T48
This also includes "Fix opening taskyaml file"

Test Plan

Tested on my dev machine

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tflink requested changes to this revision.Feb 24 2014, 3:23 PM

I'd like to see some logging messages coming out of the createrepo directive. An INFO on 'running createrepo on {{ repodir }}" and a DEBUG with output from the subprocess.

tflink added a comment.Feb 24 2014, 3:28 PM

Requested change after looking at a pull request fixing the file open issue

libtaskotron/taskyaml.py
5 ↗(On Diff #26)

Can you back this change out? Ralph submitted a pull request with a similar change and while the difference is minimal, I prefer the solution he proposed:

https://bitbucket.org/fedoraqa/libtaskotron/pull-request/1/simplify-things-with-a-context-manager

mkrizek updated this revision.Feb 25 2014, 12:01 PM

Add logging messages

tflink accepted this revision.Feb 25 2014, 6:07 PM

Looks good to me. We still need to figure out how to generate documentation but that's out of scope for this review

mkrizek closed this revision.Feb 26 2014, 1:50 PM

Closed by commit rLTRNcbeecada350f (authored by @mkrizek).

Revision Contents

Diff 37

View Options

libtaskotron/directives/createrepo_directive.py

  • This file was added.
1​import subprocess as sub
2​from libtaskotron.directives import BaseDirective
3​
4​directive_class = 'CreaterepoDirective'
5​
6​# TODO handle exceptions properly (T85)
7​
8​class CreaterepoDirective(BaseDirective):
9​ def process(self, input_data, env_data):
10​ """For the createrepo directive, we're expecting a yaml declaration of the form
11​ "createrepo: repodir=/path/to/some/dir"
12​ """
13​
14​ repodir = input_data['repodir']
15​
16​ p = sub.Popen(['createrepo', repodir], stdout=sub.PIPE, stderr=sub.PIPE)
17​
18​ output, errors = p.communicate()
19​
20​ if p.returncode:
21​ raise Exception(errors)
22​
23​ return output