Differential D1089

Fix Testcase Info Links
ClosedPublic
Actions

Authored by mprahl on Jan 18 2017, 8:28 PM.

Details

Reviewers
tflink
jskladan
Commits
rRSFE0cec8a789555: Fix Testcase Info Links
Summary

The testcase info links were still using the old APIv1 value of url when it should actually be ref_url

Test Plan

N/A

Diff Detail

Repository
rRSFE resultsdb_frontend
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mprahl retitled this revision from to Fix Testcase Info Links.Jan 18 2017, 8:28 PM
mprahl updated this object.
mprahl edited the test plan for this revision. (Show Details)
mprahl added reviewers: tflink, jskladan.
mprahl added a subscriber: ralph.
tflink accepted this revision.Jan 18 2017, 8:57 PM
This revision is now accepted and ready to land.Jan 18 2017, 8:57 PM
jskladan accepted this revision.Jan 19 2017, 8:10 AM

Good catch, thanks!

mprahl added a comment.Jan 20 2017, 1:39 PM

@jskladan any chance you can merge this since I don't have rights? :)

jskladan added a comment.Jan 20 2017, 2:46 PM

oh, sure, I forgot. sorry @mprahl

Closed by commit rRSFE0cec8a789555: Fix Testcase Info Links (authored by mprahl <mprahl@redhat.com>, committed by Josef Skladanka <jskladan@redhat.com>). · Explain WhyJan 20 2017, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2779

View Options

resultsdb_frontend/templates/testcases.html

1{% extends "layout.html" %} 1​{% extends "layout.html" %}
2 2​
3{% block body %} 3​{% block body %}
4<table class="table table-striped table-bordered"> 4​<table class="table table-striped table-bordered">
5 <thead> 5​ <thead>
6 <tr> 6​ <tr>
7 <th>Name</th> 7​ <th>Name</th>
8 <th>Results</th> 8​ <th>Results</th>
9 <th>Info</th> 9​ <th>Info</th>
10 </tr> 10​ </tr>
11 </thead> 11​ </thead>
12 <tbody> 12​ <tbody>
13 {% for testcase in testcases.data %} 13​ {% for testcase in testcases.data %}
14 <tr> 14​ <tr>
15 <td>{{ testcase.name }}</td> 15​ <td>{{ testcase.name }}</td>
16 <td><a href="{{ url_for('main.results', testcases = testcase.name) }}">Results</a></td> 16​ <td><a href="{{ url_for('main.results', testcases = testcase.name) }}">Results</a></td>
17 <td><a href="{{ testcase.url }}">Link &rarr;</a></td> 17​ <td><a href="{{ testcase.ref_url }}">Link &rarr;</a></td>
18 </tr> 18​ </tr>
19 {% endfor %} 19​ {% endfor %}
20 </tbody> 20​ </tbody>
21</table> 21​</table>
22 22​
23 23​
24<ul class="pager"> 24​<ul class="pager">
25 {% if testcases.prev %} 25​ {% if testcases.prev %}
Show All 9 Lines