Differential D1088

Expose and enable dist-git trigger.
AbandonedPublic
Actions

Authored by ralph on Jan 18 2017, 5:06 PM.

Details

Reviewers
kparal
tflink
mkrizek
jskladan
Summary

This advertises the entry-point and enables it by default.

Test Plan

No test plan.

Diff Detail

Repository
rTRGR taskotron-trigger
Branch
expose-dist-git-trigger (branched from develop)
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 968
Build 968: arc lint + arc unit

Unit TestsBroken
View All

Excuse: Bad local environment.
TimeTest
0 ms.testing.functest_cli
testing/functest_cli.py:1: in <module> from dingus import Dingus E ImportError: No module named dingus
0 ms.testing.test_compose_trigger
testing/test_compose_trigger.py:2: in <module> from dingus import Dingus E ImportError: No module named dingus
0 ms.testing.test_dist_git_trigger
testing/test_dist_git_trigger.py:2: in <module> import mock E ImportError: No module named mock
0 ms.testing.test_jobtrigger
testing/test_jobtrigger.py:2: in <module> import mock E ImportError: No module named mock
0 ms.testing.test_koji_build_trigger
testing/test_koji_build_trigger.py:3: in <module> import mock E ImportError: No module named mock
View Full Test Results (7 Broken · 2 Passed)
ralph retitled this revision from to Expose and enable dist-git trigger..Jan 18 2017, 5:06 PM
ralph updated this object.
ralph edited the test plan for this revision. (Show Details)
ralph added reviewers: mkrizek, tflink, kparal, jskladan.
mkrizek accepted this revision.Jan 18 2017, 5:08 PM
This revision is now accepted and ready to land.Jan 18 2017, 5:08 PM
ralph abandoned this revision.Jan 18 2017, 5:09 PM

Let's close this in favor of D1088 which includes a fix.

Revision Contents

PathCoverage (All)Coverage (Touched)Packages
Mfedmsg.d/taskotron-trigger.py (1 line)--
Msetup.py (1 line)0%-

Diff 2768

View Options

fedmsg.d/taskotron-trigger.py

1config = { 1​config = {
2 'taskotron.kojitagchangedjobtrigger.enabled': True, 2​ 'taskotron.kojitagchangedjobtrigger.enabled': True,
3 'taskotron.kojibuildcompletedjobtrigger.enabled': True, 3​ 'taskotron.kojibuildcompletedjobtrigger.enabled': True,
4 'taskotron.composecompletedjobtrigger.enabled': True, 4​ 'taskotron.composecompletedjobtrigger.enabled': True,
5​ 'taskotron.distgitcommitjobtrigger.enabled': True,
5} 6​}
View Options

setup.py

Show All 21 Lines15setup(
22 url='https://fedorahosted.org/fedora-qa', 22​ url='https://fedorahosted.org/fedora-qa',
23 packages=['jobtriggers'], 23​ packages=['jobtriggers'],
24 entry_points={ 24​ entry_points={
25 'console_scripts': ['jobrunner=jobtriggers.jobrunner:main'], 25​ 'console_scripts': ['jobrunner=jobtriggers.jobrunner:main'],
26 'moksha.consumer': ( 26​ 'moksha.consumer': (
27 'kojibuildcompletedjobtrigger = jobtriggers.koji_build_msg:KojiBuildCompletedJobTrigger', 27​ 'kojibuildcompletedjobtrigger = jobtriggers.koji_build_msg:KojiBuildCompletedJobTrigger',
28 'kojitagchangedjobtrigger = jobtriggers.koji_tag_msg:KojiTagChangedJobTrigger', 28​ 'kojitagchangedjobtrigger = jobtriggers.koji_tag_msg:KojiTagChangedJobTrigger',
29 'composecompletedjobtrigger = jobtriggers.compose_complete_msg:ComposeCompletedJobTrigger', 29​ 'composecompletedjobtrigger = jobtriggers.compose_complete_msg:ComposeCompletedJobTrigger',
30​ 'distgitcommitjobtrigger = jobtriggers.dist_git_commit_msg:DistGitCommitJobTrigger',
30 ), 31​ ),
31 }, 32​ },
32 include_package_data=True, 33​ include_package_data=True,
33 install_requires=[ 34​ install_requires=[
34 'fedmsg', 35​ 'fedmsg',
35 'requests', 36​ 'requests',
36 ], 37​ ],
37 cmdclass={'test': PyTest} 38​ cmdclass={'test': PyTest}
38) 39​)