Differential D1073

Fix functional tests in the test suite.
ClosedPublic
Actions

Authored by ralph on Dec 17 2016, 2:14 PM.

Details

Reviewers
• ralph2
tflink
mkrizek
jskladan
Maniphest Tasks
T874: ResultsDB functional tests are broken
Commits
rRSDBa1867dd78b8b: Fix functional tests in the test suite.
Summary

The issue is that the messaging plugins are defined as setuptools
entry-points, and those live in the .egg-info directory. If you're developing
locally, that directory is usually present in pwd due to `python setup.py
develop` or python setup.py egg-info. But in the spec file, we install to a
directory that is not in the PYTHONPATH. This change re-enables the -F
option but also specifies the PYTHONPATH so that the entry-points are found and
the tests pass.

This should fix T874.

Test Plan

Try building the rpm in mock. It works!

Diff Detail

Repository
rRSDB resultsdb
Branch
fix-tests (branched from develop)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 945
Build 945: arc lint + arc unit
• ralph2 retitled this revision from to Fix functional tests in the test suite..Dec 17 2016, 2:14 PM
• ralph2 updated this object.
• ralph2 edited the test plan for this revision. (Show Details)
• ralph2 added reviewers: mkrizek, jskladan, tflink.
• ralph2 added a task: T874: ResultsDB functional tests are broken.
jskladan added a comment.Dec 17 2016, 3:16 PM

Did not try to build the RPM, so I'm not acking - just a question though - is there a reasonable way to make this work (for development) without running python setup.py develop or python setup.py egg-info? If not, could you please also change the README to reflect this? Thanks!

mkrizek accepted this revision.Jan 2 2017, 11:46 AM

Works for me.

This revision is now accepted and ready to land.Jan 2 2017, 11:46 AM
ralph added a subscriber: ralph.Jan 6 2017, 6:48 PM

Well, I ran arc land, and it is up on origin develop branch now.. but this differential is still open for some reason.

ralph commandeered this revision.Jan 6 2017, 6:48 PM
ralph closed this revision.
ralph added a reviewer: • ralph2.

Revision Contents

PathPackages
Mresultsdb.spec (3 lines)

Diff 2731

View Options

resultsdb.spec

Show All 28 Lines
29 29​
30%description 30​%description
31ResultsDB is a results store engine for, but not limited to, Fedora QA tools. 31​ResultsDB is a results store engine for, but not limited to, Fedora QA tools.
32 32​
33%prep 33​%prep
34%setup -q 34​%setup -q
35 35​
36%check 36​%check
37# TODO remember to re-enable functional tests when they're fixed 37​PYTHONPATH=%{buildroot}%{python2_sitelib}/ py.test -F testing/
38py.test testing ​
39# Remove compiled .py files after running unittests 38​# Remove compiled .py files after running unittests
40rm -f %{buildroot}%{_sysconfdir}/resultsdb/*.py{c,o} 39​rm -f %{buildroot}%{_sysconfdir}/resultsdb/*.py{c,o}
41find %{buildroot}%{_datadir}/resultsdb/alembic -name '*.py[c,o]' -delete 40​find %{buildroot}%{_datadir}/resultsdb/alembic -name '*.py[c,o]' -delete
42 41​
43%build 42​%build
44%{__python2} setup.py build 43​%{__python2} setup.py build
45 44​
46%install 45​%install
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines