Differential D1071

Have non-English tests do graphical install and login
ClosedPublic
Actions

Authored by adamwill on Dec 16 2016, 12:33 AM.

Details

Reviewers
garretraziel
jskladan
Maniphest Tasks
T842: Non-English install tests should install Workstation package set and test graphical login
Commits
rOPENQATESTS0fa613844824: Have non-English tests do graphical install and login
Summary

The non-English tests so far did not test that graphical login
worked as expected, which is a fairly large hole. With this
change, they should do a Workstation install and test login to
both GNOME and the console works as expected. KDE is not yet
tested.

As part of this we tweak the implementation of keyboard layout
switching in graphical environments to use a generic function
in main_common which can handle both anaconda and desktops
(just GNOME at present, but should extend easily to any desktop
with a known switcher key and a visible layout indicator),
replacing the anacondatest class method. I kinda don't like that
the test has to specifically tell the function when it's in
anaconda, but I don't think I want to start experimenting with
a global 'test phase' openQA variable or anything like that at
present.

Fixes T842.

Test Plan

Run the French and Russian install tests and check
they work as expected. Also run an English Workstation install
if you like, and make sure that didn't break. This change is
live on staging ATM, seems to work fine.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to Have non-English tests do graphical install and login.Dec 16 2016, 12:33 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
adamwill added a task: T842: Non-English install tests should install Workstation package set and test graphical login.
garretraziel accepted this revision.Dec 16 2016, 11:20 AM
This revision is now accepted and ready to land.Dec 16 2016, 11:20 AM
Closed by commit rOPENQATESTS0fa613844824: Have non-English tests do graphical install and login (authored by adamwill). · Explain WhyDec 16 2016, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlib/anacondatest.pm (10 lines)
Mlib/main_common.pm (19 lines)
AMneedles/anaconda/package_selection/workstation_highlighted.json (14 lines)
AM(bin)needles/anaconda/package_selection/workstation_highlighted.png
AMneedles/anaconda/package_selection/workstation_selected.json (14 lines)
AM(bin)needles/anaconda/package_selection/workstation_selected.png
AMneedles/gnome/french/desktop_clean_french-20161215.json (24 lines)
AM(bin)needles/gnome/french/desktop_clean_french-20161215.png
AMneedles/gnome/french/getting_started_french-20161215.json (16 lines)
AM(bin)needles/gnome/french/getting_started_french-20161215.png
AMneedles/gnome/french/login_gdm_input_french-20161215.json (17 lines)
AM(bin)needles/gnome/french/login_gdm_input_french-20161215.png
AMneedles/gnome/french/next_button_french-20161215.json (16 lines)
AM(bin)needles/gnome/french/next_button_french-20161215.png
AMneedles/gnome/french/skip_button_french-20161215.json (16 lines)
AM(bin)needles/gnome/french/skip_button_french-20161215.png
Pneedles/gnome/getting_started-20160901.json (5 lines)
Copied to needles/gnome/russian/getting_started_russian-20161215.json
Mneedles/gnome/getting_started.json (5 lines)
AMneedles/gnome/layout_us-20161215.json (15 lines)
AM(bin)needles/gnome/layout_us-20161215.png
AMneedles/gnome/layout_us-gdm-20161215.json (14 lines)
AM(bin)needles/gnome/layout_us-gdm-20161215.png
Mneedles/gnome/login_gdm.json (5 lines)
Mneedles/gnome/next_button-20160823.json (5 lines)
Mneedles/gnome/next_button-20160824.json (5 lines)
Mneedles/gnome/next_button.json (5 lines)
AMneedles/gnome/russian/desktop_clean_russian-20161215.json (25 lines)
AM(bin)needles/gnome/russian/desktop_clean_russian-20161215.png
Pneedles/gnome/russian/getting_started_russian-20161215.json (13 lines)
Copied from needles/gnome/getting_started-20160901.json
AM(bin)needles/gnome/russian/getting_started_russian-20161215.png
AMneedles/gnome/russian/layout_native_russian-20161215.json (15 lines)
AM(bin)needles/gnome/russian/layout_native_russian-20161215.png
AMneedles/gnome/russian/layout_native_russian-gdm-20161215.json (15 lines)
AM(bin)needles/gnome/russian/layout_native_russian-gdm-20161215.png
AMneedles/gnome/russian/login_gdm_input_russian-20161215.json (17 lines)
AM(bin)needles/gnome/russian/login_gdm_input_russian-20161215.png
AMneedles/gnome/russian/next_button_russian-20161215.json (16 lines)
AM(bin)needles/gnome/russian/next_button_russian-20161215.png
AMneedles/gnome/russian/skip_button_russian-20161215.json (16 lines)
AM(bin)needles/gnome/russian/skip_button_russian-20161215.png
Mneedles/gnome/skip_button.json (5 lines)
Mtemplates (8 lines)
AMtests/_console_login.pm (29 lines)
Mtests/_do_install_and_reboot.pm (6 lines)
Mtests/_graphical_wait_login.pm (19 lines)
Mtests/disk_guided_encrypted.pm (4 lines)

Diff 2729

View Options

lib/anacondatest.pm

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Line(s)
175 175​
176sub custom_delete_part { 176​sub custom_delete_part {
177 my ($self, $part) = @_; 177​ my ($self, $part) = @_;
178 return if not $part; 178​ return if not $part;
179 assert_and_click "anaconda_part_select_$part"; 179​ assert_and_click "anaconda_part_select_$part";
180 assert_and_click "anaconda_part_delete"; 180​ assert_and_click "anaconda_part_delete";
181} 181​}
182 182​
183sub switch_layout { ​
184 # switch to 'native' or 'us' keyboard layout ​
185 my ($self, $layout) = @_; ​
186 $layout //= 'us'; ​
187 # if already selected, we're good ​
188 return if (check_screen "anaconda_layout_$layout", 3); ​
189 send_key "alt-shift"; ​
190 assert_screen "anaconda_layout_$layout", 3; ​
191} ​
192 ​
193sub get_full_repo { 183​sub get_full_repo {
194 my ($self, $repourl) = @_; 184​ my ($self, $repourl) = @_;
195 # trivial thing we kept repeating: fill out an HTTP or HTTPS 185​ # trivial thing we kept repeating: fill out an HTTP or HTTPS
196 # repo URL with flavor and arch, leave NFS ones alone (as for 186​ # repo URL with flavor and arch, leave NFS ones alone (as for
197 # NFS tests we just use a mounted ISO and the URL is complete) 187​ # NFS tests we just use a mounted ISO and the URL is complete)
198 if ($repourl !~ m/^nfs/) { 188​ if ($repourl !~ m/^nfs/) {
199 $repourl .= "/Everything/".get_var("ARCH")."/os"; 189​ $repourl .= "/Everything/".get_var("ARCH")."/os";
200 } 190​ }
Show All 10 Lines
View Options

lib/main_common.pm

1package main_common; 1​package main_common;
2 2​
3use strict; 3​use strict;
4 4​
5use base 'Exporter'; 5​use base 'Exporter';
6use Exporter; 6​use Exporter;
7 7​
8use testapi; 8​use testapi;
9our @EXPORT = qw/run_with_error_check type_safely type_very_safely desktop_vt boot_to_login_screen console_login console_switch_layout console_loadkeys_us/; 9​our @EXPORT = qw/run_with_error_check type_safely type_very_safely desktop_vt boot_to_login_screen console_login console_switch_layout desktop_switch_layout console_loadkeys_us/;
10 10​
11sub run_with_error_check { 11​sub run_with_error_check {
12 my ($func, $error_screen) = @_; 12​ my ($func, $error_screen) = @_;
13 die "Error screen appeared" if (check_screen $error_screen, 5); 13​ die "Error screen appeared" if (check_screen $error_screen, 5);
14 $func->(); 14​ $func->();
15 die "Error screen appeared" if (check_screen $error_screen, 5); 15​ die "Error screen appeared" if (check_screen $error_screen, 5);
16} 16​}
17 17​
▲ Show 20 Lines • Show All 52 Lines • ▼ Show 20 Line(s)
70# Switch keyboard layouts at a console 70​# Switch keyboard layouts at a console
71sub console_switch_layout { 71​sub console_switch_layout {
72 # switcher key combo differs between layouts, for console 72​ # switcher key combo differs between layouts, for console
73 if (get_var("LANGUAGE", "") eq "russian") { 73​ if (get_var("LANGUAGE", "") eq "russian") {
74 send_key "ctrl-shift"; 74​ send_key "ctrl-shift";
75 } 75​ }
76} 76​}
77 77​
78​# switch to 'native' or 'us' keyboard layout in a graphical desktop
79​# 'environment' can be a desktop name or 'anaconda' for anaconda
80​# if not set, will use get_var('DESKTOP') or default 'anaconda'
81​sub desktop_switch_layout {
82​ my ($layout, $environment) = @_;
83​ $layout //= 'us';
84​ $environment //= get_var("DESKTOP", "anaconda");
85​ # if already selected, we're good
86​ return if (check_screen "${environment}_layout_${layout}", 3);
87​ # otherwise we need to switch
88​ my $switcher = "alt-shift"; # anaconda
89​ $switcher = "super-spc" if $environment eq 'gnome';
90​ # KDE? not used yet
91​ send_key $switcher;
92​ assert_screen "${environment}_layout_${layout}", 3;
93​}
94​
78# this subroutine handles logging in as a root/specified user into console 95​# this subroutine handles logging in as a root/specified user into console
79# it requires TTY to be already displayed (handled by the root_console() 96​# it requires TTY to be already displayed (handled by the root_console()
80# method of distribution classes) 97​# method of distribution classes)
81sub console_login { 98​sub console_login {
82 my %args = ( 99​ my %args = (
83 user => "root", 100​ user => "root",
84 password => get_var("ROOT_PASSWORD", "weakpassword"), 101​ password => get_var("ROOT_PASSWORD", "weakpassword"),
85 @_); 102​ @_);
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines
View Options

needles/anaconda/package_selection/workstation_highlighted.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 13,
5​ "type": "match",
6​ "width": 125,
7​ "xpos": 48,
8​ "ypos": 254
9​ }
10​ ],
11​ "tags": [
12​ "anaconda_workstation_highlighted"
13​ ]
14​}
View Options

needles/anaconda/package_selection/workstation_highlighted.png

  • This binary file was added.
View Options

needles/anaconda/package_selection/workstation_selected.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 13,
5​ "type": "match",
6​ "width": 145,
7​ "xpos": 28,
8​ "ypos": 254
9​ }
10​ ],
11​ "tags": [
12​ "anaconda_workstation_selected"
13​ ]
14​}
15​No newline at end of file
View Options

needles/anaconda/package_selection/workstation_selected.png

  • This binary file was added.
View Options

needles/gnome/french/desktop_clean_french-20161215.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "type": "match",
5​ "ypos": 6,
6​ "width": 62,
7​ "xpos": 10,
8​ "height": 15
9​ },
10​ {
11​ "ypos": 4,
12​ "width": 43,
13​ "type": "match",
14​ "xpos": 968,
15​ "height": 18
16​ }
17​ ],
18​ "tags": [
19​ "DESKTOP-gnome",
20​ "LANGUAGE-french",
21​ "graphical_desktop_clean"
22​ ],
23​ "properties": []
24​}
25​No newline at end of file
View Options

needles/gnome/french/desktop_clean_french-20161215.png

  • This binary file was added.
View Options

needles/gnome/french/getting_started_french-20161215.json

  • This file was added.
1​{
2​ "tags": [
3​ "LANGUAGE-french",
4​ "getting_started"
5​ ],
6​ "properties": [],
7​ "area": [
8​ {
9​ "xpos": 467,
10​ "ypos": 36,
11​ "width": 88,
12​ "height": 16,
13​ "type": "match"
14​ }
15​ ]
16​}
17​No newline at end of file
View Options

needles/gnome/french/getting_started_french-20161215.png

  • This binary file was added.
View Options

needles/gnome/french/login_gdm_input_french-20161215.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 343,
5​ "ypos": 375,
6​ "width": 338,
7​ "height": 58,
8​ "type": "match"
9​ }
10​ ],
11​ "tags": [
12​ "DESKTOP-gnome",
13​ "LANGUAGE-french",
14​ "graphical_login_input"
15​ ],
16​ "properties": []
17​}
18​No newline at end of file
View Options

needles/gnome/french/login_gdm_input_french-20161215.png

  • This binary file was added.
View Options

needles/gnome/french/next_button_french-20161215.json

  • This file was added.
1​{
2​ "properties": [],
3​ "tags": [
4​ "LANGUAGE-french",
5​ "next_button"
6​ ],
7​ "area": [
8​ {
9​ "xpos": 955,
10​ "ypos": 43,
11​ "width": 47,
12​ "height": 14,
13​ "type": "match"
14​ }
15​ ]
16​}
17​No newline at end of file
View Options

needles/gnome/french/next_button_french-20161215.png

  • This binary file was added.
View Options

needles/gnome/french/skip_button_french-20161215.json

  • This file was added.
1​{
2​ "tags": [
3​ "LANGUAGE-french",
4​ "skip_button"
5​ ],
6​ "properties": [],
7​ "area": [
8​ {
9​ "xpos": 960,
10​ "ypos": 43,
11​ "width": 43,
12​ "height": 14,
13​ "type": "match"
14​ }
15​ ]
16​}
17​No newline at end of file
View Options

needles/gnome/french/skip_button_french-20161215.png

  • This binary file was added.
View Options

needles/gnome/getting_started-20160901.json

  • This file was copied to needles/gnome/russian/getting_started_russian-20161215.json.
1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 17, 4​ "height": 17,
5 "type": "match", 5​ "type": "match",
6 "ypos": 34, 6​ "ypos": 34,
7 "width": 115, 7​ "width": 115,
8 "xpos": 454 8​ "xpos": 454
9 } 9​ }
10 ], 10​ ],
11 "properties": [], 11​ "properties": [],
12 "tags": [ 12​ "tags": [
13 "getting_started" 13​ "getting_started",
14​ "LANGUAGE-english"
14 ] 15​ ]
15} 16​}
16No newline at end of file ​
View Options

needles/gnome/getting_started.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 454, 4​ "xpos": 454,
5 "ypos": 34, 5​ "ypos": 34,
6 "width": 115, 6​ "width": 115,
7 "height": 17, 7​ "height": 17,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "properties": [], 11​ "properties": [],
12 "tags": [ 12​ "tags": [
13 "getting_started" 13​ "getting_started",
14​ "LANGUAGE-english"
14 ] 15​ ]
15} 16​}
16No newline at end of file ​
View Options

needles/gnome/layout_us-20161215.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 13,
5​ "width": 33,
6​ "ypos": 7,
7​ "type": "match",
8​ "xpos": 854
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "gnome_layout_us"
14​ ]
15​}
16​No newline at end of file
View Options

needles/gnome/layout_us-20161215.png

  • This binary file was added.
View Options

needles/gnome/layout_us-gdm-20161215.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 13,
5​ "type": "match",
6​ "width": 33,
7​ "xpos": 853,
8​ "ypos": 7
9​ }
10​ ],
11​ "tags": [
12​ "gnome_layout_us"
13​ ]
14​}
View Options

needles/gnome/layout_us-gdm-20161215.png

  • This binary file was added.
View Options

needles/gnome/login_gdm.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "graphical_login", 3​ "graphical_login",
4 "login_screen", 4​ "login_screen",
5 "DESKTOP-gnome", 5​ "DESKTOP-gnome"
6 "ENV-DISTRI-fedora", ​
7 "LANGUAGE-english", ​
8 "ENV-FLAVOR-develop" ​
9 ], 6​ ],
10 "properties": [], 7​ "properties": [],
11 "area": [ 8​ "area": [
12 { 9​ {
13 "width": 206, 10​ "width": 206,
14 "type": "match", 11​ "type": "match",
15 "xpos": 405, 12​ "xpos": 405,
16 "height": 106, 13​ "height": 106,
17 "ypos": 645 14​ "ypos": 645
18 } 15​ }
19 ] 16​ ]
20} 17​}
View Options

needles/gnome/next_button-20160823.json

Loading...
View Options

needles/gnome/next_button-20160824.json

Loading...
View Options

needles/gnome/next_button.json

Loading...
View Options

needles/gnome/russian/desktop_clean_russian-20161215.json

Loading...
View Options

needles/gnome/russian/desktop_clean_russian-20161215.png

Loading...
View Options

needles/gnome/russian/getting_started_russian-20161215.json

Loading...
View Options

needles/gnome/russian/getting_started_russian-20161215.png

Loading...
View Options

needles/gnome/russian/layout_native_russian-20161215.json

Loading...
View Options

needles/gnome/russian/layout_native_russian-20161215.png

Loading...
View Options

needles/gnome/russian/layout_native_russian-gdm-20161215.json

Loading...
View Options

needles/gnome/russian/layout_native_russian-gdm-20161215.png

Loading...
View Options

needles/gnome/russian/login_gdm_input_russian-20161215.json

Loading...
View Options

needles/gnome/russian/login_gdm_input_russian-20161215.png

Loading...
View Options

needles/gnome/russian/next_button_russian-20161215.json

Loading...
View Options

needles/gnome/russian/next_button_russian-20161215.png

Loading...
View Options

needles/gnome/russian/skip_button_russian-20161215.json

Loading...
View Options

needles/gnome/russian/skip_button_russian-20161215.png

Loading...
View Options

needles/gnome/skip_button.json

Loading...
View Options

templates

Loading...
View Options

tests/_console_login.pm

Loading...
View Options

tests/_do_install_and_reboot.pm

Loading...
View Options

tests/_graphical_wait_login.pm

Loading...
View Options

tests/disk_guided_encrypted.pm

Loading...