Differential D1070

iSCSI: test user authentication
ClosedPublic
Actions

Authored by adamwill on Dec 14 2016, 10:57 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS7135a4e05d94: iSCSI: test user authentication
Summary

This isn't in the criteria, but it's commonly used, so we ought
to test this way. Require authentication for the iSCSI target
and have the test provide the appropriate auth info.

Test Plan

Run the iscsi test and check it works (you need the
recent fixes for support_server to make *that* work). Nothing
else should be affected.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to iSCSI: test user authentication.Dec 14 2016, 10:57 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
garretraziel accepted this revision.Dec 20 2016, 7:49 AM
This revision is now accepted and ready to land.Dec 20 2016, 7:49 AM
Closed by commit rOPENQATESTS7135a4e05d94: iSCSI: test user authentication (authored by adamwill). · Explain WhyDec 20 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2732

View Options

lib/anacondatest.pm

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s)97 else {
105 } 105​ }
106 # For exactly 1 disk, we don't need to do anything. 106​ # For exactly 1 disk, we don't need to do anything.
107 } 107​ }
108 108​
109 # Handle network disks. 109​ # Handle network disks.
110 if (%iscsi) { 110​ if (%iscsi) {
111 assert_and_click "anaconda_install_destination_add_network_disk"; 111​ assert_and_click "anaconda_install_destination_add_network_disk";
112 foreach my $target (keys %iscsi) { 112​ foreach my $target (keys %iscsi) {
113 my $ip = $iscsi{$target}; 113​ my $ip = $iscsi{$target}->[0];
114​ my $user = $iscsi{$target}->[1];
115​ my $password = $iscsi{$target}->[2];
114 assert_and_click "anaconda_install_destination_add_iscsi_target"; 116​ assert_and_click "anaconda_install_destination_add_iscsi_target";
115 wait_still_screen 2; 117​ wait_still_screen 2;
116 type_safely $ip; 118​ type_safely $ip;
117 wait_screen_change { send_key "tab"; }; 119​ wait_screen_change { send_key "tab"; };
118 type_safely $target; 120​ type_safely $target;
119 # start discovery - three tabs, enter 121​ # start discovery - three tabs, enter
120 type_safely "\t\t\t\n"; 122​ type_safely "\t\t\t\n";
123​ if ($user && $password) {
124​ assert_and_click "anaconda_install_destination_target_auth_type";
125​ assert_and_click "anaconda_install_destination_target_auth_type_chap";
126​ send_key "tab";
127​ type_safely $user;
128​ send_key "tab";
129​ type_safely $password;
130​ }
121 assert_and_click "anaconda_install_destination_target_login"; 131​ assert_and_click "anaconda_install_destination_target_login";
122 assert_and_click "anaconda_install_destination_select_target"; 132​ assert_and_click "anaconda_install_destination_select_target";
123 } 133​ }
124 assert_and_click "anaconda_spoke_done"; 134​ assert_and_click "anaconda_spoke_done";
125 } 135​ }
126 136​
127 # If this is a custom partitioning test, select custom partitioning. 137​ # If this is a custom partitioning test, select custom partitioning.
128 if (get_var('PARTITIONING') =~ /^custom_/) { 138​ if (get_var('PARTITIONING') =~ /^custom_/) {
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines
View Options

needles/anaconda/install_destination/target_auth_type-20161214.json

  • This file was added.
1​{
2​ "tags": [
3​ "anaconda_install_destination_target_auth_type"
4​ ],
5​ "properties": [],
6​ "area": [
7​ {
8​ "xpos": 426,
9​ "ypos": 313,
10​ "width": 88,
11​ "height": 17,
12​ "type": "match"
13​ }
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda/install_destination/target_auth_type-20161214.png

  • This binary file was added.
View Options

needles/anaconda/install_destination/target_auth_type_chap-20161214.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 425,
5​ "ypos": 343,
6​ "width": 83,
7​ "height": 20,
8​ "type": "match"
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_install_destination_target_auth_type_chap"
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda/install_destination/target_auth_type_chap-20161214.png

  • This binary file was added.
View Options

tests/_support_server.pm

Show All 21 Lines7sub run {
22 assert_script_run "firewall-cmd --add-service=dns"; 22​ assert_script_run "firewall-cmd --add-service=dns";
23 # start server 23​ # start server
24 assert_script_run "systemctl restart dnsmasq.service"; 24​ assert_script_run "systemctl restart dnsmasq.service";
25 assert_script_run "systemctl is-active dnsmasq.service"; 25​ assert_script_run "systemctl is-active dnsmasq.service";
26 26​
27 ## ISCSI 27​ ## ISCSI
28 28​
29 # start up iscsi target 29​ # start up iscsi target
30 assert_script_run "printf '<target iqn.2016-06.local.domain:support.target1>\n backing-store /dev/vdb\n</target>' > /etc/tgt/conf.d/openqa.conf"; 30​ assert_script_run "printf '<target iqn.2016-06.local.domain:support.target1>\n backing-store /dev/vdb\n incominguser test weakpassword\n</target>' > /etc/tgt/conf.d/openqa.conf";
31 # open firewall port 31​ # open firewall port
32 assert_script_run "firewall-cmd --add-service=iscsi-target"; 32​ assert_script_run "firewall-cmd --add-service=iscsi-target";
33 assert_script_run "systemctl restart tgtd.service"; 33​ assert_script_run "systemctl restart tgtd.service";
34 assert_script_run "systemctl is-active tgtd.service"; 34​ assert_script_run "systemctl is-active tgtd.service";
35 35​
36 ## NFS 36​ ## NFS
37 37​
38 # create the file share 38​ # create the file share
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines
View Options

tests/disk_custom_iscsi.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self = shift; 6​ my $self = shift;
7 # iscsi config hash 7​ # iscsi config hash
8 my %iscsi; 8​ my %iscsi;
9 $iscsi{'iqn.2016-06.local.domain:support.target1'} = '10.0.2.110'; 9​ $iscsi{'iqn.2016-06.local.domain:support.target1'} = ['10.0.2.110', 'test', 'weakpassword'];
10 # Anaconda hub 10​ # Anaconda hub
11 # Go to INSTALLATION DESTINATION and ensure one regular disk 11​ # Go to INSTALLATION DESTINATION and ensure one regular disk
12 # and the iscsi target are selected. 12​ # and the iscsi target are selected.
13 $self->select_disks(iscsi=>\%iscsi); 13​ $self->select_disks(iscsi=>\%iscsi);
14 assert_and_click "anaconda_spoke_done"; 14​ assert_and_click "anaconda_spoke_done";
15 # now we're at custom part. let's use standard partitioning for 15​ # now we're at custom part. let's use standard partitioning for
16 # simplicity 16​ # simplicity
17 $self->custom_scheme_select("standard"); 17​ $self->custom_scheme_select("standard");
Show All 19 Lines