Support testing the semi-official live-respins, more fedfind
ClosedPublic

Authored by adamwill on Dec 8 2016, 1:36 AM.

Details

Summary

The point of this change is to support testing the 'respin'
composes that are built by volunteers and live in live-respins
in the alt tree on the mirrors. These are considered to be
'semi-official', and the maintainers asked if we could test
them. This depends on the latest fedfind git master ATM (I'll
cut a release soon).

To make this possible we kinda have to go back to using fedfind
more. I was hoping when I initially dumped the use of fedfind
that fedfind might actually go away soon, but for a bunch of
awful reasons that make me want to drink, this seems very
unlikely. These live-respins composes aren't built with Pungi 4
and don't have metadata, so we kinda have to go through fedfind
to understand them.

I think the changes to use fedfind actually make the scheduler
code a bit nicer, though. Especially it lets us use a less
stupidly-nested 'WANTED' structure (now a list not a dict).

I have tried this out on staging (that's why there were a bunch
of needle commits to the tests), and it works. The stupid fedmsg
consumer hack is untested as yet (but should be tested quite
soon). I'm not married to that, if you hate it we can just drop
it and set up a cron job or something instead.

Test Plan

Try testing the current live-respins compose, see
if it works. Check I didn't break anything else.

Diff Detail

Repository
rOPENQA fedora_openqa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to Support testing the semi-official live-respins, more fedfind.Dec 8 2016, 1:36 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 2712.Dec 8 2016, 7:10 AM

Drop the consumer stuff

On second thoughts I hate the consumer stuff. It's silly. We can
just run a cron job once an hour.

adamwill updated this revision to Diff 2713.Dec 8 2016, 7:10 AM

update commit msg

Aside from sidenotes, code looks good and much easier than before. I haven't run it yet though.

scheduler/fedora_openqa_schedule/schedule.py
71

Leftover debugging print?

133

Looks like version isn't used anywhere.

adamwill updated this revision to Diff 2714.Dec 8 2016, 4:55 PM

Fix the issues @garretraziel noted in review

Thanks for those catches, you're right on both! Fixed.

Of course this code is only 'easier' because I'm stuck with all the complex stuff in fedfind, hah...

scheduler/fedora_openqa_schedule/schedule.py
71

Ooops, indeed!

133

oh whoops, it's meant to replace the VERSION value. I'm kinda uncomfortable with relying on splitting that out of the 'build' (compose ID), it seems safer to pass it explicitly.

adamwill updated this revision to Diff 2719.Dec 9 2016, 6:36 PM

Fix WANTED Workstation i386

Had live twice, no boot.

It works on normal compose, but I do not know location of live-respins, can you please provide some?

There's exactly one location for it, ever:

https://dl.fedoraproject.org/pub/alt/live-respins/

you should be able to feed it that location at any point and it will assign a release and date and create jobs with an appropriate BUILD. If you feed it the same location again it'll refuse to duplicate them (unless you use --force). If you feed it the same location later, when its contents have changed, it (well, fedfind) will know it's a different compose now, and create jobs for a new BUILD.

garretraziel accepted this revision.Dec 14 2016, 9:23 AM

I don't want to know how changes in fedfind look like, but this looks good :-).

This revision is now accepted and ready to land.Dec 14 2016, 9:23 AM
This revision was automatically updated to reflect the committed changes.