reintroduce rescue on UEFI
ClosedPublic
Actions

Authored by garretraziel on Nov 25 2016, 1:41 PM.

Details

Reviewers

adamwill
jskladan

Maniphest Tasks

T858: UEFI rescue mode test doesn't work: doesn't boot from optical drive or handle bootloader properly

Commits

rOPENQATESTS44cf1cd89c68: reintroduce rescue on UEFI

Summary

So this again, now it goes along with os-autoinst pull request
(https://github.com/os-autoinst/os-autoinst/pull/641). I tested it and
it should work, but you need to wait until new os-autoinst version with
my patch will be released. Also, it would be great if anyone other besides
me tested their OVMF behaviour: https://github.com/os-autoinst/os-autoinst/issues/640.

Test Plan

run install_rescue_encrypted on UEFI.

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

garretraziel retitled this revision from to reintroduce rescue on UEFI.Nov 25 2016, 1:41 PM

garretraziel updated this object.

garretraziel edited the test plan for this revision. (Show Details)

garretraziel added reviewers: adamwill, jskladan.

Herald added a subscriber: tflink. · View Herald TranscriptNov 25 2016, 1:41 PM

garretraziel added a task: T858: UEFI rescue mode test doesn't work: doesn't boot from optical drive or handle bootloader properly.Nov 25 2016, 2:06 PM

I've applied this change to staging (where a new enough os-autoinst is deployed), we can see if it runs on the next Rawhide test. The test is still failing at present, but the failure is late enough that if the test runs and hits the failure we can consider the change good, I think. Thanks for this! The edk2 installed on stg is edk2-ovmf-20161105git3b25ca8-1.fc25.noarch .

This seems to run fine (fails, as expected, but all the setup is fine) on staging, so +1. Please don't land until I update os-autoinst on prod, though.

This revision is now accepted and ready to land.Dec 8 2016, 12:14 AM

I've updated the prod deployment now, so it should be fine to land this.

Closed by commit rOPENQATESTS44cf1cd89c68: reintroduce rescue on UEFI (authored by garretraziel). · Explain WhyDec 13 2016, 8:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			templates (12 lines)
M			tests/rescue_mode_encrypted.pm (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2699	571cf3c		Nov 25 2016, 1:41 PM	★	★
Diff 2	2724	fbe5f0f	rOPENQATESTS44cf1cd89c6852bf4d8126a25db9e571c1bee3c1	Dec 13 2016, 8:18 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
fae4071a7daf	82194126659d	571cf3c035f3	Jan Sedlák	reintroduce rescue on UEFI (Show More…)	Nov 23 2016, 10:34 AM

Diff 2724

View Options

templates

Show First 20 Lines • Show All 441 Lines • ▼ Show 20 Line(s)		441	product => {
442	arch => "x86_64",	442		arch => "x86_64",
443	distri => "fedora",	443		distri => "fedora",
444	flavor => "universal",	444		flavor => "universal",
445	version => "*",	445		version => "*",
446	},	446		},
447	test_suite => { name => "install_rescue_encrypted" },	447		test_suite => { name => "install_rescue_encrypted" },
448	},	448		},
449	{	449		{
		450		machine => { name => "uefi" },
		451		prio => 32,
		452		product => {
		453		arch => "x86_64",
		454		distri => "fedora",
		455		flavor => "universal",
		456		version => "*",
		457		},
		458		test_suite => { name => "install_rescue_encrypted" },
		459		},
		460		{
450	machine => { name => "64bit" },	461		machine => { name => "64bit" },
451	prio => 10,	462		prio => 10,
452	product => {	463		product => {
453	arch => "x86_64",	464		arch => "x86_64",
454	distri => "fedora",	465		distri => "fedora",
455	flavor => "Server-dvd-iso",	466		flavor => "Server-dvd-iso",
456	version => "*",	467		version => "*",
457	},	468		},
▲ Show 20 Lines • Show All 1123 Lines • ▼ Show 20 Line(s)		1591	{
1581	name => "install_anaconda_text",	1592		name => "install_anaconda_text",
1582	settings => [	1593		settings => [
1583	{ key => "ANACONDA_TEXT", value => "1" },	1594		{ key => "ANACONDA_TEXT", value => "1" },
1584	],	1595		],
1585	},	1596		},
1586	{	1597		{
1587	name => "install_rescue_encrypted",	1598		name => "install_rescue_encrypted",
1588	settings => [	1599		settings => [
		1600		{ key => "BOOTFROM", value => "d" },
1589	{ key => "ENTRYPOINT", value => "rescue_mode_encrypted" },	1601		{ key => "ENTRYPOINT", value => "rescue_mode_encrypted" },
1590	{ key => "HDD_1", value => "disk_%MACHINE%_encrypted.qcow2" },	1602		{ key => "HDD_1", value => "disk_%MACHINE%_encrypted.qcow2" },
1591	{ key => "START_AFTER_TEST", value => "install_simple_encrypted" },	1603		{ key => "START_AFTER_TEST", value => "install_simple_encrypted" },
1592	],	1604		],
1593	},	1605		},
1594	{	1606		{
1595	name => "install_package_set_minimal",	1607		name => "install_package_set_minimal",
1596	settings => [	1608		settings => [
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines