As was discovered in T124, used libraries don't config their
own loggers, so when is taskotron run with runtask, every log is shown
via our own logger AND via root logger, so they are shown twice. Solution
is to disable logging propagation in runner.py.
Once T119 will be done, we will want to revert this commit.
Run testsuite, run task via runtask.py and import libtaskotron
as a library (e.g. run upgradepath task) and check that every output from log
is shown only once.
| Lint Skipped |
| Unit Tests Skipped |
much diff, very revision!
@kparal & @tfling - please confirm whether this behaviour is correct. I think it it, but I might have missed some use case, of course.
I have not yet became a logging guru, but this seems to do what we want. Current problems are caused by bayeux and yamlish, and T186 should ensure we send the patches upstream. In the meantime, and before T119 is finished, this is probably a good solution. Once T119 is finished, this might no longer be needed.