Differential D1052

Add tab for candidate compose / stable push request text
ClosedPublic
Actions

Authored by adamwill on Nov 9 2016, 2:31 AM.

Details

Reviewers
tflink
mkrizek
Commits
rBLKRe902b76ba4cb: Add tab for candidate compose / stable push request text
Summary

This adds a 'Requests' tab which provides proposed text for a
candidate compose request and a stable push request for the
current milestone, in wikitext format as these requests are
currently sent to Trac. We'll probably have to change it to
Markdown for Pagure soon enough, but that would be easy.

The candidate compose request lists all updates that:

  • Are not stable, obsolete or deleted
  • Fix an accepted blocker or FE bug for the relevant milestone

along with the related bugs. The stable push request adds one
more condition to those two:

  • Is queued for stable

In both cases, each update is listed along with the bugs it
fixes, in the same basic format I've been using for these
requests (doing it by hand) for years. The text is intended as
a starting point for a human to review, as sometimes it'll need
tweaking for unusual circumstances.

I included tests but I can't seem to run the tests here (pytest
blows up with some weird error when I try), so I haven't tested
the tests...I hope they work. :)

Test Plan

Run the app, go the the Requests tab for a milestone
(Fedora 25 Final is the best to try at present), check the text
looks appropriate.

Diff Detail

Repository
rBLKR blockerbugs
Branch
compose-push-request (branched from develop)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1103
Build 1103: arc lint + arc unit
adamwill retitled this revision from to Add tab for candidate compose / stable push request text.Nov 9 2016, 2:31 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: tflink, mkrizek.
adamwill updated this revision to Diff 2679.Nov 9 2016, 2:34 AM

Move the (FE) text to a less misleading place

When an update fixes both blocker and FE bugs, it's listed in the
blocker section and the FE bug links have '(FE)' added. I was adding
this *before* the link but that's misleading now I ditched the commas
and 'and' I was using when hand-writing these things, so move it to
after the link instead.

adamwill updated this revision to Diff 2681.Nov 9 2016, 6:42 PM

Track update 'request' status in the db, tweak text template

adamwill updated this revision to Diff 2682.Nov 9 2016, 6:43 PM

put alembic.ini back how it was

adamwill added a comment.Nov 9 2016, 9:43 PM

There's one thing I'd still like to improve here: the 'compose request' text takes no account of packages already requested for previous composes, so will duplicate those.

There's two possible ways to fix that, I think: 1) get the text from the update request somehow (probably involving using xmlrpc to talk to Trac...) and parse it, or 2) ask Koji what's in the relevant compose override tag. Talking to Koji is xmlrpc too, IIRC, but we have a client for it in python-fedora and I've done it before, so that way seems a bit better.

adamwill updated this revision to Diff 2689.Nov 17 2016, 1:00 AM

Update template to use Markdown syntax, rebase

mkrizek added a comment.Mar 6 2017, 9:19 AM

Oops, I somehow missed it, sorry about that :/ @adamwill do we still want this and/or how much is it up to date?

adamwill added a comment.Mar 6 2017, 6:58 PM

I still want it, it just got pushed down my priority list as we were out of the f25 blocker treadmill. Now we're on the f26 blocker treadmill I'll probably get back to this quite soon.

It's missing a feature I want it to have, at present - it can't leave out updates that have already been pulled into the side tag from the 'candidate compose request' list, and it should be able to do that. I haven't looked at it for a few months, but IIRC, that requires another database model change, unfortunately (the blockerbugs db doesn't include some info we need in order to implement that logic).

It did *work* as-is, though. I used a local blockerbugs instance with this patch applied to generate the candidate compose requests and stable push requests for f25 final.

mkrizek requested changes to this revision.Mar 9 2017, 2:02 PM

Looks good, just found one issue in the tests that needs to be fixed.

Also, apparently we missed that D1050 broke tests :/ We can deal with that in other DR though.

alembic/versions/cad797ffa042_add_request_to_update_model.py
23

Just found out that this does not work on sqlite and we use drop_column in several alembic scripts :/ Oh well, let's not deal with it here.

testing/test_controllers.py
259

release is not defined the method. cls.milestone should be self.milestone.

This revision now requires changes to proceed.Mar 9 2017, 2:02 PM
adamwill updated this revision to Diff 2978.Mar 16 2017, 11:24 PM

Fix test issues noted by @mkrizek

mkrizek accepted this revision.Mar 17 2017, 2:55 PM

Just one remaining issue. After fixing that, ship it!

testing/test_controllers.py
204

cls.milestone = add_milestone(cls.release, 'final', 100, 101,

This revision is now accepted and ready to land.Mar 17 2017, 2:55 PM
adamwill closed this revision.Mar 17 2017, 3:25 PM

Revision Contents

Diff 2978

View Options

alembic/versions/cad797ffa042_add_request_to_update_model.py

  • This file was added.
1​"""add request to update model
2​
3​Revision ID: cad797ffa042
4​Revises: 230e79315bd
5​Create Date: 2016-11-09 10:09:17.410474
6​
7​"""
8​
9​# revision identifiers, used by Alembic.
10​revision = 'cad797ffa042'
11​down_revision = '230e79315bd'
12​
13​from alembic import op
14​import sqlalchemy as sa
15​
16​
17​def upgrade():
18​ op.add_column(u'update', sa.Column('request', sa.String(length=80), nullable=True))
19​
20​
21​def downgrade():
22​ op.drop_column(u'update', u'request')
mkrizekUnsubmitted
Not Done

Just found out that this does not work on sqlite and we use drop_column in several alembic scripts :/ Oh well, let's not deal with it here.

View Options

blockerbugs/controllers/main.py

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Line(s)111 updates = Update.query.join(m_alias, Update.milestones).filter(
113 Update.karma < Update.stable_karma, 113​ Update.karma < Update.stable_karma,
114 or_(Update.pending != True, Update.pending == None), 114​ or_(Update.pending != True, Update.pending == None),
115 Update.bugs.any( 115​ Update.bugs.any(
116 or_(Bug.accepted_fe == True, Bug.accepted_blocker == True, 116​ or_(Bug.accepted_fe == True, Bug.accepted_blocker == True,
117 Bug.accepted_0day == True, Bug.accepted_prevrel == True, 117​ Bug.accepted_0day == True, Bug.accepted_prevrel == True,
118 Bug.proposed_fe == True, Bug.proposed_blocker == True))).all() 118​ Bug.proposed_fe == True, Bug.proposed_blocker == True))).all()
119 return updates 119​ return updates
120 120​
121​def get_milestone_all_nonstable_blocker_fixes(milestone):
122​ """
123​ return list of all non-stable, non-obsolete updates which are
124​ marked as fixing any accepted blocker bug for milestone
125​ """
126​ m_alias = db.aliased(Milestone)
127​ updates = Update.query.join(m_alias, Update.milestones).filter(
128​ m_alias.id == milestone.id, ~Update.status.in_(['obsolete', 'deleted']),
129​ or_(Update.status != 'stable', Update.pending == True),
130​ Update.bugs.any(
131​ or_(Bug.accepted_blocker == True, Bug.accepted_0day == True,
132​ Bug.accepted_prevrel == True))).all()
133​ return updates
134​
135​def get_milestone_all_nonstable_fe_fixes(milestone):
136​ """
137​ return list of all non-stable, non-obsolete updates which are
138​ marked as fixing any accepted FE bug for milestone
139​ """
140​ m_alias = db.aliased(Milestone)
141​ updates = Update.query.join(m_alias, Update.milestones).filter(
142​ m_alias.id == milestone.id, ~Update.status.in_(['obsolete', 'deleted']),
143​ or_(Update.status != 'stable', Update.pending == True),
144​ Update.bugs.any(Bug.accepted_fe == True)).all()
145​ return updates
146​
121 147​
122def get_current_milestone(): 148​def get_current_milestone():
123 current_milestone = Milestone.query.filter_by(current=True).first() 149​ current_milestone = Milestone.query.filter_by(current=True).first()
124 # if no current release is set, just grab one 150​ # if no current release is set, just grab one
125 if not current_milestone: 151​ if not current_milestone:
126 current_milestone = Milestone.query.first() 152​ current_milestone = Milestone.query.first()
127 return current_milestone 153​ return current_milestone
128 154​
▲ Show 20 Lines • Show All 80 Lines • ▼ Show 20 Line(s)234 updates = {
209 'Non Stable Updates': get_milestone_pending_stable_updates(milestone), 235​ 'Non Stable Updates': get_milestone_pending_stable_updates(milestone),
210 'Updates Needing Testing': get_milestone_updates_testing(milestone), 236​ 'Updates Needing Testing': get_milestone_updates_testing(milestone),
211 } 237​ }
212 return render_template('update_list.html', 238​ return render_template('update_list.html',
213 info=milestone_info, 239​ info=milestone_info,
214 updates=updates, 240​ updates=updates,
215 title="Fedora %s %s Blocker Bug Updates" % (milestone_info['number'], milestone_info['phase'])) 241​ title="Fedora %s %s Blocker Bug Updates" % (milestone_info['number'], milestone_info['phase']))
216 242​
243​@main.route('/milestone/<int:num>/<release_name>/requests')
244​def display_release_requests(num, release_name):
245​ release = Release.query.filter_by(number=num).first()
246​ milestone = Milestone.query.filter_by(release=release, version=release_name).first()
247​ if not milestone:
248​ abort(404)
249​ milestone_info = get_milestone_info(milestone)
250​ blockers = get_milestone_all_nonstable_blocker_fixes(milestone)
251​ fes = get_milestone_all_nonstable_fe_fixes(milestone)
252​ # if an update fixes both blockers and fes, drop it from fe list
253​ fes = [fe for fe in fes if fe not in blockers]
254​
255​ response = make_response(render_template('requests.txt', blockers=blockers, fes=fes, info=milestone_info))
256​ response.mimetype = 'text/plain'
257​ return response
217 258​
218@main.route('/milestone/<int:num>/<milestone_name>/need_testing') 259​@main.route('/milestone/<int:num>/<milestone_name>/need_testing')
219def display_updates_need_testing(num, milestone_name): 260​def display_updates_need_testing(num, milestone_name):
220 release = Release.query.filter_by(number=num).first() 261​ release = Release.query.filter_by(number=num).first()
221 milestone = Milestone.query.filter_by(release=release, version=milestone_name).first() 262​ milestone = Milestone.query.filter_by(release=release, version=milestone_name).first()
222 if not milestone: 263​ if not milestone:
223 abort(404) 264​ abort(404)
224 milestone_info = get_milestone_info(milestone) 265​ milestone_info = get_milestone_info(milestone)
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines
View Options

blockerbugs/models/update.py

Show All 37 Lines
38 38​
39class Update(db.Model): 39​class Update(db.Model):
40 id = db.Column(db.Integer, primary_key=True) 40​ id = db.Column(db.Integer, primary_key=True)
41 title = db.Column(db.Text, unique=False) 41​ title = db.Column(db.Text, unique=False)
42 url = db.Column(db.Text, unique=False) 42​ url = db.Column(db.Text, unique=False)
43 karma = db.Column(db.Integer, unique=False) 43​ karma = db.Column(db.Integer, unique=False)
44 stable_karma = db.Column(db.Integer, unique=False) 44​ stable_karma = db.Column(db.Integer, unique=False)
45 status = db.Column(db.String(80), unique=False) 45​ status = db.Column(db.String(80), unique=False)
46​ request = db.Column(db.String(80), unique=False, nullable=True)
46 pending = db.Column(db.Boolean, unique=False) 47​ pending = db.Column(db.Boolean, unique=False)
47 date_submitted = db.Column(db.DateTime) 48​ date_submitted = db.Column(db.DateTime)
48 date_pushed_testing = db.Column(db.DateTime, nullable=True) 49​ date_pushed_testing = db.Column(db.DateTime, nullable=True)
49 date_pushed_stable = db.Column(db.DateTime, nullable=True) 50​ date_pushed_stable = db.Column(db.DateTime, nullable=True)
50 date_obsoleted = db.Column(db.DateTime, nullable=True) 51​ date_obsoleted = db.Column(db.DateTime, nullable=True)
51 bugs = db.relationship('Bug', 52​ bugs = db.relationship('Bug',
52 secondary=update_fixes, 53​ secondary=update_fixes,
53 backref=db.backref('updates', 54​ backref=db.backref('updates',
54 lazy='dynamic', 55​ lazy='dynamic',
55 order_by=(status.desc(), pending.desc()))) 56​ order_by=(status.desc(), pending.desc())))
56 release_id = db.Column(db.Integer, db.ForeignKey('release.id')) 57​ release_id = db.Column(db.Integer, db.ForeignKey('release.id'))
57 release = db.relationship('Release', 58​ release = db.relationship('Release',
58 backref=db.backref('bugs', lazy='dynamic')) 59​ backref=db.backref('bugs', lazy='dynamic'))
59 milestones = db.relationship('Milestone', secondary=update_milestones, 60​ milestones = db.relationship('Milestone', secondary=update_milestones,
60 backref='updates') 61​ backref='updates')
61 62​
62 def __init__(self, title, url, karma, status, bugs, release, 63​ def __init__(self, title, url, karma, status, bugs, release,
63 milestones, stable_karma=3, date_submitted=None): 64​ milestones, stable_karma=3, date_submitted=None):
64 self.title = title 65​ self.title = title
65 self.url = url 66​ self.url = url
66 self.karma = karma 67​ self.karma = karma
67 self.status = status 68​ self.status = status
69​ self.request = None
68 self.bugs = bugs 70​ self.bugs = bugs
69 self.date_submitted = date_submitted 71​ self.date_submitted = date_submitted
70 self.release = release 72​ self.release = release
71 if milestones: 73​ if milestones:
72 self.milestones = milestones 74​ self.milestones = milestones
73 self.date_pushed_testing = None 75​ self.date_pushed_testing = None
74 self.date_pushed_stable = None 76​ self.date_pushed_stable = None
75 self.date_obsoleted = None 77​ self.date_obsoleted = None
76 78​
77 def __str__(self): 79​ def __str__(self):
78 return 'update: %s' % (self.title) 80​ return 'update: %s' % (self.title)
79 81​
80 def sync(self, updateinfo, fullsync=False): 82​ def sync(self, updateinfo, fullsync=False):
81 self.title = updateinfo['title'] 83​ self.title = updateinfo['title']
82 self.url = updateinfo['url'] 84​ self.url = updateinfo['url']
83 self.karma = updateinfo['karma'] 85​ self.karma = updateinfo['karma']
84 self.stable_karma = updateinfo['stable_karma'] 86​ self.stable_karma = updateinfo['stable_karma']
85 self.status = updateinfo['status'] 87​ self.status = updateinfo['status']
88​ self.request = updateinfo['request']
86 self.date_submitted = updateinfo['date_submitted'] 89​ self.date_submitted = updateinfo['date_submitted']
87 if updateinfo['date_pushed_testing']: 90​ if updateinfo['date_pushed_testing']:
88 self.date_pushed_testing = updateinfo['date_pushed_testing'] 91​ self.date_pushed_testing = updateinfo['date_pushed_testing']
89 if updateinfo['date_pushed_stable']: 92​ if updateinfo['date_pushed_stable']:
90 self.date_pushed_stable = updateinfo['date_pushed_stable'] 93​ self.date_pushed_stable = updateinfo['date_pushed_stable']
91 self.pending = updateinfo['pending'] 94​ self.pending = updateinfo['pending']
92 current_bugids = [bug.bugid for bug in self.bugs] 95​ current_bugids = [bug.bugid for bug in self.bugs]
93 for bugid in updateinfo['bugs']: 96​ for bugid in updateinfo['bugs']:
Show All 15 Lines
View Options

blockerbugs/templates/milestone_base.html

Show All 10 Lines
11<span class="sub-menu"> 11​<span class="sub-menu">
12 <ul> 12​ <ul>
13 <li><a {{ subnavactive('info') }} href="./info">Info</a></li> 13​ <li><a {{ subnavactive('info') }} href="./info">Info</a></li>
14 <li><a {{ subnavactive('buglist') }} href="./buglist">Bug List</a></li> 14​ <li><a {{ subnavactive('buglist') }} href="./buglist">Bug List</a></li>
15 <li><a {{ subnavactive('updates') }} href="./updates">Updates</a></li> 15​ <li><a {{ subnavactive('updates') }} href="./updates">Updates</a></li>
16 <li><a {{ subnavactive('spins') }} href="./spins">Spins</a></li> 16​ <li><a {{ subnavactive('spins') }} href="./spins">Spins</a></li>
17 <li><a {{ subnavactive('stats') }} href="./stats">Stats</a></li> 17​ <li><a {{ subnavactive('stats') }} href="./stats">Stats</a></li>
18 <li><a {{ subnavactive('irc') }} href="./irc">IRC Format</a></li> 18​ <li><a {{ subnavactive('irc') }} href="./irc">IRC Format</a></li>
19​ <li><a {{ subnavactive('irc') }} href="./requests">Requests</a></li>
19 </ul> 20​ </ul>
20 </div> 21​ </div>
21</div> 22​</div>
22{% endblock %} 23​{% endblock %}
23 24​
View Options

blockerbugs/templates/requests.txt

  • This file was added.
1​{% autoescape false -%}
2​### CANDIDATE COMPOSE ###
3​
4​== Blockers ==
5​{% for update in blockers %}
6​* [{{ update.title }}]({{ update.url }}) for {%- for bug in update.bugs %} [#{{ bug.bugid }}](https://bugzilla.redhat.com/show_bug.cgi?id={{ bug.bugid }}){% if bug.accepted_fe and not bug.accepted_blocker and not bug.accepted_prevrel and not bug.accepted_0day %} (FE){% endif %}{% endfor %}
7​{%- endfor %}
8​
9​== Freeze exceptions ==
10​{% for update in fes %}
11​* [{{ update.title }}]({{ update.url }}) for {%- for bug in update.bugs %} [#{{ bug.bugid }}](https://bugzilla.redhat.com/show_bug.cgi?id={{ bug.bugid }}){% endfor %}
12​{%- endfor %}
13​
14​
15​### FREEZE PUSH ###
16​
17​
18​== Blockers ==
19​{% for update in blockers if update.request == 'stable' %}
20​* [{{ update.title }}]({{ update.url }}) for {%- for bug in update.bugs %} [#{{ bug.bugid }}](https://bugzilla.redhat.com/show_bug.cgi?id={{ bug.bugid }}){% if bug.accepted_fe and not bug.accepted_blocker and not bug.accepted_prevrel and not bug.accepted_0day %} (FE){% endif %}{% endfor %}
21​{%- endfor %}
22​
23​== Freeze exceptions ==
24​{% for update in fes if update.request == 'stable' %}
25​* [{{ update.title }}]({{ update.url }}) for {%- for bug in update.bugs %} [#{{ bug.bugid }}](https://bugzilla.redhat.com/show_bug.cgi?id={{ bug.bugid }}){% endfor %}
26​{%- endfor %}
27​{% endautoescape %}
View Options

blockerbugs/util/update_sync.py

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Line(s)44 def extract_information(self, update):
45 updateinfo = {} 45​ updateinfo = {}
46 date_pushed = None 46​ date_pushed = None
47 if update.date_pushed: 47​ if update.date_pushed:
48 date_pushed = datetime.strptime(update.date_pushed, 48​ date_pushed = datetime.strptime(update.date_pushed,
49 '%Y-%m-%d %H:%M:%S') 49​ '%Y-%m-%d %H:%M:%S')
50 updateinfo['date_pushed_testing'] = None 50​ updateinfo['date_pushed_testing'] = None
51 updateinfo['date_pushed_stable'] = None 51​ updateinfo['date_pushed_stable'] = None
52 updateinfo['pending'] = False 52​ updateinfo['pending'] = False
53​ # this will be None if there is no request
54​ updateinfo['request'] = update.request
53 if update.status == 'pending': 55​ if update.status == 'pending':
54 updateinfo['pending'] = True 56​ updateinfo['pending'] = True
55 57​
56 if update.request == 'stable': 58​ if update.request == 'stable':
57 updateinfo['status'] = 'stable' 59​ updateinfo['status'] = 'stable'
58 updateinfo['date_pushed_testing'] = date_pushed 60​ updateinfo['date_pushed_testing'] = date_pushed
59 elif update.request == 'testing': 61​ elif update.request == 'testing':
60 updateinfo['status'] = 'testing' 62​ updateinfo['status'] = 'testing'
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

testing/test_controllers.py

Show First 20 Lines • Show All 194 Lines • ▼ Show 20 Line(s)
195 195​
196 196​
197class TestGetFunctions(object): 197​class TestGetFunctions(object):
198 @classmethod 198​ @classmethod
199 def setup_class(cls): 199​ def setup_class(cls):
200 db.session.rollback() 200​ db.session.rollback()
201 db.drop_all() 201​ db.drop_all()
202 db.create_all() 202​ db.create_all()
203 release = add_release(99) 203​ cls.release = add_release(99)
204 cls.milestone = add_milestone(release, 'final', 100, 101, 204​ cls.milestone = add_milestone(release, 'final', 100, 101,
mkrizekUnsubmitted
Not Done

cls.milestone = add_milestone(cls.release, 'final', 100, 101,

205 '99-final', True) 205​ '99-final', True)
206 add_milestone(release, 'beta', 200, 201, '99-beta') 206​ add_milestone(cls.release, 'beta', 200, 201, '99-beta')
207 add_spin('test-spin1', SpinType.TC, [], cls.milestone, 207​ add_spin('test-spin1', SpinType.TC, [], cls.milestone,
208 state=SpinState.built) 208​ state=SpinState.built)
209 bug1 = add_bug(9000, 'testbug1', cls.milestone) 209​ bug1 = add_bug(9000, 'testbug1', cls.milestone)
210 bug2 = add_bug(9001, 'testbug2', cls.milestone) 210​ bug2 = add_bug(9001, 'testbug2', cls.milestone)
211 bug2.accepted_blocker = False 211​ bug2.accepted_blocker = False
212 cls.update_pending_stable = add_update(u'test-pending-stable.fc99', u'stable', [bug1], 212​ cls.update_pending_stable = add_update(u'test-pending-stable.fc99', u'stable', [bug1],
213 release, [cls.milestone]) 213​ cls.release, [cls.milestone])
214 cls.update_pending_stable.pending = True 214​ cls.update_pending_stable.pending = True
215 cls.update_stable = add_update(u'test-stable1.fc99', u'stable', [bug1], 215​ cls.update_stable = add_update(u'test-stable1.fc99', u'stable', [bug1],
216 release, [cls.milestone]) 216​ cls.release, [cls.milestone])
217 cls.update_stable = add_update(u'test-stable2.fc99', u'stable', [bug2], 217​ cls.update_stable = add_update(u'test-stable2.fc99', u'stable', [bug2],
218 release, [cls.milestone]) 218​ cls.release, [cls.milestone])
219 cls.update_pending_testing = add_update(u'test-pending-testing.fc99', u'testing', [bug1], 219​ cls.update_pending_testing = add_update(u'test-pending-testing.fc99', u'testing', [bug1],
220 release, [cls.milestone]) 220​ cls.release, [cls.milestone])
221 cls.update_pending_testing.pending = True 221​ cls.update_pending_testing.pending = True
222 cls.update_testing1 = add_update(u'test-testing1.fc99', u'testing', [bug1], 222​ cls.update_testing1 = add_update(u'test-testing1.fc99', u'testing', [bug1],
223 release, [cls.milestone]) 223​ cls.release, [cls.milestone])
224 cls.update_testing2 = add_update(u'test-testing2.fc99', u'testing', [bug2], 224​ cls.update_testing2 = add_update(u'test-testing2.fc99', u'testing', [bug2],
225 release, [cls.milestone]) 225​ cls.release, [cls.milestone])
226 db.session.commit() 226​ db.session.commit()
227 227​
228 @classmethod 228​ @classmethod
229 def teardown_class(cls): 229​ def teardown_class(cls):
230 db.session.rollback() 230​ db.session.rollback()
231 db.drop_all() 231​ db.drop_all()
232 232​
233 def test_get_pending_stable_updates(self): 233​ def test_get_pending_stable_updates(self):
234 updates = main.get_milestone_pending_stable_updates(self.milestone) 234​ updates = main.get_milestone_pending_stable_updates(self.milestone)
235 assert len(updates) == 1 235​ assert len(updates) == 1
236 update = updates[0] 236​ update = updates[0]
237 assert self.update_pending_stable == update 237​ assert self.update_pending_stable == update
238 238​
239 239​
240 def test_get_testing_status_and_has_bugs_updates(self): 240​ def test_get_testing_status_and_has_bugs_updates(self):
241 updates = main.get_milestone_updates_testing(self.milestone) 241​ updates = main.get_milestone_updates_testing(self.milestone)
242 assert len(updates) == 1 242​ assert len(updates) == 1
243 update = updates[0] 243​ update = updates[0]
244 assert self.update_testing1 == update 244​ assert self.update_testing1 == update
245​
246​ def test_get_milestone_all_nonstable_blocker_fixes(self):
247​ updates = main.get_milestone_all_nonstable_blocker_fixes(self.milestone)
248​ assert len(updates) == 3
249​ expected = [self.update_pending_stable, self.update_pending_testing, self.update_testing1]
250​ updates.sort(key=lambda x: x.title)
251​ expected.sort(key=lambda x: x.title)
252​ assert updates == expected
253​
254​ def test_get_milestone_all_nonstable_fe_fixes(self):
255​ bug3 = add_bug(9002, 'testbug3', self.milestone)
256​ bug3.accepted_blocker = False
257​ bug3.accepted_fe = True
258​ update_testing3 = add_update(u'test-testing3.fc99', u'testing', [bug3],
259​ self.release, [self.milestone])
mkrizekUnsubmitted
Not Done

release is not defined the method. cls.milestone should be self.milestone.

260​ updates = main.get_milestone_all_nonstable_fe_fixes(self.milestone)
261​ assert len(updates) == 1
262​ update = updates[0]
263​ assert update_testing3 == update