Details

Reviewers

kparal
tflink

Maniphest Tasks

T170: fix example code in task writing guide docs

Commits

Summary

simplefix

Test Plan

make docs

Diff Detail

Repository

rLTRN libtaskotron

Lint

Lint Skipped

Unit

Unit Tests Skipped

Looks good to me

docs/source/writingtasks.rst
231–232	It's OK, but please remove the extra `str(...)` calls. They just complicate the code.

Yay! Please push :-)

Closed by commit rLTRN49d922c967bc (authored by @lbrabec).

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	293	8522122		May 22 2014, 11:09 AM	★	★
Diff 2	315	8522122	- removed call redundancy	May 29 2014, 7:38 AM	★	★
Diff 3	316	85d56d9	- code rebased, kparal did the work meanwhile	May 29 2014, 8:05 AM	★	★
Diff 4	317	85d56d9	- fixing bad merge conflict	May 29 2014, 8:09 AM	★	★
Diff 5	319	85d56d9	Commit rLTRN49d922c967bc165d44a032674fb6b8e64614fc4f	May 29 2014, 8:21 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f5ae8253de01	b81ae0e10e68	d50ff3858458	Lukas Brabec	fixing bad merge conflict	May 29 2014, 8:09 AM
d50ff3858458	9b7538d1efe4	726e55fc9804	Lukas Brabec	merge from develop	May 29 2014, 8:05 AM
726e55fc9804	a8afab1a3051	d55f7330f3ba 85d56d98d263	Lukas Brabec	code rebased, kparal did the work meanwhile	May 29 2014, 8:03 AM
d55f7330f3ba	3154b2c38eac	f42fdc69e3f2	Lukas Brabec	removed call redundancy	May 29 2014, 7:38 AM
f42fdc69e3f2	294b29e4d195	852212274721	Lukas Brabec	Fixing example code in task writing guide docs	May 22 2014, 11:09 AM

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Line(s)		220	.. code-block:: python
223		223
224	def run_mytask(rpmfiles, bodhi_id):	224		def run_mytask(rpmfiles, bodhi_id):
225	"""run through all passed in rpmfiles and emit TAP13 saying they all passed"""	225		"""run through all passed in rpmfiles and emit TAP13 saying they all passed"""
226		226
227	print "Running mytask on %s" % bodhi_id	227		print "Running mytask on %s" % bodhi_id
228		228
229	details = []	229		details = []
230	result = 'PASSED'	230		result = 'PASSED'
231	summary = 'mycheck %s for %s' % (result, bodhi_id)	231		summary = 'mycheck %s for %s' % (result, bodhi_id)
232	detail = check.CheckDetail(rpmfile, check.ReportType.BODHI_UPDATE,	232		detail = check.CheckDetail(bodhi_id, check.ReportType.BODHI_UPDATE,
			kparalUnsubmitted Not Done It's OK, but please remove the extra `str(...)` calls. They just complicate the code.
233	result, summary)	233		result, summary)
234	for rpmfile in rpmfiles:	234		for rpmfile in rpmfiles:
235	detail.store(rpmfile, False)	235		detail.store(rpmfile, False)
236		236
237	return check.export_TAP(detail)	237		return check.export_TAP(detail)
238		238
239	Now if we run the task we get output that ends with::	239		Now if we run the task we get output that ends with::
240		240
Show All 26 Lines