Differential D1039

Force GNOME to notify updates, re-enable test on Workstation
ClosedPublic
Actions

Authored by adamwill on Oct 26 2016, 10:02 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS7b31b8263edc: Force GNOME to notify updates, re-enable test on Workstation
Summary

GNOME's update notification criteria are pretty braindead: it
fires the update check timer once on login then once every hour
thereafter, but only actually checks for and notifies of updates
once a day if it's after 6am(?!?!?!). So we have to do a bunch
of fiddling around to ensure we reliably get a notification.
Move the clock to 6am if it's earlier than that, and reset the
'last update check' timer to 48 hours ago, then log in to GNOME
after that.

Note: I thought this still wasn't fully reliable, but I've looked
into all the recent failures of either test on staging and
there's only one which was really 'no update notification came
up', and the logs clearly indicate PK did run an update check,
so I don't think that was a test bug (I think something went
wrong with the update check). The other failures are all 'GNOME
did something wacky', plus one case where the needle didn't quite
match because I think the match area is slightly too tall; I'll
fix that in a second.

Test Plan

Run the tests on both KDE and GNOME and check they
work properly now (assuming nothing unrelated breaks, like KDE
crashing...)

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to Force GNOME to notify updates, re-enable test on Workstation.Oct 26 2016, 10:02 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 2650.Oct 26 2016, 10:04 PM

Make the GNOME 'update notification only' needle a bit shorter

See https://openqa.stg.fedoraproject.org/tests/51882#step/desktop_notifications/35

garretraziel accepted this revision.Oct 27 2016, 2:31 PM

What? 6 AM? Why? What is the purpose of that? Why have they done that? Maybe we'll never know...

This revision is now accepted and ready to land.Oct 27 2016, 2:31 PM
adamwill added a comment.Oct 27 2016, 3:11 PM

That's *exactly* what I thought.

Closed by commit rOPENQATESTS7b31b8263edc: Force GNOME to notify updates, re-enable test on Workstation (authored by adamwill). · Explain WhyOct 27 2016, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 2658

View Options

needles/console/user_logged_in.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 14, 4​ "height": 14,
5 "type": "match", 5​ "type": "match",
6 "width": 41, 6​ "width": 41,
7 "xpos": 7, 7​ "xpos": 7,
8 "ypos": 95 8​ "ypos": 95
9 }, 9​ },
10 { 10​ {
11 "height": 17, 11​ "height": 14,
12 "type": "match", 12​ "type": "match",
13 "width": 17, 13​ "width": 17,
14 "xpos": 136, 14​ "xpos": 136,
15 "ypos": 93 15​ "ypos": 96
16 } 16​ }
17 ], 17​ ],
18 "tags": [ 18​ "tags": [
19 "user_logged_in", 19​ "user_logged_in",
20 "user_console", 20​ "user_console",
21 "ENV-DISTRI-fedora", 21​ "ENV-DISTRI-fedora",
22 "ENV-FLAVOR-server" 22​ "ENV-FLAVOR-server"
23 ] 23​ ]
24} 24​}
25​No newline at end of file
View Options

needles/gnome/desktop_update_notification_only.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 95, 4​ "height": 92,
5 "type": "match", 5​ "type": "match",
6 "width": 40, 6​ "width": 40,
7 "xpos": 170, 7​ "xpos": 170,
8 "ypos": 90 8​ "ypos": 94
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "desktop_update_notification_only", 12​ "desktop_update_notification_only",
13 "DESKTOP-gnome" 13​ "DESKTOP-gnome"
14 ] 14​ ]
15} 15​}
16​No newline at end of file
View Options

templates

Show First 20 Lines • Show All 365 Lines • ▼ Show 20 Line(s)364 product => {
366 distri => "fedora", 366​ distri => "fedora",
367 flavor => "KDE-live-iso", 367​ flavor => "KDE-live-iso",
368 version => "*", 368​ version => "*",
369 }, 369​ },
370 test_suite => { name => "desktop_browser" }, 370​ test_suite => { name => "desktop_browser" },
371 }, 371​ },
372 { 372​ {
373 machine => { name => "64bit" }, 373​ machine => { name => "64bit" },
374​ prio => 30,
375​ product => {
376​ arch => "x86_64",
377​ distri => "fedora",
378​ flavor => "Workstation-live-iso",
379​ version => "*",
380​ },
381​ test_suite => { name => "desktop_notifications_live" },
382​ },
383​ {
384​ machine => { name => "64bit" },
374 prio => 32, 385​ prio => 32,
375 product => { 386​ product => {
376 arch => "x86_64", 387​ arch => "x86_64",
377 distri => "fedora", 388​ distri => "fedora",
378 flavor => "KDE-live-iso", 389​ flavor => "KDE-live-iso",
379 version => "*", 390​ version => "*",
380 }, 391​ },
381 test_suite => { name => "desktop_notifications_live" }, 392​ test_suite => { name => "desktop_notifications_live" },
382 }, 393​ },
383 { 394​ {
384 machine => { name => "64bit" }, 395​ machine => { name => "64bit" },
396​ prio => 30,
397​ product => {
398​ arch => "x86_64",
399​ distri => "fedora",
400​ flavor => "Workstation-live-iso",
401​ version => "*",
402​ },
403​ test_suite => { name => "desktop_notifications_postinstall" },
404​ },
405​ {
406​ machine => { name => "64bit" },
385 prio => 32, 407​ prio => 32,
386 product => { 408​ product => {
387 arch => "x86_64", 409​ arch => "x86_64",
388 distri => "fedora", 410​ distri => "fedora",
389 flavor => "KDE-live-iso", 411​ flavor => "KDE-live-iso",
390 version => "*", 412​ version => "*",
391 }, 413​ },
392 test_suite => { name => "desktop_notifications_postinstall" }, 414​ test_suite => { name => "desktop_notifications_postinstall" },
▲ Show 20 Lines • Show All 1771 Lines • ▼ Show 20 Line(s)2184 settings => [
2164 { key => "START_AFTER_TEST", value => "install_default_upload" }, 2186​ { key => "START_AFTER_TEST", value => "install_default_upload" },
2165 { key => "BOOTFROM", value => "c" }, 2187​ { key => "BOOTFROM", value => "c" },
2166 { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" }, 2188​ { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
2167 ], 2189​ ],
2168 }, 2190​ },
2169 { 2191​ {
2170 name => "desktop_notifications_postinstall", 2192​ name => "desktop_notifications_postinstall",
2171 settings => [ 2193​ settings => [
2172 { key => "POSTINSTALL", value => "desktop_notifications" }, 2194​ { key => "ENTRYPOINT", value => "desktop_notifications" },
2173 { key => "START_AFTER_TEST", value => "install_default_upload" }, 2195​ { key => "START_AFTER_TEST", value => "install_default_upload" },
2174 { key => "BOOTFROM", value => "c" }, 2196​ { key => "BOOTFROM", value => "c" },
2175 { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" }, 2197​ { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
2176 ], 2198​ ],
2177 }, 2199​ },
2178 { 2200​ {
2179 name => "desktop_notifications_live", 2201​ name => "desktop_notifications_live",
2180 settings => [ 2202​ settings => [
Show All 29 Lines
View Options

tests/desktop_notifications.pm

1use base "installedtest"; 1​use base "installedtest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use main_common; 4​use main_common;
5use packagetest; 5​use packagetest;
6 6​
7# This test sort of covers QA:Testcase_desktop_update_notification 7​# This test sort of covers QA:Testcase_desktop_update_notification
8# and QA:Testcase_desktop_error_checks . If it fails, probably *one* 8​# and QA:Testcase_desktop_error_checks . If it fails, probably *one*
9# of those failed, but we don't know which (deciphering which is 9​# of those failed, but we don't know which (deciphering which is
10# tricky and involves likely-fragile needles to try and figure out 10​# tricky and involves likely-fragile needles to try and figure out
11# what notifications we have). 11​# what notifications we have).
12 12​
13sub run { 13​sub run {
14 my $self = shift; 14​ my $self = shift;
15​ my $desktop = get_var("DESKTOP");
15 # for the live image case, handle bootloader here 16​ # for the live image case, handle bootloader here
16 unless (get_var("BOOTFROM")) { 17​ if (get_var("BOOTFROM")) {
17 $self->do_bootloader(postinstall=>0); 18​ $self->do_bootloader(postinstall=>1, params=>'3');
18 } 19​ }
19 assert_screen "graphical_desktop_clean", 300; 20​ else {
20 # ensure we actually have some package updates available 21​ $self->do_bootloader(postinstall=>0, params=>'3');
21 # we're kinda theoretically racing with the update check here, 22​ }
22 # but we have no great way to handle that especially live; let's 23​ boot_to_login_screen;
23 # just assume we're gonna win ​
24 $self->root_console(tty=>3); 24​ $self->root_console(tty=>3);
25​ # ensure we actually have some package updates available
25 prepare_test_packages; 26​ prepare_test_packages;
26 desktop_vt; 27​ if ($desktop eq 'gnome') {
28​ # On GNOME, move the clock forward if needed, because it won't
29​ # check for updates before 6am(!)
30​ my $hour = script_output 'date +%H';
31​ if ($hour < 6) {
32​ script_run 'systemctl stop chronyd.service ntpd.service';
33​ script_run 'systemctl disable chronyd.service ntpd.service';
34​ script_run 'systemctl mask chronyd.service ntpd.service';
35​ assert_script_run 'date --set="06:00:00"';
36​ }
37​ if (get_var("BOOTFROM")) {
38​ # Also reset the 'last update notification check' timestamp
39​ # to >24 hours ago (as that matters too)
40​ my $now = script_output 'date +%s';
41​ my $yday = $now - 48*60*60;
42​ # have to log in as the user to do this
43​ script_run 'exit', 0;
44​ console_login(user=>get_var('USER_LOGIN', 'test'), password=>get_var('USER_PASSWORD', 'weakpassword'));
45​ script_run "gsettings set org.gnome.software check-timestamp ${yday}", 0;
46​ wait_still_screen 3;
47​ script_run "gsettings get org.gnome.software check-timestamp", 0;
48​ wait_still_screen 3;
49​ script_run 'exit', 0;
50​ console_login(user=>'root', password=>get_var('ROOT_PASSWORD', 'weakpassword'));
51​ }
52​ }
53​ assert_script_run 'systemctl isolate graphical.target';
54​ send_key 'ctrl-alt-f1';
55​ if (get_var("BOOTFROM")) {
56​ assert_screen 'graphical_login';
57​ wait_still_screen 3;
58​ if (get_var("DESKTOP") eq 'gnome') {
59​ # we have to hit enter to get the password dialog
60​ send_key "ret";
61​ }
62​ assert_screen "graphical_login_input";
63​ type_very_safely get_var("USER_PASSWORD", "weakpassword");
64​ send_key 'ret';
65​ }
66​ assert_screen 'graphical_desktop_clean', 90;
27 # now, WE WAIT. this is just an unconditional wait - rather than 67​ # now, WE WAIT. this is just an unconditional wait - rather than
28 # breaking if we see an update notification appear - so we catch 68​ # breaking if we see an update notification appear - so we catch
29 # things that crash a few minutes after startup, etc. 69​ # things that crash a few minutes after startup, etc.
30 for my $n (1..5) { 70​ for my $n (1..20) {
31 sleep 120; 71​ sleep 30;
32 mouse_set 10, 10; 72​ mouse_set 10, 10;
33 mouse_hide; 73​ mouse_hide;
34 } 74​ }
35 my $desktop = get_var("DESKTOP"); ​
36 if ($desktop eq 'gnome') { 75​ if ($desktop eq 'gnome') {
37 # of course, we have no idea what'll be in the clock, so we just 76​ # of course, we have no idea what'll be in the clock, so we just
38 # have to click where we know it is 77​ # have to click where we know it is
39 mouse_set 512, 10; 78​ mouse_set 512, 10;
40 mouse_click; 79​ mouse_click;
41 } 80​ }
42 elsif ($desktop eq 'kde' && !get_var("BOOTFROM")) { 81​ elsif ($desktop eq 'kde' && !get_var("BOOTFROM")) {
43 # the order and number of systray icons varies in KDE, so we 82​ # the order and number of systray icons varies in KDE, so we
Show All 28 Lines