Loosen pin on sqlalchemy in requirements.txt.
ClosedPublic

Authored by ralph2 on Oct 19 2016, 6:02 PM.

Details

Summary

FWIW, I don't think we should be pinning versions in either requirements.txt
*or* in resultsdb.spec, unless we really know that we really do need a specific
version or a constrained version. It makes things much harder to package if
the versions are present here (in particular for things like EPEL7).

Cheers!

Test Plan

It shouldn't affect much.

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ralph2 retitled this revision from to Loosen pin on sqlalchemy in requirements.txt..Oct 19 2016, 6:02 PM
ralph2 updated this object.
ralph2 edited the test plan for this revision. (Show Details)
ralph2 added reviewers: jskladan, tflink.
jskladan accepted this revision.Oct 20 2016, 8:19 AM
jskladan added a subscriber: kparal.

Well, we (as in FedoraQA) had this discussion many times, and you should have the conversation with @kparal :) I always just let it go after an afternoon of heated discussion.

On a similar topic - my understanding of requirement.txt is, that you actually _should_ pin versions, to have repeatability. I have been bitten many times by (for example) Flask changing on the fly, and breaking the underlying code.

Even with knowing that stuff needs to be ported to EPEL, I'd rather pin to versions available in EPEL, to be sure of what we have to work with.

This revision is now accepted and ready to land.Oct 20 2016, 8:19 AM
Closed by commit rRSDB22c87cd29de4: Loosen pin on sqlalchemy in requirements.txt. (authored by Ralph Bean <rbean@redhat.com>, committed by Josef Skladanka <jskladan@redhat.com>). · Explain WhyNov 4 2016, 7:46 AM
This revision was automatically updated to reflect the committed changes.