Add needed import for file or syslog logging.
ClosedPublic
Actions

Authored by • ralph2 on Oct 13 2016, 4:34 PM.

Details

Reviewers

tflink
mkrizek
jskladan

Commits

rRSFEfea1e7ca9f69: Add needed import for file or syslog logging

Summary

When you use stream logging, everything works.

But if you try and use file logging or syslog logging, things fail with an
AttributeError because logging.handlers was never imported. This fixes that.

Test Plan

I tried this out on a dev instance.

Diff Detail

Repository

rRSFE resultsdb_frontend

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

• ralph2 retitled this revision from to Add needed import for file or syslog logging..Oct 13 2016, 4:34 PM

• ralph2 updated this object.

• ralph2 edited the test plan for this revision. (Show Details)

• ralph2 added reviewers: tflink, jskladan.

Thanks, LGTM. We should probably check all our Flask apps for this since they're mostly based on the same code.

This revision is now accepted and ready to land.Oct 13 2016, 4:51 PM

Closed by commit rRSFEfea1e7ca9f69: Add needed import for file or syslog logging (authored by Ralph Bean <rbean@redhat.com>, committed by kparal). · Explain WhyOct 27 2016, 2:11 PM

This revision was automatically updated to reflect the committed changes.

Thanks Ralph, pushed.

Revision Contents

			Path	Packages
M			resultsdb_frontend/__init__.py (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2621	1dcfe47		Oct 13 2016, 4:34 PM	★	★
Diff 2	2656	386aaf5	rRSFEfea1e7ca9f694334990540d7c1c870a39c1b4bb1	Oct 27 2016, 2:10 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
de660b66c648	62331d0ff99c	1dcfe47494b8	Ralph Bean	Add needed import for file or syslog logging. (Show More…)	Oct 13 2016, 4:32 PM

Diff 2656

View Options

resultsdb_frontend/init.py

Show All 18 Lines
19	# Josef Skladanka <jskladan@redhat.com>	19	# Josef Skladanka <jskladan@redhat.com>
20	# Ralph Bean <rbean@redhat.com>	20	# Ralph Bean <rbean@redhat.com>
21		21
22		22
23	from flask import Flask, render_template	23	from flask import Flask, render_template
24	from resultsdb_frontend import proxy	24	from resultsdb_frontend import proxy
25		25
26	import logging	26	import logging
		27	import logging.handlers
27	import os	28	import os
28		29
29	# the version as used in setup.py	30	# the version as used in setup.py
30	__version__ = "1.1.9"	31	__version__ = "1.1.9"
31		32
32	# Flask App	33	# Flask App
33	app = Flask(__name__)	34	app = Flask(__name__)
34	app.secret_key = 'replace-me-with-something-random'	35	app.secret_key = 'replace-me-with-something-random'
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines