Blacklist triggering jobs for specific releases
ClosedPublic

Authored by mkrizek on May 21 2014, 11:46 AM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

I think there was some miscommunication when we talked about this over IRC yesterday. I thought that you were talking about per-task blacklists, not global blacklists.

Either way, the question becomes whether this is an acceptable corner to cut. While this does satisfy our needs for the moment, we're eventually going to need the ability to have more granularity in how jobs are triggered to support env-and-stacks checks in copr, package-specific checks etc.

I'm tempted to just change the ticket description to say "don't run epel", leave it alone for now and free @mkrizek up to work on other tasks. Any other thoughts?

mkrizek updated this revision.May 21 2014, 12:52 PM
  • Add per-task blacklisting

I'm tempted to just change the ticket description to say "don't run epel", leave it alone for now and free @mkrizek up to work on other tasks. Any other thoughts?

Unless there are objections, let's do it this way. I think that we have much bigger fish to fry at the moment than adding features we can't fully support yet.

Sorry about that, I seem to confused myself :)

BTW the configuration is getting ugly, I'll need to rework that soon.

I'm tempted to just change the ticket description to say "don't run epel", leave it alone for now and free @mkrizek up to work on other tasks. Any other thoughts?

Sounds good.

conf/trigger.cfg.example
12

I see there's no documentation in the config file yet. Maybe this would be a good time to start ;-)

jobtriggers/bodhi_msg.py
27

I would actually split this into two if clauses (the original one would be left intact), because otherwise it's a bit difficult to read. Also it would be nice to have comments above it explaining what's happening.

I'm wondering if it would be better to go back to the first diff for simplicity

jobtriggers/config.py
34

I don't really like this idea of statically defining which tasks could have blacklists

jobtriggers/koji_msg.py
43

I don't think this will work, will it? If I'm reading this correctly, only upgradepath is in config.tasks

tflink requested changes to this revision.May 21 2014, 1:16 PM

I'm wondering if it would be better to go back to the first diff for simplicity

Talking on IRC, @kparal and I agreed that going back to the global blacklist is better for now. Please revert back to the orignal diff.

Sorry for the confusion on this, I'll be better about ticket descriptions in the future

mkrizek updated this revision.May 21 2014, 1:52 PM
  • Revert to 57687e474027f05eafff0d8e73faaf033d00b13d and add comments
tflink accepted this revision.May 21 2014, 4:04 PM

Looks good to me. Tested on fc20

mkrizek closed this revision.May 22 2014, 8:38 AM

Closed by commit rTRGR86957b742a1f (authored by @mkrizek).