consolidate login waits, use postinstall not entrypoint for base
ClosedPublic

Authored by adamwill on Sep 25 2016, 6:41 AM.

Details

Summary

I started out wanting to fix an issue I noticed today where
graphical upgrade tests were failing because they didn't wait
for the graphical login screen properly; the test was sitting
at the 'full Fedora logo' state of plymouth for a long time,
so the current boot_to_login_screen's wait_still_screen was
triggered by it and the function wound up failing on the
assert_screen, because it was still some time before the real
login screen appeared.

So I tweaked the boot_to_login_screen implementation to work
slightly differently (look for a login screen match, *then* -
if we're dealing with a graphical login - wait_still_screen
to defeat the 'old GPU buffer showing login screen' problem
and assert the login screen again). But while working on it,
I figured we really should consolidate all the various places
that handle the bootloader -> login, we were doing it quite
differently in all sorts of different places. And as part of
that, I converted the base tests to use POSTINSTALL (and thus
go through the shared _wait_login tests) instead of handling
boot themselves. As part of *that*, I tweaked main.pm to not
require all POSTINSTALL tests have the _postinstall suffix on
their names, as it really doesn't make sense, and renamed the
tests.

Test Plan

Run all tests, see if they work.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to consolidate login waits, use postinstall not entrypoint for base.Sep 25 2016, 6:41 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
adamwill updated this revision to Diff 2593.Sep 25 2016, 4:37 PM

Fix the 'while check_screen' loop, drop some old SDDM needles

So that '5 && $count' was...not doing what I meant it to do
:). Let's have some brackets here, huh. Also since we're
using the login needles a lot now, let's try and streamline
it as much as possible; per the admin UI these SDDM needles
are no longer needed.

garretraziel accepted this revision.Sep 27 2016, 11:37 AM

Oh I don't care, code looks OK and some of the tests passed; I don't want to run whole testsuite. And if it works on stg...

This revision is now accepted and ready to land.Sep 27 2016, 11:37 AM
This revision was automatically updated to reflect the committed changes.