Differential D1006

add a base_update_cli test
ClosedPublic
Actions

Authored by adamwill on Sep 20 2016, 8:10 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS44ec3d84c382: add a base_update_cli test
Summary

this uses a couple of test repos with fake packages to test the
basic dnf mechanisms are working, then messes around with the
python3-kickstart package a bit to try and test the default repo
configuration is working, keys are in place and so on. We use
python3-kickstart because we should be able to rely on the copy
of that package in the 'stable' repo being installable (or else
the compose would have failed), but it shouldn't be vital to
the operation of the system.

Test Plan

Run the test, see if it works.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add a base_update_cli test.Sep 20 2016, 8:10 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 2575.Sep 21 2016, 12:31 AM

split some bits into a new helper function module

we're gonna re-use these in graphical update testing, so let's
make a new 'packagetest' module which exports them and use it.

adamwill updated this revision to Diff 2579.Sep 21 2016, 4:47 PM

longer timeout for the update from real repos

https://openqa.stg.fedoraproject.org/tests/43922#step/base_update_cli/32
damnit, dnf, why must you.

garretraziel accepted this revision.Sep 22 2016, 9:22 AM

Aside from inline comment, this looks good to me.

I don't think that having openqa-test-x package is necessary, I think that we can only use python3-kickstart update test.

lib/main_common.pm
9 ↗(On Diff #2575)

I guess that this shouldn't be here.

This revision is now accepted and ready to land.Sep 22 2016, 9:22 AM
adamwill added a comment.Sep 22 2016, 3:03 PM

OK, sounds good to me - as I said on IRC I was kinda uncertain whether it's worth keeping them or not, so I'm happy to go with your opinion and take them out. I'll fix the other thing too, thanks.

lib/main_common.pm
9 ↗(On Diff #2579)

good catch, indeed. I moved it around a bit. :)

Closed by commit rOPENQATESTS44ec3d84c382: add a base_update_cli test (authored by adamwill). · Explain WhySep 22 2016, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
AMlib/packagetest.pm (37 lines)
Mtemplates (42 lines)
AMtests/base_update_cli.pm (38 lines)

Diff 2583

View Options

lib/packagetest.pm

  • This file was added.
1​package packagetest;
2​
3​use strict;
4​
5​use base 'Exporter';
6​use Exporter;
7​
8​use testapi;
9​our @EXPORT = qw/prepare_test_packages verify_installed_packages verify_updated_packages/;
10​
11​# enable the openqa test package repositories and install the main
12​# test packages, remove python3-kickstart and install the fake one
13​sub prepare_test_packages {
14​ # remove python3-kickstart if installed (we don't use assert
15​ # here in case it's not)
16​ script_run 'dnf -y remove python3-kickstart';
17​ # grab the test repo definitions
18​ assert_script_run 'curl -o /etc/yum.repos.d/openqa-testrepo-1.repo https://fedorapeople.org/groups/qa/openqa-repos/openqa-testrepo-1.repo';
19​ # install the test packages from repo1
20​ assert_script_run 'dnf -y --disablerepo=* --enablerepo=openqa-testrepo-1 install python3-kickstart';
21​}
22​
23​# check our test packages installed correctly (this is a test that dnf
24​# actually does what it claims)
25​sub verify_installed_packages {
26​ validate_script_output 'rpm -q python3-kickstart', sub { $_ =~ m/^python3-kickstart-1.1.noarch$/ };
27​ assert_script_run 'rpm -V python3-kickstart';
28​}
29​
30​# check updating the test packages and the fake python3-kickstart work
31​# as expected
32​sub verify_updated_packages {
33​ # we don't know what version of python3-kickstart we'll actually
34​ # get, so just check it's *not* the fake one
35​ validate_script_output 'rpm -q python3-kickstart', sub { $_ !~ m/^python3-kickstart-1-1.noarch$/ };
36​ assert_script_run 'rpm -V python3-kickstart';
37​}
View Options

templates

Show First 20 Lines • Show All 266 Lines • ▼ Show 20 Line(s)265 product => {
267 distri => "fedora", 267​ distri => "fedora",
268 flavor => "KDE-live-iso", 268​ flavor => "KDE-live-iso",
269 version => "*", 269​ version => "*",
270 }, 270​ },
271 test_suite => { name => "base_service_manipulation" }, 271​ test_suite => { name => "base_service_manipulation" },
272 }, 272​ },
273 { 273​ {
274 machine => { name => "64bit" }, 274​ machine => { name => "64bit" },
275​ prio => 40,
276​ product => {
277​ arch => "x86_64",
278​ distri => "fedora",
279​ flavor => "Workstation-live-iso",
280​ version => "*",
281​ },
282​ test_suite => { name => "base_update_cli" },
283​ },
284​ {
285​ machine => { name => "64bit" },
286​ prio => 40,
287​ product => {
288​ arch => "x86_64",
289​ distri => "fedora",
290​ flavor => "Server-dvd-iso",
291​ version => "*",
292​ },
293​ test_suite => { name => "base_update_cli" },
294​ },
295​ {
296​ machine => { name => "64bit" },
297​ prio => 42,
298​ product => {
299​ arch => "x86_64",
300​ distri => "fedora",
301​ flavor => "KDE-live-iso",
302​ version => "*",
303​ },
304​ test_suite => { name => "base_update_cli" },
305​ },
306​ {
307​ machine => { name => "64bit" },
275 prio => 30, 308​ prio => 30,
276 product => { 309​ product => {
277 arch => "x86_64", 310​ arch => "x86_64",
278 distri => "fedora", 311​ distri => "fedora",
279 flavor => "Workstation-live-iso", 312​ flavor => "Workstation-live-iso",
280 version => "*", 313​ version => "*",
281 }, 314​ },
282 test_suite => { name => "desktop_terminal" }, 315​ test_suite => { name => "desktop_terminal" },
▲ Show 20 Lines • Show All 1609 Lines • ▼ Show 20 Line(s)1923 {
1892 settings => [ 1925​ settings => [
1893 { key => "ENTRYPOINT", value => "base_service_manipulation" }, 1926​ { key => "ENTRYPOINT", value => "base_service_manipulation" },
1894 { key => "START_AFTER_TEST", value => "install_default_upload" }, 1927​ { key => "START_AFTER_TEST", value => "install_default_upload" },
1895 { key => "BOOTFROM", value => "c" }, 1928​ { key => "BOOTFROM", value => "c" },
1896 { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" }, 1929​ { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
1897 ], 1930​ ],
1898 }, 1931​ },
1899 { 1932​ {
1933​ name => "base_update_cli",
1934​ settings => [
1935​ { key => "ENTRYPOINT", value => "base_update_cli" },
1936​ { key => "START_AFTER_TEST", value => "install_default_upload" },
1937​ { key => "BOOTFROM", value => "c" },
1938​ { key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
1939​ ],
1940​ },
1941​ {
1900 name => "install_kickstart_firewall_disabled", 1942​ name => "install_kickstart_firewall_disabled",
1901 settings => [ 1943​ settings => [
1902 { key => "KICKSTART", value => "1" }, 1944​ { key => "KICKSTART", value => "1" },
1903 { key => "GRUB", value => "inst.ks=http://fedorapeople.org/groups/qa/kickstarts/firewall-disabled-net.ks" }, 1945​ { key => "GRUB", value => "inst.ks=http://fedorapeople.org/groups/qa/kickstarts/firewall-disabled-net.ks" },
1904 { key => "POSTINSTALL", value => "firewall_disabled" }, 1946​ { key => "POSTINSTALL", value => "firewall_disabled" },
1905 { key => "ROOT_PASSWORD", value => "anaconda" }, 1947​ { key => "ROOT_PASSWORD", value => "anaconda" },
1906 { key => "USER_LOGIN", value => "false" }, 1948​ { key => "USER_LOGIN", value => "false" },
1907 ], 1949​ ],
▲ Show 20 Lines • Show All 175 Lines • Show Last 20 Lines
View Options

tests/base_update_cli.pm

  • This file was added.
1​use base "installedtest";
2​use strict;
3​use testapi;
4​use packagetest;
5​
6​sub run {
7​ my $self = shift;
8​ # wait for boot to complete
9​ $self->boot_to_login_screen("", 30);
10​ # switch to TTY3 for both, graphical and console tests
11​ $self->root_console(tty=>3);
12​ # enable test repos and install test packages
13​ prepare_test_packages;
14​ # check rpm agrees they installed good
15​ verify_installed_packages;
16​ # update the fake python3-kickstart (should come from the real repo)
17​ # this can take a long time if we get unlucky with the metadata refresh
18​ assert_script_run 'dnf -y --disablerepo=openqa-testrepo* --disablerepo=updates-testing update python3-kickstart', 600;
19​ # check we got the updated version
20​ verify_updated_packages;
21​ # now remove python3-kickstart, and see if we can do a straight
22​ # install from the default repos
23​ assert_script_run 'dnf -y remove python3-kickstart';
24​ assert_script_run 'dnf -y --disablerepo=openqa-testrepo* --disablerepo=updates-testing install python3-kickstart', 120;
25​ assert_script_run 'rpm -V python3-kickstart';
26​}
27​
28​sub test_flags {
29​ # without anything - rollback to 'lastgood' snapshot if failed
30​ # 'fatal' - whole test suite is in danger if this fails
31​ # 'milestone' - after this test succeeds, update 'lastgood'
32​ # 'important' - if this fails, set the overall state to 'fail'
33​ return { fatal => 1 };
34​}
35​
36​1;
37​
38​# vim: set sw=4 et: