Differential D1005

make sure we get logs from failed kickstart installs
ClosedPublic
Actions

Authored by adamwill on Sep 20 2016, 3:13 AM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS1cdd8e18b72e: make sure we get logs from failed kickstart installs
Summary

by waiting for the bootloader in _boot_to_anaconda rather than
_console_wait_login, we can ensure that we use the anaconda
post-fail hook and thus get logs uploaded when a kickstart
install fails.

Test Plan

Run a kickstart install test that fails and check
anaconda logs get uploaded. Then run one that works and make
sure it...still works.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Branch
kickstart-failhook
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 850
Build 850: arc lint + arc unit
adamwill retitled this revision from to make sure we get logs from failed kickstart installs.Sep 20 2016, 3:13 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill added a comment.Sep 20 2016, 3:26 AM

I tested this out on staging. Here's a job that (still) passes:

https://openqa.stg.fedoraproject.org/tests/43628

Here's one that fails and uploads logs:

https://openqa.stg.fedoraproject.org/tests/43627

garretraziel accepted this revision.Sep 20 2016, 10:47 AM

Looks OK.

This revision is now accepted and ready to land.Sep 20 2016, 10:47 AM
adamwill closed this revision.Sep 20 2016, 5:52 PM

also landed but didn't get closed for some reason. I must have some issue in my laptop arc setup...

Revision Contents

Diff 2569

View Options

lib/fedorabase.pm

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s)101 my %args = (
105 first => 1, 105​ first => 1,
106 timeout => 30, 106​ timeout => 30,
107 uefi => get_var("UEFI"), 107​ uefi => get_var("UEFI"),
108 @_ 108​ @_
109 ); 109​ );
110 # if not postinstall and not UEFI, syslinux 110​ # if not postinstall and not UEFI, syslinux
111 $args{bootloader} //= ($args{uefi} || $args{postinstall}) ? "grub" : "syslinux"; 111​ $args{bootloader} //= ($args{uefi} || $args{postinstall}) ? "grub" : "syslinux";
112 if ($args{uefi}) { 112​ if ($args{uefi}) {
113 # we don't just tag all screens with 'bootloader' because we 113​ # we use the firmware-type specific tags because we want to be
114 # want to be sure we actually did a UEFI boot 114​ # sure we actually did a UEFI boot
115 assert_screen "bootloader_uefi", $args{timeout}; 115​ assert_screen "bootloader_uefi", $args{timeout};
116 } else { 116​ } else {
117 assert_screen "bootloader", $args{timeout}; 117​ assert_screen "bootloader_bios", $args{timeout};
118 } 118​ }
119 if ($args{mutex}) { 119​ if ($args{mutex}) {
120 # cancel countdown 120​ # cancel countdown
121 send_key "left"; 121​ send_key "left";
122 mutex_lock $args{mutex}; 122​ mutex_lock $args{mutex};
123 mutex_unlock $args{mutex}; 123​ mutex_unlock $args{mutex};
124 } 124​ }
125 if ($args{first}) { 125​ if ($args{first}) {
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines
View Options

needles/console/bootloader_bios_installed.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 15, 4​ "height": 15,
5 "type": "match", 5​ "type": "match",
6 "width": 160, 6​ "width": 160,
7 "xpos": 50, 7​ "xpos": 50,
8 "ypos": 335 8​ "ypos": 335
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "bootloader", 12​ "bootloader",
13​ "bootloader_bios",
13 "ENV-DISTRI-fedora" 14​ "ENV-DISTRI-fedora"
14 ] 15​ ]
15} 16​}
View Options

needles/console/bootloader_bios_live.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "ypos": 326, 4​ "ypos": 326,
5 "height": 20, 5​ "height": 20,
6 "xpos": 91, 6​ "xpos": 91,
7 "type": "match", 7​ "type": "match",
8 "width": 449 8​ "width": 449
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "bootloader", 12​ "bootloader",
13​ "bootloader_bios",
13 "ENV-DISTRI-fedora", 14​ "ENV-DISTRI-fedora",
14 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
15 ] 16​ ]
16} 17​}
View Options

needles/console/bootloader_bios_offline.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "ypos": 326, 4​ "ypos": 326,
5 "height": 20, 5​ "height": 20,
6 "xpos": 91, 6​ "xpos": 91,
7 "type": "match", 7​ "type": "match",
8 "width": 449 8​ "width": 449
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "bootloader", 12​ "bootloader",
13​ "bootloader_bios",
13 "ENV-DISTRI-fedora", 14​ "ENV-DISTRI-fedora",
14 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
15 ] 16​ ]
16} 17​}
View Options

needles/console/bootloader_uefi.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "ENV-DISTRI-fedora", 3​ "ENV-DISTRI-fedora",
4 "ENV-FLAVOR-server_boot", 4​ "ENV-FLAVOR-server_boot",
5 "ENV-FLAVOR-workstation_live", 5​ "ENV-FLAVOR-workstation_live",
6 "ENV-UEFI-1", 6​ "ENV-UEFI-1",
7 "bootloader_uefi" 7​ "bootloader_uefi",
8​ "bootloader"
8 ], 9​ ],
9 "area": [ 10​ "area": [
10 { 11​ {
11 "width": 140, 12​ "width": 140,
12 "height": 14, 13​ "height": 14,
13 "xpos": 126, 14​ "xpos": 126,
14 "type": "match", 15​ "type": "match",
15 "ypos": 140 16​ "ypos": 140
16 } 17​ }
17 ], 18​ ],
18 "properties": [] 19​ "properties": []
19} 20​}
View Options

tests/_boot_to_anaconda.pm

Show All 22 Lines6sub run {
23 23​
24 # set mutex wait if necessary 24​ # set mutex wait if necessary
25 my $mutex = get_var("INSTALL_UNLOCK"); 25​ my $mutex = get_var("INSTALL_UNLOCK");
26 26​
27 # call do_bootloader with postinstall=0, the params, and the mutex 27​ # call do_bootloader with postinstall=0, the params, and the mutex
28 $self->do_bootloader(postinstall=>0, params=>$params, mutex=>$mutex); 28​ $self->do_bootloader(postinstall=>0, params=>$params, mutex=>$mutex);
29 29​
30 # proceed to installer 30​ # proceed to installer
31 unless (get_var("KICKSTART")) 31​ if (get_var("KICKSTART")) {
32 { 32​ # wait for the bootloader *here* - in a test that inherits from
33​ # anacondatest - so that if something goes wrong during install,
34​ # we get anaconda logs
35​ assert_screen "bootloader", 1800;
36​ }
37​ else {
33 if (get_var("ANACONDA_TEXT")) { 38​ if (get_var("ANACONDA_TEXT")) {
34 # select that we don't want to start VNC; we want to run in text mode 39​ # select that we don't want to start VNC; we want to run in text mode
35 assert_screen "anaconda_use_text_mode", 300; 40​ assert_screen "anaconda_use_text_mode", 300;
36 type_string "2\n"; 41​ type_string "2\n";
37 # wait for text version of Anaconda main hub 42​ # wait for text version of Anaconda main hub
38 assert_screen "anaconda_main_hub_text", 300; 43​ assert_screen "anaconda_main_hub_text", 300;
39 } else { 44​ } else {
40 # on lives, we have to explicitly launch anaconda 45​ # on lives, we have to explicitly launch anaconda
Show All 37 Lines
View Options

tests/_console_wait_login.pm

1use base "fedorabase"; 1​use base "fedorabase";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self = shift; 6​ my $self = shift;
7 # If KICKSTART is set, then the wait_time needs to consider the 7​ # If UPGRADE is set, we have to wait for the entire upgrade
8 # install time. if UPGRADE, we have to wait for the entire upgrade ​
9 my $wait_time = 300; 8​ my $wait_time = 300;
10 $wait_time = 1800 if (get_var("KICKSTART")); ​
11 $wait_time = 6000 if (get_var("UPGRADE")); 9​ $wait_time = 6000 if (get_var("UPGRADE"));
12 10​
13 # handle bootloader, if requested 11​ # handle bootloader, if requested
14 if (get_var("GRUB_POSTINSTALL")) { 12​ if (get_var("GRUB_POSTINSTALL")) {
15 $self->do_bootloader(postinstall=>1, params=>get_var("GRUB_POSTINSTALL"), timeout=>$wait_time); 13​ $self->do_bootloader(postinstall=>1, params=>get_var("GRUB_POSTINSTALL"), timeout=>$wait_time);
16 $wait_time = 180; 14​ $wait_time = 180;
17 } 15​ }
18 16​
Show All 23 Lines