From 4e64ab7a22be86b7cc3c758079138768740c310a Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Tue, 24 Feb 2015 14:37:59 -0800 Subject: [PATCH 16/40] Ticket #48048 - Fix coverity issues - 2015/2/24 Coverity defect 13064 - Explicit null dereferenced (FORWARD_NULL) Description: Added NULL check for sdn. modified: chaining_back_delete in cb_delete.c --- ldap/servers/plugins/chainingdb/cb_delete.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ldap/servers/plugins/chainingdb/cb_delete.c b/ldap/servers/plugins/chainingdb/cb_delete.c index 1538589..7b801a5 100644 --- a/ldap/servers/plugins/chainingdb/cb_delete.c +++ b/ldap/servers/plugins/chainingdb/cb_delete.c @@ -84,8 +84,11 @@ chaining_back_delete ( Slapi_PBlock *pb ) } slapi_pblock_get( pb, SLAPI_DELETE_TARGET_SDN, &sdn ); + if (NULL == sdn) { + cb_send_ldap_result(pb, LDAP_INVALID_DN_SYNTAX, NULL, "Null target DN", 0, NULL); + return -1; + } dn = slapi_sdn_get_dn(sdn); - /* * Check local acls */ -- 1.9.3