From 645f21065bb485c5e402b83ba8afbd03d3d4142c Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Tue, 15 Jul 2014 10:46:09 -0400 Subject: [PATCH] Ticket 47853 - client hangs in add if memberof fails Bug Description: If memberof plugin is enabled and the client adds an entry with a membership attr it hangs if the memberof_postop_add rejects the operation. Fix Description: The problem is due to an unpexrtec error code being set in the pblock (-1). Setting the proper LDAP error code resolves the hang. https://fedorahosted.org/389/ticket/47853 Reviewed by: ? --- ldap/servers/plugins/memberof/memberof.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ldap/servers/plugins/memberof/memberof.c b/ldap/servers/plugins/memberof/memberof.c index 8257e9d..526e95f 100644 --- a/ldap/servers/plugins/memberof/memberof.c +++ b/ldap/servers/plugins/memberof/memberof.c @@ -1604,9 +1604,8 @@ memberof_modop_one_replace_r(Slapi_PBlock *pb, MemberOfConfig *config, slapi_entry_attr_find( e, config->groupattrs[i], &members ); if(members) { - if(memberof_mod_attr_list_r(pb, config, mod_op, group_sdn, - op_this_sdn, members, ll) != 0){ - rc = -1; + if((rc = memberof_mod_attr_list_r(pb, config, mod_op, group_sdn, + op_this_sdn, members, ll)) != 0){ goto bail; } } -- 1.9.3