summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Orling <TicoTimo@gmail.com>2015-08-06 08:11:53 -0700
committerTim Orling <TicoTimo@gmail.com>2015-08-06 08:11:53 -0700
commit82c21bec3f89ed9242a8a9d63589b794900c143c (patch)
tree47e1bf7707edd689e86e15341696ca70ba2068b5
parent705c18c234f4b9d9bb8978460657dbf36c5d698c (diff)
downloadperl-Alien-Packages-82c21bec3f89ed9242a8a9d63589b794900c143c.tar.gz
perl-Alien-Packages-82c21bec3f89ed9242a8a9d63589b794900c143c.tar.xz
perl-Alien-Packages-82c21bec3f89ed9242a8a9d63589b794900c143c.zip
Clean up spec file per review (#1242723)HEADmaster
-rw-r--r--.rpmlint4
-rw-r--r--perl-Alien-Packages.spec42
2 files changed, 26 insertions, 20 deletions
diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..1db595b
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,4 @@
+from Config import *
+addFilter("spelling-error .* dpkg");
+addFilter("spelling-error .* lslpp");
+addFilter("spelling-error .* pkginfo");
diff --git a/perl-Alien-Packages.spec b/perl-Alien-Packages.spec
index dc36c89..3f888a9 100644
--- a/perl-Alien-Packages.spec
+++ b/perl-Alien-Packages.spec
@@ -1,26 +1,31 @@
Name: perl-Alien-Packages
Version: 0.003
-Release: 1%{?dist}
-Summary: Alien::Packages Perl module
+Release: 2%{?dist}
+Summary: Find information of installed packages
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Alien-Packages/
Source0: http://www.cpan.org/authors/id/R/RE/REHSACK/Alien-Packages-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
-BuildRequires: perl(IPC::Cmd)
-BuildRequires: perl(IPC::Run)
+# Build:
+BuildRequires: perl
BuildRequires: perl(Module::Build)
+BuildRequires: perl(strict)
+BuildRequires: perl(vars)
+BuildRequires: perl(warnings)
+# Run-time:
+BuildRequires: perl(Carp)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(IPC::Cmd)
BuildRequires: perl(Module::Pluggable) >= 4.5
-BuildRequires: perl(Test::More) >= 0.90
-Requires: perl(IPC::Cmd)
-Requires: perl(IPC::Run)
-Requires: perl(Module::Pluggable) >= 4.5
+# Tests:
+BuildRequires: perl(Test::More)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description
-my @packages = $ap->list_packages(); foreach my $pkg (@packages) { print
-"$pkg->[0] version $pkg->[1]: $pkg->[2]\n"; }
+Find information of packages installed in the OS, e.g. Debian dpkg, AIX lslpp,
+Microsoft MSI, Sun pkginfo, NetBSD portable packages, FreeBSD ports, Red Hat
+RPM.
%prep
%setup -q -n Alien-Packages-%{version}
@@ -30,25 +35,22 @@ my @packages = $ap->list_packages(); foreach my $pkg (@packages) { print
./Build
%install
-rm -rf $RPM_BUILD_ROOT
-
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
%{_fixperms} $RPM_BUILD_ROOT/*
%check
./Build test
-%clean
-rm -rf $RPM_BUILD_ROOT
-
%files
-%defattr(-,root,root,-)
-%doc Changes META.json README
+%doc Changes README
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
-* Thu Apr 02 2015 Tim Orling 0.003-1
+* Thu Aug 06 2015 Tim Orling <ticotimo@gmail.com> - 0.003-2
+- Add better description and summary
+- Cleanup spec file per review (#1242723)
+
+* Thu Apr 02 2015 Tim Orling <ticotimo@gmail.com> - 0.003-1
- Specfile autogenerated by cpanspec 1.78.