From eebd53a26acf3db448e48fe5ca8a650857023841 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Fri, 5 Oct 2007 19:23:19 +0000 Subject: * src/itdb_device.c: Remove duplicate reference to ithmb file The iPod classic artwork formats contained two references to an ithmb file using 1060 as its filename. This confuses the ithumb writing code which can't handle that properly. Fixes that for now by removing the entry. We could probably be more clever in itdb_write_ithumb_files and generate two lists of iThumbWriters, one for artwork and another one for photos. This would fix that bug as well git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1719 f01d2545-417e-4e96-918e-98f8d0dbbcb6 --- ChangeLog | 15 ++++++++++++++- src/itdb_device.c | 1 - 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1751b8a..06c648a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,17 @@ -2007-10-05 Christophe Fergeau + + * src/itdb_device.c: + Remove duplicate reference to ithmb file + + The iPod classic artwork formats contained two references to an + ithmb file using 1060 as its filename. This confuses the ithumb + writing code which can't handle that properly. Fixes that for now by + removing the entry. We could probably be more clever in + itdb_write_ithumb_files and generate two lists of iThumbWriters, + one for artwork and another one for photos. This would fix that bug + as well + +2007-10-05 Christophe Fergeau * src/db-artwork-writer.c: (itdb_track_filter_thumbnails), (itdb_filter_thumbnails), (ipod_write_artwork_db): diff --git a/src/itdb_device.c b/src/itdb_device.c index 0c5fe49..62391db 100644 --- a/src/itdb_device.c +++ b/src/itdb_device.c @@ -318,7 +318,6 @@ static const Itdb_ArtworkFormat ipod_classic_1_artwork_info[] = { /* not sure if the THUMB_FORMAT is correct */ {ITDB_THUMB_PHOTO_FULL_SCREEN,320, 240, 1064, THUMB_FORMAT_RGB565_LE}, {ITDB_THUMB_PHOTO_SMALL, 64, 64, 1066, THUMB_FORMAT_RGB565_LE}, - {ITDB_THUMB_PHOTO_LARGE, 320, 320, 1060, THUMB_FORMAT_RGB565_LE}, /* These are the same as for the iPod video... -- labeled by the iPod as "chapter images" */ {ITDB_THUMB_COVER_SMALL, 100, 100, 1028, THUMB_FORMAT_RGB565_LE}, -- cgit