| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
* db-artwork-writer.c: increased IPOD_MMAP_SIZE from 2 to 16 MB as
a temporary workaround until a propoer solution can be
implemented.
* db-itunes-parser.h: replaced the #pragma pack(4) with an
'packed' attribute on _MhiiHeader only.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1211 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
segfault when hald is present.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1210 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
to David Desrosiers.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1207 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/db-itunes-parser.h: add '#pragma pack(4)' to fix 64bit
issue with padding (at least as a temporary fix).
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1206 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
caused ipod-detection to fail if hal daemon was not running. As
a consequence cover art was not written to the iPod.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1205 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
the Shuffle's stat file (0x18 was used as minimal record length
instead of decimal '18').
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1202 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
| |
removed nested-functions. Thanks to Brian Jackson for the patch
(he was not the only to send patches -- please, nobody feel
offended that I didn't act sooner).
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1201 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
unused computed value (thanks to Martin Aumueller)
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1200 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
| |
before accessing it to avoid segfault when hald is not running.
(ipod_device_hal_initialize) fixed memory leak: 'error' was not
freed if libhal_ctx_init() failed.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1199 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
fread/fwrite/ftell because of possible compiler warnings.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1198 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
| |
pixbuf even if no iPod is present if the thumbnail points to a
local filename. This way artwork support is also possible on the
'Local' repository in gtkpod (or any other application).
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1193 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
| |
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1192 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
compilation error on some systems.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1191 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
not present.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1190 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
write to it.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1189 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
terminate the application just because the iTunesDB was
manipulated).
* src/db-artwork-parser.c: change g_assert to g_return_if_fail
(don't terminate the application just because the ArtworkDB was
manipulated).
* src/itdb_artwork.c: change g_assert to g_return_if_fail
(don't terminate the application just because the ithmb file was
manipulated).
There's a number of g_asserts left in db-parse-context.c which don't catch programming errors but input errors.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1188 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
| |
better, take care of dbid2 a little better.
* src/ithumb-writer.c: new ithumb_rearrange_thumbnail_file()
taking into account multiple references to the same slot.
ithumb-writer now cleans up 0 Byte files.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1187 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
| |
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1186 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
| |
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1185 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
src/itdb_track.c, src/ithumb-writer.c: handle artwork size and
count self-consistently.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1184 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
not exist.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1183 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/db-artwork-parser.c: (parse_mhni): don't crash if
ipod_image_new_from_mhni returns NULL
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1182 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
| |
* src/itdb_artwork.c: (unpack_RGB_565), (get_pixel_data):
* src/itdb_itunesdb.c: (get_mhod):
* src/ithumb-writer.c: (pack_RGB_565),
(ithumb_rearrange_thumbnail_file): added some paranoia checks before
doing some mallocs to prevent potential int overflows in some mallocs
which could be triggered by using forged iTunesDB files
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1181 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* src/itdb.h: Introduced Itdb_Artwork and ItdbThumbType and
changed Itdb_Image to Itdb_Thumb throughout the source.
* src/itdb_artwork.c: new file as backend for Itdb_Artwork support
(new, free, duplicate, get_thumb_by_type, add_thumbnail,
remove_thumbnail, remove_thumbnails), as well as for the
Itdb_Thumb support (new, free, duplicate, get_gdk_pixbuf,
get_filename)
* src/itdb_track.c: new functions for artwork support
(set_thumbnails, remove_thumbnails)
* src/ithumb-writer.c: added support to write thumbnails in
addition to existing thumbnails
* src/db-artwork-parcer.c: (mhod3_get_ithmb_filename)
* src/itdb_itunesdb.c: (update_artwork_info)
* tests/test-covers.c: updated to new API.
* tests/test-write-covers.c: updated to new API.
Known issues: iTunes wipes off our thumbnails.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1180 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
"tests/test-thumbnails <ipod_mount> to copy all thumbnails into
the current directory.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1172 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* src/db-artwork-debug.c: (get_utf16_string):
* src/db-artwork-parser.c: (get_utf16_string), (parse_mhod_3),
(parse_mhni), (ipod_supports_cover_art), (ipod_parse_artwork_db):
* src/db-artwork-parser.h:
* src/db-artwork-writer.c: (get_artwork_info), (write_mhod_type_3),
(write_mhni), (write_mhod), (write_mhii), (write_mhif):
* src/db-image-parser.c: (unpack_RGB_565),
(image_type_from_corr_id), (ipod_image_new_from_mhni):
* src/db-image-parser.h:
* src/itdb.h:
* src/ithumb-writer.c: (pack_RGB_565),
(ithumb_writer_write_thumbnail), (ipod_image_get_ithmb_filename),
(ithumb_writer_new), (ithumb_writer_free), (write_thumbnail),
(itdb_write_ithumb_files):
* tests/test-covers.c: (save_song_thumbnails): rework artwork code in
an attempt to properly support artwork on all the iPod models
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1171 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
| |
* src/hal-common.c:
* tests/test-covers.c: (ipod_image_to_gdk_pixbuf): more glib 2.4
changes
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1170 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
* src/ipod-device.c: fix compilation issue when hal isn't available
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1166 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
* src/glib-compat.h: include stdio.h in the glib 2.4 compat code
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1164 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* configure.ac: set version number to 0.2.0
* src/Makefile.am: added glib-compat.h
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1162 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/glib-compat.h: added a missing helper file for glib 2.4
compilation
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1161 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/hal-common.c:
* src/ipod-device.c: marked some functions as static
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1160 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* src/ipod-device.c: fix g_mkdir_with_parents use (don't use it with
glib 2.8, and mark it static)
2005-11-21 Christophe Fergeau <teuf@gnome.org>
* src/db-artwork-writer.c: (write_mhod_type_3):
* src/db-parse-context.c:
* src/ipod-device.c:
* src/itdb_private.h:
* src/itdb_track.c:
* src/ithumb-writer.c: (ithumb_writer_write_thumbnail): commit some
changes which should help compiling with glib 2.4
2005-11-21 Christophe Fergeau <teuf@gnome.org>
* autogen.sh:
* gnome-autogen.sh: use autogen.sh script from gnome-common since the
custom libgpod one keep having issues (this doesn't add a dependency
on gnome-common since I imported the necessary script to our CVS)
2005-11-21 Christophe Fergeau <teuf@gnome.org>
* INSTALL:
* autogen.sh:
* gnome-autogen.sh:
2005-11-21 Christophe Fergeau <teuf@gnome.org>
* src/hal-common.h: mark hal stubs (for when hal isn't available) as
G_GNUC_INTERNAL to avoid namespace clashes
* src/ipod-device.c:
* src/ipod-device.h: move hal header inclusion in the .c instead of
having it in the .h
2005-11-19 Jorg Schuler <jcsjcs at users.sourceforge.net>
* itdb_playlist.c: simplified API for itdb_spl_update() and
itdb_splr_eval()
* itdb_playlist.c: added itdb_spl_update_live() for convenience
* itdb_itunesdb.c: (itdb_rename_files) also remove "iTunesShuffle"
as this file might confuse iPod Shuffles.
2005-11-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
* configure.ac: check for version 2.4 of glib -- now we need to
make sure that libgpod actually works with 2.4...
2005-11-15 Christophe Fergeau <teuf@gnome.org>
* src/itdb_itunesdb.c: (itdb_new): initialise glib type system before
calling ipod_device_new (which creates a gobject)
2005-11-13 Jorg Schuler <jcsjcs at users.sourceforge.net>
* src/itdb_itunesdb.c: when new rating is set on the iPod, backup
the old rating to app_rating. Not sure what it's for, but iTunes
seem to do it.
* src/itdb_itunesdb.c:
* src/itdb.h: split unk164 into flag1, flag2, flag3, and flag4.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1159 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
| |
* src/db-artwork-writer.c: (write_mhod_type_3):
* src/db-parse-context.c:
* src/ipod-device.c:
* src/itdb_private.h:
* src/itdb_track.c:
* src/ithumb-writer.c: (ithumb_writer_write_thumbnail): commit some
changes which should help compiling with glib 2.4
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1158 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
| |
* src/hal-common.h: mark hal stubs (for when hal isn't available) as
G_GNUC_INTERNAL to avoid namespace clashes
* src/ipod-device.c:
* src/ipod-device.h: move hal header inclusion in the .c instead of
having it in the .h
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1156 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
as this file might confuse iPod Shuffles.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1155 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
| |
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1154 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
itdb_splr_eval()
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1153 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/itdb_itunesdb.c: (itdb_new): initialise glib type system before
calling ipod_device_new (which creates a gobject)
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1151 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
* src/itdb.h: split unk164 into flag1, flag2, flag3, and flag4.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1150 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
| |
backup
the old rating to app_rating. Not sure what it's for, but iTunes
seem to do it.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1149 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
| |
(audio/video) if not already set to non-zero.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1148 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
| |
itdb_device_new() with NULL pointer (no mountpoint == local
repository) to avoid critical warning.
* src/itdb.h src/itdb_itunesdb.c: change API for
itdb_shuffle_write() to be identical to itdb_itunesdb_write()
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1147 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/hal-common.c:
* src/hal-common.h: more #if => #ifdef changes
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1145 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/ipod-device.c:
* src/ipod-device.h: update comments to reflect the fact we are using
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1144 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
| |
* src/hal-common.c:
* src/hal-common.h:
* src/ipod-device.c: (ipod_device_set_property),
(ipod_device_hal_initialize), (ipod_device_detect_volume_info),
(ipod_device_new), (ipod_device_eject): sync with libipoddevice CVS,
use #ifdef HAVE_LIBHAL instead of #if HAVE_LIBHAL
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1143 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
| |
* src/ipod-device.h:
* src/itdb.h: added missing G_BEGIN_DECLS and G_END_DECLS
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1142 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
| |
* src/itdb_track.c: (is_video_ipod), (itdb_track_set_defaults): deal
with unk208 differently on iPod video (it's used to indicate if the
current track must be shown in the video or audio menu or both)
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1141 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
| |
* src/ipod-device.c: (ipod_device_get_property),
(ipod_device_class_init):
* src/ipod-device.h: sync with libipoddevice CVS to get information
about artwork formats supported by the various iPod models
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1140 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* src/ipod-device.c: (ipod_device_new):
* src/ipod-device.h:
* src/itdb.h:
* src/itdb_itunesdb.c: (itdb_free), (itdb_parse),
(itdb_shuffle_write), (itdb_set_mountpoint): added an IpodDevice
element to Itdb_iTunesDB. This makes it possible for libgpod to know
the type (regular/nano/mini/video/...) of the iPod it's currently
dealing with (which is necessary for proper cover art support for
example)
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1139 f01d2545-417e-4e96-918e-98f8d0dbbcb6
|