summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ChangeLog9
-rw-r--r--src/itdb_artwork.c5
2 files changed, 12 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 3c7c1ee..a0d9b39 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2007-03-21 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
+ * src/itdb_artwork.c (itdb_artwork_remove_thumbnail): memory used
+ by thumbnail to be removed will be freed now. ATTENTION: this
+ changes the previous API description that stated that the
+ thumbnail will not be freed. This behaviour was inconsistent
+ with all other _remove functions in libgpod and caused a memory
+ hole.
+
2007-03-02 Todd Zullinger <tmzullinger at users.sourceforge.net>
* bindings/Makefile.am: only descend into the python subdir if
diff --git a/src/itdb_artwork.c b/src/itdb_artwork.c
index 2defb4d..80b9a7f 100644
--- a/src/itdb_artwork.c
+++ b/src/itdb_artwork.c
@@ -1,4 +1,4 @@
-/* Time-stamp: <2006-11-26 23:31:45 jcs>
+/* Time-stamp: <2007-03-21 14:12:58 jcs>
|
| Copyright (C) 2002-2005 Jorg Schuler <jcsjcs at users sourceforge net>
| Part of the gtkpod project.
@@ -122,7 +122,7 @@ Itdb_Artwork *itdb_artwork_duplicate (Itdb_Artwork *artwork)
* @artwork: an #Itdb_Artwork
* @thumb: an #Itdb_Thumb
*
- * Removes @thumb from @artwork. The memory used by @thumb isn't freed.
+ * Removes @thumb from @artwork. The memory used by @thumb is freed.
**/
void
itdb_artwork_remove_thumbnail (Itdb_Artwork *artwork, Itdb_Thumb *thumb)
@@ -131,6 +131,7 @@ itdb_artwork_remove_thumbnail (Itdb_Artwork *artwork, Itdb_Thumb *thumb)
g_return_if_fail (thumb);
artwork->thumbnails = g_list_remove (artwork->thumbnails, thumb);
+ itdb_thumb_free (thumb);
}