diff options
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | src/itdb_playlist.c | 10 | ||||
| -rw-r--r-- | src/itdb_track.c | 5 |
3 files changed, 13 insertions, 8 deletions
@@ -1,5 +1,11 @@ 2006-10-02 Jorg Schuler <jcsjcs at users.sourceforge.net> + * src/itdb_playlist.c (itdb_playlist_add, itdb_playlist_add_track): + src/itdb_track.c (itdb_track_add): simplify code by using + g_list_insert(). + +2006-10-02 Jorg Schuler <jcsjcs at users.sourceforge.net> + * tests/Makefile.am tests/test-init-ipod.c: fix compilation error when building with --disable-gdk-pixbuf. Thanks to David Philippi and Christophe diff --git a/src/itdb_playlist.c b/src/itdb_playlist.c index b6c5d9a..0ed0060 100644 --- a/src/itdb_playlist.c +++ b/src/itdb_playlist.c @@ -1,4 +1,4 @@ -/* Time-stamp: <2006-09-23 21:25:39 jcs> +/* Time-stamp: <2006-10-22 17:42:28 jcs> | | Copyright (C) 2002-2005 Jorg Schuler <jcsjcs at users sourceforge net> | Part of the gtkpod project. @@ -1232,8 +1232,9 @@ void itdb_playlist_add (Itdb_iTunesDB *itdb, Itdb_Playlist *pl, gint32 pos) } if (pl->sortorder == 0) pl->sortorder = ITDB_PSO_MANUAL; if (pl->timestamp == 0) pl->timestamp = itdb_time_get_mac_time (); - if (pos == -1) itdb->playlists = g_list_append (itdb->playlists, pl); - else itdb->playlists = g_list_insert (itdb->playlists, pl, pos); + + /* pos == -1 appends at the end of the list */ + itdb->playlists = g_list_insert (itdb->playlists, pl, pos); } @@ -1335,8 +1336,7 @@ void itdb_playlist_add_track (Itdb_Playlist *pl, track->itdb = pl->itdb; - if (pos == -1) pl->members = g_list_append (pl->members, track); - else pl->members = g_list_insert (pl->members, track, pos); + pl->members = g_list_insert (pl->members, track, pos); } diff --git a/src/itdb_track.c b/src/itdb_track.c index e304e30..1d3d2e0 100644 --- a/src/itdb_track.c +++ b/src/itdb_track.c @@ -1,4 +1,4 @@ -/* Time-stamp: <2006-09-18 01:33:31 jcs> +/* Time-stamp: <2006-10-22 17:42:23 jcs> | | Copyright (C) 2002-2005 Jorg Schuler <jcsjcs at users sourceforge net> | Part of the gtkpod project. @@ -234,8 +234,7 @@ void itdb_track_add (Itdb_iTunesDB *itdb, Itdb_Track *track, gint32 pos) itdb_track_set_defaults (track); - if (pos == -1) itdb->tracks = g_list_append (itdb->tracks, track); - else itdb->tracks = g_list_insert (itdb->tracks, track, pos); + itdb->tracks = g_list_insert (itdb->tracks, track, pos); } /** |