diff options
| author | Jorg Schuler <jcsjcs@users.sourceforge.net> | 2007-11-17 06:04:28 +0000 |
|---|---|---|
| committer | Jorg Schuler <jcsjcs@users.sourceforge.net> | 2007-11-17 06:04:28 +0000 |
| commit | 4155283e4f0680d032d2aa43fe612ac33403637f (patch) | |
| tree | c01ecd4599773f846c07a0cf0be9d6da66147f3a | |
| parent | 2b722d6ab35ed275d04ec31908813e4c6df61cdb (diff) | |
| download | libgpod-4155283e4f0680d032d2aa43fe612ac33403637f.tar.gz libgpod-4155283e4f0680d032d2aa43fe612ac33403637f.tar.xz libgpod-4155283e4f0680d032d2aa43fe612ac33403637f.zip | |
* src/itdb_playlist.c (itdb_splr_eval): track length in rules for
smart playlists was treated as seconds, but the iPod treats them
as milliseconds. If you told libgpod to create a smart playlist
with tracks less than 100 secs in length, but the life update of
the iPod would interpret that rule as "tracks less than 100 msec
in length", giving a vastly different result. Tested with iPod
Nano 1G and iPod nano Video (3G).
Requires corresponding fix in GUIs using this function.
git-svn-id: https://gtkpod.svn.sf.net/svnroot/gtkpod/libgpod/trunk@1794 f01d2545-417e-4e96-918e-98f8d0dbbcb6
| -rw-r--r-- | ChangeLog | 12 | ||||
| -rw-r--r-- | src/itdb_playlist.c | 4 |
2 files changed, 14 insertions, 2 deletions
@@ -1,3 +1,15 @@ +2007-11-14 Jorg Schuler <jcsjcs at users.sourceforge.net> + + * src/itdb_playlist.c (itdb_splr_eval): track length in rules for + smart playlists was treated as seconds, but the iPod treats them + as milliseconds. If you told libgpod to create a smart playlist + with tracks less than 100 secs in length, but the life update of + the iPod would interpret that rule as "tracks less than 100 msec + in length", giving a vastly different result. Tested with iPod + Nano 1G and iPod nano Video (3G). + + Requires corresponding fix in GUIs using this function. + 2007-11-16 Christophe Fergeau <teuf@gnome.org> * src/itdb_device.c: fix typoes in iPod Touch model lists diff --git a/src/itdb_playlist.c b/src/itdb_playlist.c index 1649343..779b7a5 100644 --- a/src/itdb_playlist.c +++ b/src/itdb_playlist.c @@ -1,4 +1,4 @@ -/* Time-stamp: <2007-02-25 11:52:48 jcs> +/* Time-stamp: <2007-11-17 15:01:39 jcs> | | Copyright (C) 2002-2005 Jorg Schuler <jcsjcs at users sourceforge net> | Part of the gtkpod project. @@ -424,7 +424,7 @@ gboolean itdb_splr_eval (Itdb_SPLRule *splr, Itdb_Track *track) handled = TRUE; break; case ITDB_SPLFIELD_TIME: - intcomp = track->tracklen/1000; + intcomp = track->tracklen; handled = TRUE; break; case ITDB_SPLFIELD_COMPILATION: |