<!DOCTYPE html>
<html lang='en'>
<head>
<title>shared « kra-ui « dogtag « pki - pki.git - Unnamed repository; edit this file 'description' to name the repository.</title>
<meta name='generator' content='cgit '/>
<meta name='robots' content='index, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit-data/cgit.css'/>
<link rel='shortcut icon' href='/favicon.ico'/>
<link rel='alternate' title='Atom feed' href='https://fedorapeople.org/cgit/edewata/public_git/pki.git/atom/pki/dogtag/kra-ui/shared?h=ticket-407-4' type='application/atom+xml'/>
<link rel='vcs-git' href='git://fedorapeople.org/home/fedora/edewata/public_git/pki.git' title='pki.git Git repository'/>
<link rel='vcs-git' href='ssh://fedorapeople.org/home/fedora/edewata/public_git/pki.git' title='pki.git Git repository'/>
<link rel='vcs-git' href='https://fedorapeople.org/cgit/edewata/public_git/pki.git' title='pki.git Git repository'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit/'><img src='/cgit-data/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit/'>index</a> : <a title='pki.git' href='/cgit/edewata/public_git/pki.git/'>pki.git</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='40d3643b8d91886bf210aa27f711731c81a11e49'/><select name='h' onchange='this.form.submit();'>
<option value='abhishek-33'>abhishek-33</option>
<option value='abhishek-34'>abhishek-34</option>
<option value='alee-101'>alee-101</option>
<option value='alee-112'>alee-112</option>
<option value='alee-73'>alee-73</option>
<option value='alee-76'>alee-76</option>
<option value='alee-78'>alee-78</option>
<option value='alee-79'>alee-79</option>
<option value='alee-82'>alee-82</option>
<option value='alee-86'>alee-86</option>
<option value='alee-91'>alee-91</option>
<option value='alee-93'>alee-93</option>
<option value='alee-95'>alee-95</option>
<option value='alee-interpolation'>alee-interpolation</option>
<option value='branch-10.2.7'>branch-10.2.7</option>
<option value='branch-10.2.7-dev1'>branch-10.2.7-dev1</option>
<option value='dev'>dev</option>
<option value='dev1'>dev1</option>
<option value='dev2'>dev2</option>
<option value='dev3'>dev3</option>
<option value='direct-deployment'>direct-deployment</option>
<option value='direct-deployment2'>direct-deployment2</option>
<option value='dogtag-9'>dogtag-9</option>
<option value='javacard'>javacard</option>
<option value='master'>master</option>
<option value='ticket-190'>ticket-190</option>
<option value='ticket-190-1'>ticket-190-1</option>
<option value='ticket-213'>ticket-213</option>
<option value='ticket-213-1'>ticket-213-1</option>
<option value='ticket-213-2'>ticket-213-2</option>
<option value='ticket-213-3'>ticket-213-3</option>
<option value='ticket-214'>ticket-214</option>
<option value='ticket-214-1'>ticket-214-1</option>
<option value='ticket-214-2'>ticket-214-2</option>
<option value='ticket-2226-1'>ticket-2226-1</option>
<option value='ticket-2244-2'>ticket-2244-2</option>
<option value='ticket-2278-21'>ticket-2278-21</option>
<option value='ticket-309'>ticket-309</option>
<option value='ticket-328'>ticket-328</option>
<option value='ticket-328-1'>ticket-328-1</option>
<option value='ticket-328-10'>ticket-328-10</option>
<option value='ticket-328-2'>ticket-328-2</option>
<option value='ticket-328-3'>ticket-328-3</option>
<option value='ticket-328-4'>ticket-328-4</option>
<option value='ticket-328-5'>ticket-328-5</option>
<option value='ticket-328-6'>ticket-328-6</option>
<option value='ticket-328-7'>ticket-328-7</option>
<option value='ticket-328-8'>ticket-328-8</option>
<option value='ticket-328-9'>ticket-328-9</option>
<option value='ticket-365'>ticket-365</option>
<option value='ticket-367'>ticket-367</option>
<option value='ticket-367-1'>ticket-367-1</option>
<option value='ticket-380'>ticket-380</option>
<option value='ticket-380-1'>ticket-380-1</option>
<option value='ticket-380-2'>ticket-380-2</option>
<option value='ticket-380-3'>ticket-380-3</option>
<option value='ticket-380-4'>ticket-380-4</option>
<option value='ticket-380-5'>ticket-380-5</option>
<option value='ticket-380-6'>ticket-380-6</option>
<option value='ticket-380-7'>ticket-380-7</option>
<option value='ticket-380-8'>ticket-380-8</option>
<option value='ticket-380-9'>ticket-380-9</option>
<option value='ticket-398'>ticket-398</option>
<option value='ticket-399'>ticket-399</option>
<option value='ticket-399-1'>ticket-399-1</option>
<option value='ticket-399-2'>ticket-399-2</option>
<option value='ticket-399-3'>ticket-399-3</option>
<option value='ticket-399-4'>ticket-399-4</option>
<option value='ticket-399-5'>ticket-399-5</option>
<option value='ticket-399-6'>ticket-399-6</option>
<option value='ticket-399-7'>ticket-399-7</option>
<option value='ticket-399-8'>ticket-399-8</option>
<option value='ticket-399-9'>ticket-399-9</option>
<option value='ticket-399b'>ticket-399b</option>
<option value='ticket-400'>ticket-400</option>
<option value='ticket-400-1'>ticket-400-1</option>
<option value='ticket-403'>ticket-403</option>
<option value='ticket-404'id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
<a id='n51' href='#n51'>51</a>
<a id='n52' href='#n52'>52</a>
<a id='n53' href='#n53'>53</a>
<a id='n54' href='#n54'>54</a>
<a id='n55' href='#n55'>55</a>
<a id='n56' href='#n56'>56</a>
<a id='n57' href='#n57'>57</a>
<a id='n58' href='#n58'>58</a>
<a id='n59' href='#n59'>59</a>
<a id='n60' href='#n60'>60</a>
<a id='n61' href='#n61'>61</a>
<a id='n62' href='#n62'>62</a>
<a id='n63' href='#n63'>63</a>
<a id='n64' href='#n64'>64</a>
<a id='n65' href='#n65'>65</a>
<a id='n66' href='#n66'>66</a>
<a id='n67' href='#n67'>67</a>
<a id='n68' href='#n68'>68</a>
<a id='n69' href='#n69'>69</a>
<a id='n70' href='#n70'>70</a>
<a id='n71' href='#n71'>71</a>
<a id='n72' href='#n72'>72</a>
<a id='n73' href='#n73'>73</a>
<a id='n74' href='#n74'>74</a>
<a id='n75' href='#n75'>75</a>
<a id='n76' href='#n76'>76</a>
<a id='n77' href='#n77'>77</a>
<a id='n78' href='#n78'>78</a>
<a id='n79' href='#n79'>79</a>
<a id='n80' href='#n80'>80</a>
<a id='n81' href='#n81'>81</a>
<a id='n82' href='#n82'>82</a>
<a id='n83' href='#n83'>83</a>
<a id='n84' href='#n84'>84</a>
<a id='n85' href='#n85'>85</a>
<a id='n86' href='#n86'>86</a>
<a id='n87' href='#n87'>87</a>
<a id='n88' href='#n88'>88</a>
<a id='n89' href='#n89'>89</a>
<a id='n90' href='#n90'>90</a>
<a id='n91' href='#n91'>91</a>
<a id='n92' href='#n92'>92</a>
<a id='n93' href='#n93'>93</a>
<a id='n94' href='#n94'>94</a>
<a id='n95' href='#n95'>95</a>
<a id='n96' href='#n96'>96</a>
<a id='n97' href='#n97'>97</a>
<a id='n98' href='#n98'>98</a>
<a id='n99' href='#n99'>99</a>
<a id='n100' href='#n100'>100</a>
<a id='n101' href='#n101'>101</a>
<a id='n102' href='#n102'>102</a>
<a id='n103' href='#n103'>103</a>
<a id='n104' href='#n104'>104</a>
<a id='n105' href='#n105'>105</a>
<a id='n106' href='#n106'>106</a>
<a id='n107' href='#n107'>107</a>
<a id='n108' href='#n108'>108</a>
<a id='n109' href='#n109'>109</a>
<a id='n110' href='#n110'>110</a>
<a id='n111' href='#n111'>111</a>
<a id='n112' href='#n112'>112</a>
<a id='n113' href='#n113'>113</a>
<a id='n114' href='#n114'>114</a>
<a id='n115' href='#n115'>115</a>
<a id='n116' href='#n116'>116</a>
<a id='n117' href='#n117'>117</a>
<a id='n118' href='#n118'>118</a>
<a id='n119' href='#n119'>119</a>
<a id='n120' href='#n120'>120</a>
<a id='n121' href='#n121'>121</a>
<a id='n122' href='#n122'>122</a>
<a id='n123' href='#n123'>123</a>
<a id='n124' href='#n124'>124</a>
<a id='n125' href='#n125'>125</a>
<a id='n126' href='#n126'>126</a>
<a id='n127' href='#n127'>127</a>
<a id='n128' href='#n128'>128</a>
<a id='n129' href='#n129'>129</a>
<a id='n130' href='#n130'>130</a>
<a id='n131' href='#n131'>131</a>
<a id='n132' href='#n132'>132</a>
<a id='n133' href='#n133'>133</a>
<a id='n134' href='#n134'>134</a>
<a id='n135' href='#n135'>135</a>
<a id='n136' href='#n136'>136</a>
<a id='n137' href='#n137'>137</a>
<a id='n138' href='#n138'>138</a>
<a id='n139' href='#n139'>139</a>
<a id='n140' href='#n140'>140</a>
<a id='n141' href='#n141'>141</a>
<a id='n142' href='#n142'>142</a>
<a id='n143' href='#n143'>143</a>
<a id='n144' href='#n144'>144</a>
<a id='n145' href='#n145'>145</a>
<a id='n146' href='#n146'>146</a>
<a id='n147' href='#n147'>147</a>
<a id='n148' href='#n148'>148</a>
<a id='n149' href='#n149'>149</a>
<a id='n150' href='#n150'>150</a>
<a id='n151' href='#n151'>151</a>
<a id='n152' href='#n152'>152</a>
<a id='n153' href='#n153'>153</a>
<a id='n154' href='#n154'>154</a>
<a id='n155' href='#n155'>155</a>
<a id='n156' href='#n156'>156</a>
<a id='n157' href='#n157'>157</a>
<a id='n158' href='#n158'>158</a>
<a id='n159' href='#n159'>159</a>
<a id='n160' href='#n160'>160</a>
<a id='n161' href='#n161'>161</a>
<a id='n162' href='#n162'>162</a>
<a id='n163' href='#n163'>163</a>
<a id='n164' href='#n164'>164</a>
<a id='n165' href='#n165'>165</a>
<a id='n166' href='#n166'>166</a>
<a id='n167' href='#n167'>167</a>
<a id='n168' href='#n168'>168</a>
<a id='n169' href='#n169'>169</a>
<a id='n170' href='#n170'>170</a>
<a id='n171' href='#n171'>171</a>
<a id='n172' href='#n172'>172</a>
<a id='n173' href='#n173'>173</a>
<a id='n174' href='#n174'>174</a>
<a id='n175' href='#n175'>175</a>
<a id='n176' href='#n176'>176</a>
<a id='n177' href='#n177'>177</a>
<a id='n178' href='#n178'>178</a>
<a id='n179' href='#n179'>179</a>
<a id='n180' href='#n180'>180</a>
<a id='n181' href='#n181'>181</a>
<a id='n182' href='#n182'>182</a>
<a id='n183' href='#n183'>183</a>
<a id='n184' href='#n184'>184</a>
<a id='n185' href='#n185'>185</a>
<a id='n186' href='#n186'>186</a>
<a id='n187' href='#n187'>187</a>
<a id='n188' href='#n188'>188</a>
<a id='n189' href='#n189'>189</a>
<a id='n190' href='#n190'>190</a>
<a id='n191' href='#n191'>191</a>
<a id='n192' href='#n192'>192</a>
<a id='n193' href='#n193'>193</a>
<a id='n194' href='#n194'>194</a>
<a id='n195' href='#n195'>195</a>
<a id='n196' href='#n196'>196</a>
<a id='n197' href='#n197'>197</a>
<a id='n198' href='#n198'>198</a>
<a id='n199' href='#n199'>199</a>
<a id='n200' href='#n200'>200</a>
<a id='n201' href='#n201'>201</a>
<a id='n202' href='#n202'>202</a>
<a id='n203' href='#n203'>203</a>
<a id='n204' href='#n204'>204</a>
<a id='n205' href='#n205'>205</a>
<a id='n206' href='#n206'>206</a>
<a id='n207' href='#n207'>207</a>
<a id='n208' href='#n208'>208</a>
<a id='n209' href='#n209'>209</a>
<a id='n210' href='#n210'>210</a>
<a id='n211' href='#n211'>211</a>
<a id='n212' href='#n212'>212</a>
<a id='n213' href='#n213'>213</a>
<a id='n214' href='#n214'>214</a>
<a id='n215' href='#n215'>215</a>
<a id='n216' href='#n216'>216</a>
<a id='n217' href='#n217'>217</a>
<a id='n218' href='#n218'>218</a>
<a id='n219' href='#n219'>219</a>
<a id='n220' href='#n220'>220</a>
<a id='n221' href='#n221'>221</a>
<a id='n222' href='#n222'>222</a>
<a id='n223' href='#n223'>223</a>
<a id='n224' href='#n224'>224</a>
<a id='n225' href='#n225'>225</a>
<a id='n226' href='#n226'>226</a>
<a id='n227' href='#n227'>227</a>
<a id='n228' href='#n228'>228</a>
<a id='n229' href='#n229'>229</a>
<a id='n230' href='#n230'>230</a>
<a id='n231' href='#n231'>231</a>
<a id='n232' href='#n232'>232</a>
<a id='n233' href='#n233'>233</a>
<a id='n234' href='#n234'>234</a>
<a id='n235' href='#n235'>235</a>
<a id='n236' href='#n236'>236</a>
<a id='n237' href='#n237'>237</a>
<a id='n238' href='#n238'>238</a>
<a id='n239' href='#n239'>239</a>
<a id='n240' href='#n240'>240</a>
<a id='n241' href='#n241'>241</a>
<a id='n242' href='#n242'>242</a>
<a id='n243' href='#n243'>243</a>
<a id='n244' href='#n244'>244</a>
<a id='n245' href='#n245'>245</a>
<a id='n246' href='#n246'>246</a>
<a id='n247' href='#n247'>247</a>
<a id='n248' href='#n248'>248</a>
<a id='n249' href='#n249'>249</a>
<a id='n250' href='#n250'>250</a>
<a id='n251' href='#n251'>251</a>
<a id='n252' href='#n252'>252</a>
<a id='n253' href='#n253'>253</a>
<a id='n254' href='#n254'>254</a>
<a id='n255' href='#n255'>255</a>
<a id='n256' href='#n256'>256</a>
<a id='n257' href='#n257'>257</a>
<a id='n258' href='#n258'>258</a>
<a id='n259' href='#n259'>259</a>
<a id='n260' href='#n260'>260</a>
<a id='n261' href='#n261'>261</a>
<a id='n262' href='#n262'>262</a>
<a id='n263' href='#n263'>263</a>
<a id='n264' href='#n264'>264</a>
<a id='n265' href='#n265'>265</a>
<a id='n266' href='#n266'>266</a>
<a id='n267' href='#n267'>267</a>
<a id='n268' href='#n268'>268</a>
<a id='n269' href='#n269'>269</a>
<a id='n270' href='#n270'>270</a>
<a id='n271' href='#n271'>271</a>
<a id='n272' href='#n272'>272</a>
<a id='n273' href='#n273'>273</a>
<a id='n274' href='#n274'>274</a>
<a id='n275' href='#n275'>275</a>
<a id='n276' href='#n276'>276</a>
<a id='n277' href='#n277'>277</a>
<a id='n278' href='#n278'>278</a>
<a id='n279' href='#n279'>279</a>
<a id='n280' href='#n280'>280</a>
<a id='n281' href='#n281'>281</a>
<a id='n282' href='#n282'>282</a>
<a id='n283' href='#n283'>283</a>
<a id='n284' href='#n284'>284</a>
<a id='n285' href='#n285'>285</a>
<a id='n286' href='#n286'>286</a>
<a id='n287' href='#n287'>287</a>
<a id='n288' href='#n288'>288</a>
<a id='n289' href='#n289'>289</a>
<a id='n290' href='#n290'>290</a>
<a id='n291' href='#n291'>291</a>
<a id='n292' href='#n292'>292</a>
<a id='n293' href='#n293'>293</a>
<a id='n294' href='#n294'>294</a>
<a id='n295' href='#n295'>295</a>
<a id='n296' href='#n296'>296</a>
<a id='n297' href='#n297'>297</a>
<a id='n298' href='#n298'>298</a>
<a id='n299' href='#n299'>299</a>
<a id='n300' href='#n300'>300</a>
<a id='n301' href='#n301'>301</a>
<a id='n302' href='#n302'>302</a>
<a id='n303' href='#n303'>303</a>
<a id='n304' href='#n304'>304</a>
<a id='n305' href='#n305'>305</a>
<a id='n306' href='#n306'>306</a>
<a id='n307' href='#n307'>307</a>
<a id='n308' href='#n308'>308</a>
<a id='n309' href='#n309'>309</a>
<a id='n310' href='#n310'>310</a>
<a id='n311' href='#n311'>311</a>
<a id='n312' href='#n312'>312</a>
<a id='n313' href='#n313'>313</a>
<a id='n314' href='#n314'>314</a>
<a id='n315' href='#n315'>315</a>
<a id='n316' href='#n316'>316</a>
<a id='n317' href='#n317'>317</a>
<a id='n318' href='#n318'>318</a>
<a id='n319' href='#n319'>319</a>
<a id='n320' href='#n320'>320</a>
<a id='n321' href='#n321'>321</a>
<a id='n322' href='#n322'>322</a>
<a id='n323' href='#n323'>323</a>
<a id='n324' href='#n324'>324</a>
<a id='n325' href='#n325'>325</a>
<a id='n326' href='#n326'>326</a>
<a id='n327' href='#n327'>327</a>
<a id='n328' href='#n328'>328</a>
<a id='n329' href='#n329'>329</a>
<a id='n330' href='#n330'>330</a>
</pre></td>
<td class='lines'><pre><code>From 0a74d0f27e8d60e427b447a041bc061917d85fac Mon Sep 17 00:00:00 2001
From: Benjamin Tissoires &lt;benjamin.tissoires&#64;redhat.com&gt;
Date: Mon, 3 Apr 2017 18:18:21 +0200
Subject: [PATCH] Input: rmi4 - remove the need for artificial IRQ in case of
 HID

The IRQ from rmi4 may interfere with the one we currently use on i2c-hid.
Given that there is already a need for an external API from rmi4 to
forward the attention data, we can, in this particular case rely on a
separate workqueue to prevent cursor jumps.

Reported-by: Cameron Gutman &lt;aicommander&#64;gmail.com&gt;
Reported-by: Thorsten Leemhuis &lt;linux&#64;leemhuis.info&gt;
Reported-by: Jason Ekstrand &lt;jason&#64;jlekstrand.net&gt;
Tested-by: Andrew Duggan &lt;aduggan&#64;synaptics.com&gt;
Signed-off-by: Benjamin Tissoires &lt;benjamin.tissoires&#64;redhat.com&gt;
Signed-off-by: Lyude &lt;lyude&#64;redhat.com&gt;
<span class="hl kwb">---</span>
 drivers/hid/hid-rmi.c           |  64 -----------------
 drivers/input/rmi4/rmi_driver.c | 124 +++++++++++++++++++-------------
 include/linux/rmi.h             |   1 +
 3 files changed, 75 insertions(+), 114 deletions(-)

diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 9e33165250a3..e7e33a160b47 100644
<span class="hl kwb">--- a/drivers/hid/hid-rmi.c</span>
<span class="hl kwa">+++ b/drivers/hid/hid-rmi.c</span>
&#64;&#64; -316,19 +316,12 &#64;&#64; static int rmi_input_event(struct hid_device *hdev, u8 *data, int size)
 {
 	struct rmi_data *hdata = hid_get_drvdata(hdev);
 	struct rmi_device *rmi_dev = hdata-&gt;xport.rmi_dev;
<span class="hl kwb">-	unsigned long flags;</span>
 
 	if (!(test_bit(RMI_STARTED, &amp;hdata-&gt;flags)))
 		return 0;
 
<span class="hl kwb">-	local_irq_save(flags);</span>
<span class="hl kwb">-</span>
 	rmi_set_attn_data(rmi_dev, data[1], &amp;data[2], size - 2);
 
<span class="hl kwb">-	generic_handle_irq(hdata-&gt;rmi_irq);</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	local_irq_restore(flags);</span>
<span class="hl kwb">-</span>
 	return 1;
 }
 
&#64;&#64; -586,56 +579,6 &#64;&#64; static const struct rmi_transport_ops hid_rmi_ops = {
 	.reset		= rmi_hid_reset,
 };
 
<span class="hl kwb">-static void rmi_irq_teardown(void *data)</span>
<span class="hl kwb">-{</span>
<span class="hl kwb">-	struct rmi_data *hdata = data;</span>
<span class="hl kwb">-	struct irq_domain *domain = hdata-&gt;domain;</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	if (!domain)</span>
<span class="hl kwb">-		return;</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	irq_dispose_mapping(irq_find_mapping(domain, 0));</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	irq_domain_remove(domain);</span>
<span class="hl kwb">-	hdata-&gt;domain = NULL;</span>
<span class="hl kwb">-	hdata-&gt;rmi_irq = 0;</span>
<span class="hl kwb">-}</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-static int rmi_irq_map(struct irq_domain *h, unsigned int virq,</span>
<span class="hl kwb">-		       irq_hw_number_t hw_irq_num)</span>
<span class="hl kwb">-{</span>
<span class="hl kwb">-	irq_set_chip_and_handler(virq, &amp;dummy_irq_chip, handle_simple_irq);</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	return 0;</span>
<span class="hl kwb">-}</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-static const struct irq_domain_ops rmi_irq_ops = {</span>
<span class="hl kwb">-	.map = rmi_irq_map,</span>
<span class="hl kwb">-};</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-static int rmi_setup_irq_domain(struct hid_device *hdev)</span>
<span class="hl kwb">-{</span>
<span class="hl kwb">-	struct rmi_data *hdata = hid_get_drvdata(hdev);</span>
<span class="hl kwb">-	int ret;</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	hdata-&gt;domain = irq_domain_create_linear(hdev-&gt;dev.fwnode, 1,</span>
<span class="hl kwb">-						 &amp;rmi_irq_ops, hdata);</span>
<span class="hl kwb">-	if (!hdata-&gt;domain)</span>
<span class="hl kwb">-		return -ENOMEM;</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	ret = devm_add_action_or_reset(&amp;hdev-&gt;dev, &amp;rmi_irq_teardown, hdata);</span>
<span class="hl kwb">-	if (ret)</span>
<span class="hl kwb">-		return ret;</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	hdata-&gt;rmi_irq = irq_create_mapping(hdata-&gt;domain, 0);</span>
<span class="hl kwb">-	if (hdata-&gt;rmi_irq &lt;= 0) {</span>
<span class="hl kwb">-		hid_err(hdev, &quot;Can't allocate an IRQ\n&quot;);</span>
<span class="hl kwb">-		return hdata-&gt;rmi_irq &lt; 0 ? hdata-&gt;rmi_irq : -ENXIO;</span>
<span class="hl kwb">-	}</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	return 0;</span>
<span class="hl kwb">-}</span>
<span class="hl kwb">-</span>
 static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
 {
 	struct rmi_data *data = NULL;
&#64;&#64; -708,18 +651,11 &#64;&#64; static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
 
 	mutex_init(&amp;data-&gt;page_mutex);
 
<span class="hl kwb">-	ret = rmi_setup_irq_domain(hdev);</span>
<span class="hl kwb">-	if (ret) {</span>
<span class="hl kwb">-		hid_err(hdev, &quot;failed to allocate IRQ domain\n&quot;);</span>
<span class="hl kwb">-		return ret;</span>
<span class="hl kwb">-	}</span>
<span class="hl kwb">-</span>
 	if (data-&gt;device_flags &amp; RMI_DEVICE_HAS_PHYS_BUTTONS)
 		rmi_hid_pdata.f30_data.disable = true;
 
 	data-&gt;xport.dev = hdev-&gt;dev.parent;
 	data-&gt;xport.pdata = rmi_hid_pdata;
<span class="hl kwb">-	data-&gt;xport.pdata.irq = data-&gt;rmi_irq;</span>
 	data-&gt;xport.proto_name = &quot;hid&quot;;
 	data-&gt;xport.ops = &amp;hid_rmi_ops;
 
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index fc3ab93b7aea..35bc90141db8 100644
<span class="hl kwb">--- a/drivers/input/rmi4/rmi_driver.c</span>
<span class="hl kwa">+++ b/drivers/input/rmi4/rmi_driver.c</span>
&#64;&#64; -185,34 +185,47 &#64;&#64; void rmi_set_attn_data(struct rmi_device *rmi_dev, unsigned long irq_status,
 	attn_data.data = fifo_data;
 
 	kfifo_put(&amp;drvdata-&gt;attn_fifo, attn_data);
<span class="hl kwa">+</span>
<span class="hl kwa">+	schedule_work(&amp;drvdata-&gt;attn_work);</span>
 }
 EXPORT_SYMBOL_GPL(rmi_set_attn_data);
 
<span class="hl kwb">-static irqreturn_t rmi_irq_fn(int irq, void *dev_id)</span>
<span class="hl kwa">+static void attn_callback(struct work_struct *work)</span>
 {
<span class="hl kwb">-	struct rmi_device *rmi_dev = dev_id;</span>
<span class="hl kwb">-	struct rmi_driver_data *drvdata = dev_get_drvdata(&amp;rmi_dev-&gt;dev);</span>
<span class="hl kwa">+	struct rmi_driver_data *drvdata = container_of(work,</span>
<span class="hl kwa">+							struct rmi_driver_data,</span>
<span class="hl kwa">+							attn_work);</span>
 	struct rmi4_attn_data attn_data = {0};
 	int ret, count;
 
 	count = kfifo_get(&amp;drvdata-&gt;attn_fifo, &amp;attn_data);
<span class="hl kwb">-	if (count) {</span>
<span class="hl kwb">-		*(drvdata-&gt;irq_status) = attn_data.irq_status;</span>
<span class="hl kwb">-		drvdata-&gt;attn_data = attn_data;</span>
<span class="hl kwb">-	}</span>
<span class="hl kwa">+	if (!count)</span>
<span class="hl kwa">+		return;</span>
 
<span class="hl kwb">-	ret = rmi_process_interrupt_requests(rmi_dev);</span>
<span class="hl kwa">+	*(drvdata-&gt;irq_status) = attn_data.irq_status;</span>
<span class="hl kwa">+	drvdata-&gt;attn_data = attn_data;</span>
<span class="hl kwa">+</span>
<span class="hl kwa">+	ret = rmi_process_interrupt_requests(drvdata-&gt;rmi_dev);</span>
 	if (ret)
<span class="hl kwb">-		rmi_dbg(RMI_DEBUG_CORE, &amp;rmi_dev-&gt;dev,</span>
<span class="hl kwa">+		rmi_dbg(RMI_DEBUG_CORE, &amp;drvdata-&gt;rmi_dev-&gt;dev,</span>
 			&quot;Failed to process interrupt request: %d\n&quot;, ret);
 
<span class="hl kwb">-	if (count) {</span>
<span class="hl kwb">-		kfree(attn_data.data);</span>
<span class="hl kwb">-		attn_data.data = NULL;</span>
<span class="hl kwb">-	}</span>
<span class="hl kwa">+	kfree(attn_data.data);</span>
<span class="hl kwa">+	attn_data.data = NULL;</span>
 
 	if (!kfifo_is_empty(&amp;drvdata-&gt;attn_fifo))
<span class="hl kwb">-		return rmi_irq_fn(irq, dev_id);</span>
<span class="hl kwa">+		schedule_work(&amp;drvdata-&gt;attn_work);</span>
<span class="hl kwa">+}</span>
<span class="hl kwa">+</span>
<span class="hl kwa">+static irqreturn_t rmi_irq_fn(int irq, void *dev_id)</span>
<span class="hl kwa">+{</span>
<span class="hl kwa">+	struct rmi_device *rmi_dev = dev_id;</span>
<span class="hl kwa">+	int ret;</span>
<span class="hl kwa">+</span>
<span class="hl kwa">+	ret = rmi_process_interrupt_requests(rmi_dev);</span>
<span class="hl kwa">+	if (ret)</span>
<span class="hl kwa">+		rmi_dbg(RMI_DEBUG_CORE, &amp;rmi_dev-&gt;dev,</span>
<span class="hl kwa">+			&quot;Failed to process interrupt request: %d\n&quot;, ret);</span>
 
 	return IRQ_HANDLED;
 }
&#64;&#64; -220,7 +233,6 &#64;&#64; static irqreturn_t rmi_irq_fn(int irq, void *dev_id)
 static int rmi_irq_init(struct rmi_device *rmi_dev)
 {
 	struct rmi_device_platform_data *pdata = rmi_get_platform_data(rmi_dev);
<span class="hl kwb">-	struct rmi_driver_data *data = dev_get_drvdata(&amp;rmi_dev-&gt;dev);</span>
 	int irq_flags = irq_get_trigger_type(pdata-&gt;irq);
 	int ret;
 
&#64;&#64; -238,8 +250,6 &#64;&#64; static int rmi_irq_init(struct rmi_device *rmi_dev)
 		return ret;
 	}
 
<span class="hl kwb">-	data-&gt;enabled = true;</span>
<span class="hl kwb">-</span>
 	return 0;
 }
 
&#64;&#64; -889,23 +899,27 &#64;&#64; void rmi_enable_irq(struct rmi_device *rmi_dev, bool clear_wake)
 	if (data-&gt;enabled)
 		goto out;
 
<span class="hl kwb">-	enable_irq(irq);</span>
<span class="hl kwb">-	data-&gt;enabled = true;</span>
<span class="hl kwb">-	if (clear_wake &amp;&amp; device_may_wakeup(rmi_dev-&gt;xport-&gt;dev)) {</span>
<span class="hl kwb">-		retval = disable_irq_wake(irq);</span>
<span class="hl kwb">-		if (retval)</span>
<span class="hl kwb">-			dev_warn(&amp;rmi_dev-&gt;dev,</span>
<span class="hl kwb">-				 &quot;Failed to disable irq for wake: %d\n&quot;,</span>
<span class="hl kwb">-				 retval);</span>
<span class="hl kwb">-	}</span>
<span class="hl kwa">+	if (irq) {</span>
<span class="hl kwa">+		enable_irq(irq);</span>
<span class="hl kwa">+		data-&gt;enabled = true;</span>
<span class="hl kwa">+		if (clear_wake &amp;&amp; device_may_wakeup(rmi_dev-&gt;xport-&gt;dev)) {</span>
<span class="hl kwa">+			retval = disable_irq_wake(irq);</span>
<span class="hl kwa">+			if (retval)</span>
<span class="hl kwa">+				dev_warn(&amp;rmi_dev-&gt;dev,</span>
<span class="hl kwa">+					 &quot;Failed to disable irq for wake: %d\n&quot;,</span>
<span class="hl kwa">+					 retval);</span>
<span class="hl kwa">+		}</span>
 
<span class="hl kwb">-	/*</span>
<span class="hl kwb">-	 * Call rmi_process_interrupt_requests() after enabling irq,</span>
<span class="hl kwb">-	 * otherwise we may lose interrupt on edge-triggered systems.</span>
<span class="hl kwb">-	 */</span>
<span class="hl kwb">-	irq_flags = irq_get_trigger_type(pdata-&gt;irq);</span>
<span class="hl kwb">-	if (irq_flags &amp; IRQ_TYPE_EDGE_BOTH)</span>
<span class="hl kwb">-		rmi_process_interrupt_requests(rmi_dev);</span>
<span class="hl kwa">+		/*</span>
<span class="hl kwa">+		 * Call rmi_process_interrupt_requests() after enabling irq,</span>
<span class="hl kwa">+		 * otherwise we may lose interrupt on edge-triggered systems.</span>
<span class="hl kwa">+		 */</span>
<span class="hl kwa">+		irq_flags = irq_get_trigger_type(pdata-&gt;irq);</span>
<span class="hl kwa">+		if (irq_flags &amp; IRQ_TYPE_EDGE_BOTH)</span>
<span class="hl kwa">+			rmi_process_interrupt_requests(rmi_dev);</span>
<span class="hl kwa">+	} else {</span>
<span class="hl kwa">+		data-&gt;enabled = true;</span>
<span class="hl kwa">+	}</span>
 
 out:
 	mutex_unlock(&amp;data-&gt;enabled_mutex);
&#64;&#64; -925,20 +939,22 &#64;&#64; void rmi_disable_irq(struct rmi_device *rmi_dev, bool enable_wake)
 		goto out;
 
 	data-&gt;enabled = false;
<span class="hl kwb">-	disable_irq(irq);</span>
<span class="hl kwb">-	if (enable_wake &amp;&amp; device_may_wakeup(rmi_dev-&gt;xport-&gt;dev)) {</span>
<span class="hl kwb">-		retval = enable_irq_wake(irq);</span>
<span class="hl kwb">-		if (retval)</span>
<span class="hl kwb">-			dev_warn(&amp;rmi_dev-&gt;dev,</span>
<span class="hl kwb">-				 &quot;Failed to enable irq for wake: %d\n&quot;,</span>
<span class="hl kwb">-				 retval);</span>
<span class="hl kwb">-	}</span>
<span class="hl kwb">-</span>
<span class="hl kwb">-	/* make sure the fifo is clean */</span>
<span class="hl kwb">-	while (!kfifo_is_empty(&amp;data-&gt;attn_fifo)) {</span>
<span class="hl kwb">-		count = kfifo_get(&amp;data-&gt;attn_fifo, &amp;attn_data);</span>
<span class="hl kwb">-		if (count)</span>
<span class="hl kwb">-			kfree(attn_data.data);</span>
<span class="hl kwa">+	if (irq) {</span>
<span class="hl kwa">+		disable_irq(irq);</span>
<span class="hl kwa">+		if (enable_wake &amp;&amp; device_may_wakeup(rmi_dev-&gt;xport-&gt;dev)) {</span>
<span class="hl kwa">+			retval = enable_irq_wake(irq);</span>
<span class="hl kwa">+			if (retval)</span>
<span class="hl kwa">+				dev_warn(&amp;rmi_dev-&gt;dev,</span>
<span class="hl kwa">+					 &quot;Failed to enable irq for wake: %d\n&quot;,</span>
<span class="hl kwa">+					 retval);</span>
<span class="hl kwa">+		}</span>
<span class="hl kwa">+	} else {</span>
<span class="hl kwa">+		/* make sure the fifo is clean */</span>
<span class="hl kwa">+		while (!kfifo_is_empty(&amp;data-&gt;attn_fifo)) {</span>
<span class="hl kwa">+			count = kfifo_get(&amp;data-&gt;attn_fifo, &amp;attn_data);</span>
<span class="hl kwa">+			if (count)</span>
<span class="hl kwa">+				kfree(attn_data.data);</span>
<span class="hl kwa">+		}</span>
 	}
 
 out:
&#64;&#64; -984,6 +1000,8 &#64;&#64; static int rmi_driver_remove(struct device *dev)
 	irq_domain_remove(data-&gt;irqdomain);
 	data-&gt;irqdomain = NULL;
 
<span class="hl kwa">+	cancel_work_sync(&amp;data-&gt;attn_work);</span>
<span class="hl kwa">+</span>
 	rmi_f34_remove_sysfs(rmi_dev);
 	rmi_free_function_list(rmi_dev);
 
&#64;&#64; -1221,9 +1239,15 &#64;&#64; static int rmi_driver_probe(struct device *dev)
 		}
 	}
 
<span class="hl kwb">-	retval = rmi_irq_init(rmi_dev);</span>
<span class="hl kwb">-	if (retval &lt; 0)</span>
<span class="hl kwb">-		goto err_destroy_functions;</span>
<span class="hl kwa">+	if (pdata-&gt;irq) {</span>
<span class="hl kwa">+		retval = rmi_irq_init(rmi_dev);</span>
<span class="hl kwa">+		if (retval &lt; 0)</span>
<span class="hl kwa">+			goto err_destroy_functions;</span>
<span class="hl kwa">+	}</span>
<span class="hl kwa">+</span>
<span class="hl kwa">+	data-&gt;enabled = true;</span>
<span class="hl kwa">+</span>
<span class="hl kwa">+	INIT_WORK(&amp;data-&gt;attn_work, attn_callback);</span>
 
 	if (data-&gt;f01_container-&gt;dev.driver) {
 		/* Driver already bound, so enable ATTN now. */
diff --git a/include/linux/rmi.h b/include/linux/rmi.h
index 5ef5c7c412a7..21f48f2807de 100644
<span class="hl kwb">--- a/include/linux/rmi.h</span>
<span class="hl kwa">+++ b/include/linux/rmi.h</span>
&#64;&#64; -366,6 +366,7 &#64;&#64; struct rmi_driver_data {
 
 	struct rmi4_attn_data attn_data;
 	DECLARE_KFIFO(attn_fifo, struct rmi4_attn_data, 16);
<span class="hl kwa">+	struct work_struct attn_work;</span>
 };
 
 int rmi_register_transport_device(struct rmi_transport_dev *xport);
<span class="hl kwb">-- </span>
2.17.1

</code></pre></td></tr></table>
</div> <!-- class=content -->
<div class='footer'>generated by <a href='https://git.zx2c4.com/cgit/about/'>cgit </a> (<a href='https://git-scm.com/'>git 2.34.1</a>) at 2024-06-20 23:36:05 +0000</div>
</div> <!-- id=cgit -->
</body>
</html>
