From 0b78d80e8014f38fcd75b156a4d83d2b1e01dbb9 Mon Sep 17 00:00:00 2001 From: "Justin M. Forbes" Date: Tue, 10 Oct 2017 08:36:45 -0500 Subject: Disable kernel tracking on SMBus devices (rhbz 1482648) --- ...-Disable-kernel-tracking-on-SMBus-devices.patch | 51 ++++++++++++++++++++++ kernel.spec | 6 +++ 2 files changed, 57 insertions(+) create mode 100644 Input-synaptics---Disable-kernel-tracking-on-SMBus-devices.patch diff --git a/Input-synaptics---Disable-kernel-tracking-on-SMBus-devices.patch b/Input-synaptics---Disable-kernel-tracking-on-SMBus-devices.patch new file mode 100644 index 000000000..81e858fd0 --- /dev/null +++ b/Input-synaptics---Disable-kernel-tracking-on-SMBus-devices.patch @@ -0,0 +1,51 @@ +From patchwork Thu Sep 28 20:07:19 2017 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: 8bit +Subject: Input: synaptics - Disable kernel tracking on SMBus devices +From: Andrew Duggan +X-Patchwork-Id: 9976729 +Message-Id: <1506629239-5940-1-git-send-email-aduggan@synaptics.com> +To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org +Cc: Andrew Duggan , + Dmitry Torokhov , + Benjamin Tissoires , + =?UTF-8?q?Kamil=20P=C3=A1ral?= +Date: Thu, 28 Sep 2017 13:07:19 -0700 + +In certain situations kernel tracking seems to be getting confused +and incorrectly reporting the slot of a contact. On example is when +the user does a three finger click or tap and then places two fingers +on the touchpad in the same area. The kernel tracking code seems to +continue to think that there are three contacts on the touchpad and +incorrectly alternates the slot of one of the contacts. The result that +is the input subsystem reports a stream of button press and release +events as the reported slot changes. + +Kernel tracking was originally enabled to prevent cursor jumps, but it +is unclear how much of an issue kernel jumps actually are. This patch +simply disabled kernel tracking for now. + +Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640 + +Signed-off-by: Andrew Duggan +Tested-by: Kamil Páral +Acked-by: Benjamin Tissoires +--- + drivers/input/mouse/synaptics.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c +index 5af0b7d..ee5466a 100644 +--- a/drivers/input/mouse/synaptics.c ++++ b/drivers/input/mouse/synaptics.c +@@ -1709,8 +1709,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, + .sensor_pdata = { + .sensor_type = rmi_sensor_touchpad, + .axis_align.flip_y = true, +- /* to prevent cursors jumps: */ +- .kernel_tracking = true, ++ .kernel_tracking = false, + .topbuttonpad = topbuttonpad, + }, + .f30_data = { diff --git a/kernel.spec b/kernel.spec index 62e84e1ee..5277a0afc 100644 --- a/kernel.spec +++ b/kernel.spec @@ -685,6 +685,9 @@ Patch628: 3-3-inet-fix-improper-empty-comparison.patch # rhbz 1497861 Patch629: 0001-platform-x86-peaq-wmi-Add-DMI-check-before-binding-t.patch +# rhbz 1482648 +Patch630: Input-synaptics---Disable-kernel-tracking-on-SMBus-devices.patch + # END OF PATCH DEFINITIONS %endif @@ -2239,6 +2242,9 @@ fi # # %changelog +* Tue Oct 10 2017 Justin M. Forbes +- Disable kernel tracking on SMBus devices (rhbz 1482648) + * Mon Oct 9 2017 Peter Robinson - Enable KASLR on aarch64 -- cgit