diff options
Diffstat (limited to 'libata-Drop-SanDisk-SD7UB3Q-G1001-NOLPM-quirk.patch')
| -rw-r--r-- | libata-Drop-SanDisk-SD7UB3Q-G1001-NOLPM-quirk.patch | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/libata-Drop-SanDisk-SD7UB3Q-G1001-NOLPM-quirk.patch b/libata-Drop-SanDisk-SD7UB3Q-G1001-NOLPM-quirk.patch new file mode 100644 index 000000000..97c6c2a37 --- /dev/null +++ b/libata-Drop-SanDisk-SD7UB3Q-G1001-NOLPM-quirk.patch @@ -0,0 +1,54 @@ +From b7f83ebcd7e36af0520f38fec9ba33da9394f09c Mon Sep 17 00:00:00 2001 +From: Hans de Goede <hdegoede@redhat.com> +Date: Thu, 31 May 2018 13:16:29 +0200 +Subject: [PATCH] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk + +Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk +SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs. + +This has lead to several reports of users of that SSD where LPM +was working fine and who know have a significantly increased idle +power consumption on their laptops. + +Likely there is another problem on the T450s from the original +reporter which gets exposed by the uncore reaching deeper sleep +states (higher PC-states) due to LPM being enabled. The problem as +reported, a hardfreeze about once a day, already did not sound like +it would be caused by LPM and the reports of the SSD working fine +confirm this. The original reporter is ok with dropping the quirk. + +A X250 user has reported the same hard freeze problem and for him +the problem went away after unrelated updates, I suspect some GPU +driver stack changes fixed things. + +TL;DR: The original reporters problem were triggered by LPM but not +an LPM issue, so drop the quirk for the SSD in question. + +BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1583207 +Cc: stable@vger.kernel.org +Cc: Richard W.M. Jones <rjones@redhat.com> +Cc: Lorenzo Dalrio <lorenzo.dalrio@gmail.com> +Reported-by: Lorenzo Dalrio <lorenzo.dalrio@gmail.com> +Signed-off-by: Hans de Goede <hdegoede@redhat.com> +Signed-off-by: Jeremy Cline <jcline@redhat.com> +--- + drivers/ata/libata-core.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c +index d4fb9e0c29ee..d8d45072e4ad 100644 +--- a/drivers/ata/libata-core.c ++++ b/drivers/ata/libata-core.c +@@ -4553,9 +4553,6 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { + ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NOLPM, }, + +- /* Sandisk devices which are known to not handle LPM well */ +- { "SanDisk SD7UB3Q*G1001", NULL, ATA_HORKAGE_NOLPM, }, +- + /* devices that don't properly handle queued TRIM commands */ + { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM, }, +-- +2.17.1 + |