summaryrefslogtreecommitdiffstats
path: root/xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch
diff options
context:
space:
mode:
authorJeremy Cline <jcline@redhat.com>2019-03-12 14:57:08 +0000
committerJeremy Cline <jcline@redhat.com>2019-03-12 15:02:18 +0000
commitfe3f29352b50ab76164e008a657daaf01d61f48c (patch)
treee91711efb7acd777630afad35c0c74b9c12cb122 /xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch
parent88d17afb2447cdfd4235c04a28bdd232cce43f83 (diff)
downloadkernel-fe3f29352b50ab76164e008a657daaf01d61f48c.tar.gz
kernel-fe3f29352b50ab76164e008a657daaf01d61f48c.tar.xz
kernel-fe3f29352b50ab76164e008a657daaf01d61f48c.zip
Linux v5.0-10742-gea295481b6e3
Diffstat (limited to 'xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch')
-rw-r--r--xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch48
1 files changed, 0 insertions, 48 deletions
diff --git a/xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch b/xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch
deleted file mode 100644
index 4c55bf2da..000000000
--- a/xen-pciback-Don-t-disable-PCI_COMMAND-on-PCI-device-.patch
+++ /dev/null
@@ -1,48 +0,0 @@
-From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
-Date: Fri, 27 Mar 2015 13:31:11 -0400
-Subject: [PATCH] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
-
-There is no need for this at all. Worst it means that if
-the guest tries to write to BARs it could lead (on certain
-platforms) to PCI SERR errors.
-
-Please note that with af6fc858a35b90e89ea7a7ee58e66628c55c776b
-"xen-pciback: limit guest control of command register"
-a guest is still allowed to enable those control bits (safely), but
-is not allowed to disable them and that therefore a well behaved
-frontend which enables things before using them will still
-function correctly.
-
-This is done via an write to the configuration register 0x4 which
-triggers on the backend side:
-command_write
- \- pci_enable_device
- \- pci_enable_device_flags
- \- do_pci_enable_device
- \- pcibios_enable_device
- \-pci_enable_resourcess
- [which enables the PCI_COMMAND_MEMORY|PCI_COMMAND_IO]
-
-However guests (and drivers) which don't do this could cause
-problems, including the security issues which XSA-120 sought
-to address.
-
-Reported-by: Jan Beulich <jbeulich@suse.com>
-Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
----
- drivers/xen/xen-pciback/pciback_ops.c | 2 --
- 1 file changed, 2 deletions(-)
-
-diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
-index c4a0666de6f5..26e651336787 100644
---- a/drivers/xen/xen-pciback/pciback_ops.c
-+++ b/drivers/xen/xen-pciback/pciback_ops.c
-@@ -119,8 +119,6 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
- if (pci_is_enabled(dev))
- pci_disable_device(dev);
-
-- pci_write_config_word(dev, PCI_COMMAND, 0);
--
- dev->is_busmaster = 0;
- } else {
- pci_read_config_word(dev, PCI_COMMAND, &cmd);