summaryrefslogtreecommitdiffstats
path: root/Input-synaptics-pin-3-touches-when-the-firmware-repo.patch
diff options
context:
space:
mode:
authorJosh Boyer <jwboyer@fedoraproject.org>2015-04-17 09:31:16 -0400
committerJosh Boyer <jwboyer@fedoraproject.org>2015-04-17 09:31:16 -0400
commit8b91e0bbd8717cec6fda1de2a16415d69b887e75 (patch)
treebdf070bd090519ef0684d3c5aee55c16f6c5691d /Input-synaptics-pin-3-touches-when-the-firmware-repo.patch
parent9b68c8a1f7ac2268ded0a09169fbefb269350c11 (diff)
downloadkernel-8b91e0bbd8717cec6fda1de2a16415d69b887e75.tar.gz
kernel-8b91e0bbd8717cec6fda1de2a16415d69b887e75.tar.xz
kernel-8b91e0bbd8717cec6fda1de2a16415d69b887e75.zip
Linux v4.0-7300-g4fc8adcfec3d
- Patch from Benjamin Tissoires to fix 3 finger tap on synaptics (rhbz 1212230) - Add patch to support touchpad on Google Pixel 2 (rhbz 1209088)
Diffstat (limited to 'Input-synaptics-pin-3-touches-when-the-firmware-repo.patch')
-rw-r--r--Input-synaptics-pin-3-touches-when-the-firmware-repo.patch50
1 files changed, 50 insertions, 0 deletions
diff --git a/Input-synaptics-pin-3-touches-when-the-firmware-repo.patch b/Input-synaptics-pin-3-touches-when-the-firmware-repo.patch
new file mode 100644
index 000000000..cdda67ad2
--- /dev/null
+++ b/Input-synaptics-pin-3-touches-when-the-firmware-repo.patch
@@ -0,0 +1,50 @@
+From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
+Date: Thu, 16 Apr 2015 13:01:46 -0400
+Subject: [PATCH] Input - synaptics: pin 3 touches when the firmware reports 3
+ fingers
+
+Synaptics PS/2 touchpad can send only 2 touches in a report. They can
+detect 4 or 5 and this information is valuable.
+
+In commit 63c4fda (Input: synaptics - allocate 3 slots to keep stability
+in image sensors), we allocate 3 slots, but we still continue to report
+the 2 available fingers. That means that the client sees 2 used slots while
+there is a total of 3 fingers advertised by BTN_TOOL_TRIPLETAP.
+
+For old kernels this is not a problem because max_slots was 2 and libinput/
+xorg-synaptics knew how to deal with that. Now that max_slot is 3, the
+clients ignore BTN_TOOL_TRIPLETAP and count the actual used slots (so 2).
+It then gets confused when receiving the BTN_TOOL_TRIPLETAP and DOUBLETAP
+information, and goes wild.
+
+We can pin the 3 slots until we get a total number of fingers below 2.
+
+Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1212230
+
+Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
+---
+ drivers/input/mouse/synaptics.c | 8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
+index 630af73e98c4..c69b308beb3f 100644
+--- a/drivers/input/mouse/synaptics.c
++++ b/drivers/input/mouse/synaptics.c
+@@ -935,6 +935,14 @@ static void synaptics_report_mt_data(struct psmouse *psmouse,
+ input_report_abs(dev, ABS_MT_PRESSURE, hw[i]->z);
+ }
+
++ /* keep (slot count <= num_fingers) by pinning all slots */
++ if (num_fingers >= 3) {
++ for (i = 0; i < 3; i++) {
++ input_mt_slot(dev, i);
++ input_mt_report_slot_state(dev, MT_TOOL_FINGER, true);
++ }
++ }
++
+ input_mt_drop_unused(dev);
+
+ /* Don't use active slot count to generate BTN_TOOL events. */
+--
+2.1.0
+