diff options
| author | Dave Jones <davej@redhat.com> | 2010-10-26 13:43:53 -0400 |
|---|---|---|
| committer | Dave Jones <davej@redhat.com> | 2010-10-26 13:43:53 -0400 |
| commit | 651b07c647c66c57b7d6acca2d58b3dd21069b2a (patch) | |
| tree | 5658b86217a1691859bf84a3a3e7b52a9d99f8fd | |
| parent | a791768570bae98c698d212d363f6c36ac5d42e5 (diff) | |
| download | kernel-651b07c647c66c57b7d6acca2d58b3dd21069b2a.tar.gz kernel-651b07c647c66c57b7d6acca2d58b3dd21069b2a.tar.xz kernel-651b07c647c66c57b7d6acca2d58b3dd21069b2a.zip | |
rpmlint fluff.
kernel.src:386: W: macro-in-comment %nobuildarches
kernel.src:432: W: macro-in-comment %post
kernel.src:1002: W: macro-in-comment %{vanillaversion}
kernel.src:1003: W: macro-in-comment %{kversion}
kernel.src:1005: W: macro-in-comment %{kversion}
kernel.src:1883: W: macro-in-comment %{image_install_path}
(Packagers should avoid using macros in comments, but this is a minor error.
The easy fix here is to %% comment out any macros in comments, to prevent
unexpected and random behavior.)
| -rw-r--r-- | kernel.spec | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/kernel.spec b/kernel.spec index 3cfabdc10..56c8e5349 100644 --- a/kernel.spec +++ b/kernel.spec @@ -383,7 +383,7 @@ Summary: The Linux kernel %endif # To temporarily exclude an architecture from being built, add it to -# %nobuildarches. Do _NOT_ use the ExclusiveArch: line, because if we +# %%nobuildarches. Do _NOT_ use the ExclusiveArch: line, because if we # don't build kernel-headers then the new build system will no longer let # us use the previous build of that package -- it'll just be completely AWOL. # Which is a BadThing(tm). @@ -429,7 +429,7 @@ Summary: The Linux kernel %define kernel_headers_conflicts libdrm-devel < 2.4.0-0.15 # -# Packages that need to be installed before the kernel is, because the %post +# Packages that need to be installed before the kernel is, because the %%post # scripts use them. # %define kernel_prereq fileutils, module-init-tools, initscripts >= 8.11.1-1, grubby >= 7.0.10-1 @@ -999,10 +999,10 @@ ApplyOptionalPatch() %endif %endif -# %{vanillaversion} : the full version name, e.g. 2.6.35-rc6-git3 -# %{kversion} : the base version, e.g. 2.6.34 +# %%{vanillaversion} : the full version name, e.g. 2.6.35-rc6-git3 +# %%{kversion} : the base version, e.g. 2.6.34 -# Use kernel-%{kversion}%{?dist} as the top-level directory name +# Use kernel-%%{kversion}%%{?dist} as the top-level directory name # so we can prep different trees within a single git directory. # Build a list of the other top-level kernel tree directories. @@ -1880,7 +1880,7 @@ fi %{_mandir}/man[1-8]/* %endif -# This is %{image_install_path} on an arch where that includes ELF files, +# This is %%{image_install_path} on an arch where that includes ELF files, # or empty otherwise. %define elf_image_install_path %{?kernel_image_elf:%{image_install_path}} |