From 1b276fc2991255d65c28fa2df03b7b9ecc7d4f7b Mon Sep 17 00:00:00 2001 From: hunt Date: Wed, 31 Jan 2007 20:13:02 +0000 Subject: 2007-01-31 Martin Hunt * string.c (_stp_string_init): Deleted. (_stp_sprintf): Deleted. (_stp_vsprintf): Deleted. (_stp_string_cat_cstr): Deleted. (_stp_string_cat_string): Deleted. (_stp_string_cat_char): Deleted. (_stp_string_ptr): Deleted. (_stp_string_cat): Deleted. (_stp_snprintf): Moved from vsprintf.c. (_stp_vscnprintf): Moved from vsprintf.c. * string.h (STP_STRING_SIZE): Deleted. (STP_NUM_STRINGS): Deleted. Remove all references to type "String". * vsprintf.c (_stp_vscnprintf): Moved to string.c. (_stp_snprintf): Moved to string.c * sym.c (_stp_symbol_sprint): Replaced with _stp_symbol_print, which writes to the print buffer. (_stp_symbol_sprint_basic): Replaced with _stp_symbol_snprint. * runtime.h: Include io.c. * stat-common.c: Use new _stp_print* functions. * stat.c: Ditto. * regs.c: Renamed to regs-ia64.c. * current.c: Renamed regs.c. * regs-ia64.c: New file (renamed from regs.c). * stack.c (_stp_stack_sprint): Renamed _stp_stack_print and now just prints to the print buffer. Calls __stp_stack_print instead of __stp_stack_sprint. (_stp_stack_snprint): New function. Calls _stp_stack_print and then copies the print buffer into a string. (_stp_stack_printj): Deleted. (_stp_ustack_sprint): Deleted. * stack-*.c: Rewritten to print instead of writing to strings. Uses new _stp_print* functions. * print.c (_stp_printf): Create new function instead of macro. (_stp_print): Ditto. (_stp_print_char): New function. * map.c: Use _stp_print() and _stp_print_char() instead of _stp_print_cstr(). * io.c (_stp_vlog): Use _stp_print() instead of _stp_string_cat_cstr(). * copy.c (_stp_string_from_user): Deleted. --- runtime/copy.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) (limited to 'runtime/copy.c') diff --git a/runtime/copy.c b/runtime/copy.c index 4d716861..da27673c 100644 --- a/runtime/copy.c +++ b/runtime/copy.c @@ -1,6 +1,6 @@ /* -*- linux-c -*- * Copy from user space functions - * Copyright (C) 2005, 2006 Red Hat Inc. + * Copyright (C) 2005, 2006, 2007 Red Hat Inc. * Copyright (C) 2005 Intel Corporation. * * This file is part of systemtap, and is free software. You can @@ -119,30 +119,6 @@ _stp_strncpy_from_user(char *dst, const char __user *src, long count) return res; } -/** Copy a String from userspace. - * Copies a string of up to \e count bytes from userspace into a String. - * If access to userspace fails, returns -EFAULT (some data may have been - * copied). - * @param str Destination String. - * @param src Source address, in user space. - * @param count Maximum number of bytes to copy, including the trailing NULL. - * - */ - -long _stp_string_from_user (String str, const char __user *src, long count) -{ - long res = -EFAULT; - if (count > STP_STRING_SIZE - str->len - 1) - count = STP_STRING_SIZE - str->len - 1; - if (access_ok(VERIFY_READ, src, count)) { - __stp_strncpy_from_user(str->buf + str->len, src, count, res); - if (res > 0) { - str->len += res; - str->buf[str->len] = '\0'; - } - } - return res; -} /** Copy a block of data from user space. * -- cgit