From a9e8f7e0533811be2cd7c9a88d9058da8caa1d11 Mon Sep 17 00:00:00 2001 From: fche Date: Sat, 6 Oct 2007 02:42:29 +0000 Subject: PR1119: unused variable elision warnings 2007-10-05 Frank Ch. Eigler PR 1119 * elaborate.cxx (semantic_pass_opt[12]): Warn on elided variables/functions in user script. * session.h (suppress_warnings): New field. Change "timing" to plain old bool. * main.cxx (main): Configure warnings on by default. * stap.1.in: Document this. PR 1119. * systemtap.base/warnings.*: New test. * futexes.stp, sig_by_proc.stp, small_demos/rwtiming.stp: Fix elision warnings. --- examples/ChangeLog | 5 +++++ examples/futexes.stp | 2 +- examples/sig_by_proc.stp | 2 +- examples/small_demos/rwtiming.stp | 5 ++++- 4 files changed, 11 insertions(+), 3 deletions(-) (limited to 'examples') diff --git a/examples/ChangeLog b/examples/ChangeLog index a6e2e840..a4df876c 100644 --- a/examples/ChangeLog +++ b/examples/ChangeLog @@ -1,3 +1,8 @@ +2007-10-05 Frank Ch. Eigler + + * futexes.stp, sig_by_proc.stp, small_demos/rwtiming.stp: Fix elision + warnings. + 2007-09-15 Wenji Huang * iostat-scsi.stp: Make module probe optional,clarify reference to flags. diff --git a/examples/futexes.stp b/examples/futexes.stp index 78af3c92..515a8db6 100644 --- a/examples/futexes.stp +++ b/examples/futexes.stp @@ -5,7 +5,7 @@ global thread_thislock # short global thread_blocktime # -global FUTEX_WAIT = 0, FUTEX_WAKE = 1 +global FUTEX_WAIT = 0 /*, FUTEX_WAKE = 1 */ global lock_waits # long-lived stats on (tid,lock) blockage elapsed time global process_names # long-lived pid-to-execname mapping diff --git a/examples/sig_by_proc.stp b/examples/sig_by_proc.stp index 192f3d34..18b236d3 100755 --- a/examples/sig_by_proc.stp +++ b/examples/sig_by_proc.stp @@ -11,7 +11,7 @@ # Print signal counts by process name in descending order. # -global sigcnt, pid2name, sig2name +global sigcnt, sig2name probe begin { print("Collecting data... Type Ctrl-C to exit and display results\n") diff --git a/examples/small_demos/rwtiming.stp b/examples/small_demos/rwtiming.stp index c5a9aed3..d570c581 100755 --- a/examples/small_demos/rwtiming.stp +++ b/examples/small_demos/rwtiming.stp @@ -50,7 +50,10 @@ probe kernel.function("sys_write").return { probe end { foreach(name+ in names) { # sort by names printf ("process: %s\n", name) - if (opens[name]) printf ("opens n=%d\n", opens[name]) + if (opens[name]) { + printf ("opens n=%d\n", opens[name]) + print (@hist_log(time_opens[name])) + } if (@count(reads[name])) { printf ("reads n=%d, sum=%d, avg=%d\n", @count(reads[name]), # extracting stat results -- cgit